activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Bish (JIRA)" <jira+amq...@apache.org>
Subject [jira] Commented: (AMQNET-144) Default broker URL in nmsprovider-test.config should be the default URL of the broker, ie localhost:61616
Date Tue, 24 Feb 2009 13:34:59 GMT

    [ https://issues.apache.org/activemq/browse/AMQNET-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=49943#action_49943
] 

Timothy Bish commented on AMQNET-144:
-------------------------------------

Asking your user to modify a system file in order to run the unit tests is probably a bit
onerous, it assumes that everyone has access to the file, folks on a nix system who don't
have root privileges would not.  

Defaulting to the local host an then allowing for overrides via env vars would make incorporation
into continuous integration systems easier as well since the setup for broker location could
be done in a script for instance instead of relying on the fact that every CI machine had
the right entry in its hosts file.  

One solution could be to default the code to use localhost and port 61616 as the default then
allow for the URI to specify and env VAR in the form of ${HOST}:${PORT} or the like, this
is what we've done in AMQCPP.  The option could be retained to also check for the config file
and look there for the URI, and if that URI in the config file happened to reference an env
var for the host name or port then that would work too. 

> Default broker URL in nmsprovider-test.config should be the default URL of the broker,
ie localhost:61616
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: AMQNET-144
>                 URL: https://issues.apache.org/activemq/browse/AMQNET-144
>             Project: ActiveMQ .Net
>          Issue Type: Improvement
>         Environment: All
>            Reporter: Yev Bronshteyn
>            Assignee: Timothy Bish
>
> It's quite inconvenient to have to edit a text file on each checkout. An ideal way of
managing the broker URL would be defaulting to tcp://localhost:61616 and reading the rest
from a special en environment variable, let's say ACTIVEMQ_URL. This way, if somone's broker
is set up at a non-default hostname, the necessary tweak would be specific to that user's
system, and not to a copy of the source tree. I'd happily volunteer to implement the change
myself.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message