activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Jencks (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (AMQ-2045) Unbalanced Valve usage in VMTransport.
Date Mon, 29 Dec 2008 07:59:06 GMT

     [ https://issues.apache.org/activemq/browse/AMQ-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

David Jencks resolved AMQ-2045.
-------------------------------

    Resolution: Fixed
      Assignee: Hiram Chirino  (was: David Jencks)

rev 729835 adds consistency checks to Valve and removes the unbalanced decrement.  IMO this
should be reviewed by a more knowledgeable developer before closing... Hiram can you take
a look or suggest someone who could?

> Unbalanced Valve usage in VMTransport.
> --------------------------------------
>
>                 Key: AMQ-2045
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2045
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Transport
>    Affects Versions: 5.3.0
>            Reporter: David Jencks
>            Assignee: Hiram Chirino
>             Fix For: 5.3.0
>
>
> Valve doesn't check that its state is consistent (counters >= 0).  There's unbalanced
increment/decrement calls in VMTransport.oneway:
>                  enqueueValve.decrement();  //TODO unbalanced??
>  (line ~99) 
> If I balance this with a preceding enqueValve.increment() I get a deadlock in a test
when the server tries to send a response message so I assume the correct fix is to remove
the decrement in this VMTransports valve.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message