activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Timothy Bish <tabish...@gmail.com>
Subject Re: [VOTE] ActiveMQ 5.2.0 - RC3
Date Wed, 12 Nov 2008 14:51:22 GMT
Yes there does appear to be some issues with the test itself.  I haven't
been able to reproduce the error that I originally saw on the broker
side, tweaking the test seems to allow it to pass every time now.

Looks like we are ok, 

You can count this as my +1

Regards
Tim.

On Wed, 2008-11-12 at 14:57 +0100, Dejan Bosanac wrote:
> Hi Tim,
> 
> I've run this test with the trace on Stomp protocol and I think the
> broker behaves as it should and the test is not consistently.
> 
> Here are the steps produced by the test
> (https://svn.apache.org/repos/asf/activemq/activemq-cpp/trunk/src/test-integration/integration/connector/stomp/TransactionTest.cpp):
> 
> - subscribes to the /topic/mytopic
> 
> - sends 1000 text messages in the transaction
> 
> - commits
> 
> ==== right after this commit, messages starts coming to the client ====
> 
> - sends another set of 1000 text messages (comments says it should send
> byte messages, so can check that out too)
> 
> - commits
> 
> - waits for 2000 messages to arrive
> 
> ===== thus far everything works fine ====
> 
> - sends 1000 text messages
> 
> - rolls back
> 
> - waits for 1000 messages
> 
> ==== there are no messages to be sent to the client, since all messages
> sent in first two transactions are consumed, and those sent in the third
> transaction are never delivered (due to rollback)
> 
> ==== so the test fails
> 
> Can you please confirm this? Or did I get something wrong?
> 
> 
> 
> Cheers
> 
> -- 
> Dejan Bosanac
> 
> 
> http://www.ttmsolutions.com - get a free ActiveMQ user guide
> 
> ActiveMQ in Action - http://www.manning.com/snyder/
> Scripting in Java - http://www.scriptinginjava.net
> 
> 
> 
> 
> Timothy Bish wrote:
> > Yes, it does sometimes fail during the test and its connection gets
> > broken as well, it also stalls waiting for messages from the broker that
> > never come.  The Stack trace I posted so far has been the only error
> > messages I've seen on the broker, but it is not generated very often.
> >
> > Regards
> > Tim.
> >
> > On Mon, 2008-11-10 at 16:10 +0100, Dejan Bosanac wrote:
> >   
> >> So far I've managed to reproduce the problem with activemq-cpp-2.1.3 (the
> >> one I have installed) and 5.2.0 rc. It is interesting that I don't get this
> >> error with 5.3-SNAPSHOT I've built last week or so.
> >>
> >> Also, the test prints this message
> >>
> >> integration::connector::stomp::TransactionTest::test.StompConnector::enforceConnected
> >> - Not Connected!
> >>
> >> repeatedly, so it seems it looses a connection with the broker?
> >>
> >> I'll try to investigate it further these days.
> >>
> >> Cheers
> >>
> >>
> >> On Mon, Nov 10, 2008 at 1:03 PM, Timothy Bish <tabish121@gmail.com> wrote:
> >>
> >>     
> >>> On Mon, 2008-11-10 at 11:32 +0000, Gary Tully wrote:
> >>>       
> >>>> >From a quick look at the cpp project, I guess it is
> >>>>
> >>>>         
> >>> https://svn.apache.org/repos/asf/activemq/activemq-cpp/trunk/src/test-integration/integration/connector/stomp/TransactionTest.cpp
> >>>
> >>> Yes, that is the correct test case.
> >>>
> >>>       
> >>>> a topic is a transaction, which does not seem to have a corresponding
> >>>> java version but looks straight forward.
> >>>>         
> >>>       
> >>>> The stack trace on the broker points to the connection context being
> >>>> null, possibly related to the reuse of connectionIds or interleaving
a
> >>>> connection close with other activity.
> >>>>         
> >>>> 2008/11/10 Dejan Bosanac <dejan.bosanac@ttmsolutions.com>:
> >>>>         
> >>>>> Hi Tim,
> >>>>>
> >>>>> I can't recall any changes regarding Stomp and transactions between
5.1
> >>>>> and 5.2. Can you post a test case you are using?
> >>>>>
> >>>>> Cheers
> >>>>>
> >>>>> --
> >>>>> Dejan Bosanac
> >>>>>
> >>>>>
> >>>>> http://www.ttmsolutions.com - get a free ActiveMQ user guide
> >>>>>
> >>>>> ActiveMQ in Action - http://www.manning.com/snyder/
> >>>>> Scripting in Java - http://www.scriptinginjava.net
> >>>>>
> >>>>>
> >>>>>
> >>>>> Timothy Bish wrote:
> >>>>>           
> >>>>>> I've been testing the RC2 binary against ActiveMQ-CPP, unlike
the
> >>>>>>             
> >>> 5.1.0
> >>>       
> >>>>>> version I'm seeing fails in our Stomp Transaction tests sporadically.
> >>>>>> On some runs its fine, on other I see errors on the Broker side
which
> >>>>>> I've attached below, I don't ever see these with the previous
release.
> >>>>>>
> >>>>>> ERROR Service                        - Async error occurred:
> >>>>>> java.lang.NullPointerException
> >>>>>> java.lang.NullPointerException
> >>>>>>       at
> >>>>>>
> >>>>>>             
> >>> org.apache.activemq.broker.TransactionBroker.beginTransaction(TransactionBroker.java:153)
> >>>       
> >>>>>>       at
> >>>>>>
> >>>>>>             
> >>> org.apache.activemq.broker.BrokerFilter.beginTransaction(BrokerFilter.java:130)
> >>>       
> >>>>>>       at
> >>>>>>
> >>>>>>             
> >>> org.apache.activemq.broker.BrokerFilter.beginTransaction(BrokerFilter.java:130)
> >>>       
> >>>>>>       at
> >>>>>>
> >>>>>>             
> >>> org.apache.activemq.broker.MutableBrokerFilter.beginTransaction(MutableBrokerFilter.java:137)
> >>>       
> >>>>>>       at
> >>>>>>
> >>>>>>             
> >>> org.apache.activemq.broker.TransportConnection.processBeginTransaction(TransportConnection.java:370)
> >>>       
> >>>>>>       at
> >>>>>>
> >>>>>>             
> >>> org.apache.activemq.command.TransactionInfo.visit(TransactionInfo.java:94)
> >>>       
> >>>>>>       at
> >>>>>>
> >>>>>>             
> >>> org.apache.activemq.broker.TransportConnection.service(TransportConnection.java:305)
> >>>       
> >>>>>>       at org.apache.activemq.broker.TransportConnection
> >>>>>> $1.onCommand(TransportConnection.java:179)
> >>>>>>       at
> >>>>>>
> >>>>>>             
> >>> org.apache.activemq.transport.TransportFilter.onCommand(TransportFilter.java:68)
> >>>       
> >>>>>>       at
> >>>>>>
> >>>>>>             
> >>> org.apache.activemq.transport.stomp.StompTransportFilter.sendToActiveMQ(StompTransportFilter.java:78)
> >>>       
> >>>>>>       at
> >>>>>>
> >>>>>>             
> >>> org.apache.activemq.transport.stomp.ProtocolConverter.sendToActiveMQ(ProtocolConverter.java:135)
> >>>       
> >>>>>>       at
> >>>>>>
> >>>>>>             
> >>> org.apache.activemq.transport.stomp.ProtocolConverter.onStompBegin(ProtocolConverter.java:315)
> >>>       
> >>>>>>       at
> >>>>>>
> >>>>>>             
> >>> org.apache.activemq.transport.stomp.ProtocolConverter.onStompCommad(ProtocolConverter.java:177)
> >>>       
> >>>>>>       at
> >>>>>>
> >>>>>>             
> >>> org.apache.activemq.transport.stomp.StompTransportFilter.onCommand(StompTransportFilter.java:67)
> >>>       
> >>>>>>       at
> >>>>>>
> >>>>>>             
> >>> org.apache.activemq.transport.TransportSupport.doConsume(TransportSupport.java:84)
> >>>       
> >>>>>>       at
> >>>>>>
> >>>>>>             
> >>> org.apache.activemq.transport.tcp.TcpTransport.doRun(TcpTransport.java:203)
> >>>       
> >>>>>>       at
> >>>>>>
> >>>>>>             
> >>> org.apache.activemq.transport.tcp.TcpTransport.run(TcpTransport.java:185)
> >>>       
> >>>>>>       at java.lang.Thread.run(Thread.java:619)
> >>>>>> ERROR Service                        - Async error occurred:
> >>>>>> javax.jms.JMSException: Transaction
> >>>>>> 'TX:ID:office-60008-1226083222022-4:1:2' has not been started.
> >>>>>> javax.jms.JMSException: Transaction
> >>>>>> 'TX:ID:office-60008-1226083222022-4:1:2' has not been started.
> >>>>>>       at
> >>>>>>
> >>>>>>             
> >>> org.apache.activemq.broker.TransactionBroker.getTransaction(TransactionBroker.java:270)
> >>>       
> >>>>>>       at
> >>>>>>
> >>>>>>             
> >>> org.apache.activemq.broker.TransactionBroker.send(TransactionBroker.java:208)
> >>>       
> >>>>>>       at
> >>>>>>             
> >>> org.apache.activemq.broker.BrokerFilter.send(BrokerFilter.java:126)
> >>>       
> >>>>>>       at
> >>>>>>
> >>>>>>             
> >>> org.apache.activemq.broker.CompositeDestinationBroker.send(CompositeDestinationBroker.java:95)
> >>>       
> >>>>>>       at
> >>>>>>
> >>>>>>             
> >>> org.apache.activemq.broker.MutableBrokerFilter.send(MutableBrokerFilter.java:133)
> >>>       
> >>>>>>       at
> >>>>>>
> >>>>>>             
> >>> org.apache.activemq.broker.TransportConnection.processMessage(TransportConnection.java:450)
> >>>       
> >>>>>>       at
> >>>>>>
> >>>>>>             
> >>> org.apache.activemq.command.ActiveMQMessage.visit(ActiveMQMessage.java:639)
> >>>       
> >>>>>>       at
> >>>>>>
> >>>>>>             
> >>> org.apache.activemq.broker.TransportConnection.service(TransportConnection.java:305)
> >>>       
> >>>>>>       at org.apache.activemq.broker.TransportConnection
> >>>>>> $1.onCommand(TransportConnection.java:179)
> >>>>>>       at
> >>>>>>
> >>>>>>             
> >>> org.apache.activemq.transport.TransportFilter.onCommand(TransportFilter.java:68)
> >>>       
> >>>>>>       at
> >>>>>>
> >>>>>>             
> >>> org.apache.activemq.transport.stomp.StompTransportFilter.sendToActiveMQ(StompTransportFilter.java:78)
> >>>       
> >>>>>>       at
> >>>>>>
> >>>>>>             
> >>> org.apache.activemq.transport.stomp.ProtocolConverter.sendToActiveMQ(ProtocolConverter.java:135)
> >>>       
> >>>>>>       at
> >>>>>>
> >>>>>>             
> >>> org.apache.activemq.transport.stomp.ProtocolConverter.onStompSend(ProtocolConverter.java:246)
> >>>       
> >>>>>>       at
> >>>>>>
> >>>>>>             
> >>> org.apache.activemq.transport.stomp.ProtocolConverter.onStompCommad(ProtocolConverter.java:173)
> >>>       
> >>>>>>       at
> >>>>>>
> >>>>>>             
> >>> org.apache.activemq.transport.stomp.StompTransportFilter.onCommand(StompTransportFilter.java:67)
> >>>       
> >>>>>>       at
> >>>>>>
> >>>>>>             
> >>> org.apache.activemq.transport.TransportSupport.doConsume(TransportSupport.java:84)
> >>>       
> >>>>>>       at
> >>>>>>
> >>>>>>             
> >>> org.apache.activemq.transport.tcp.TcpTransport.doRun(TcpTransport.java:203)
> >>>       
> >>>>>>       at
> >>>>>>
> >>>>>>             
> >>> org.apache.activemq.transport.tcp.TcpTransport.run(TcpTransport.java:185)
> >>>       
> >>>>>>       at java.lang.Thread.run(Thread.java:619)
> >>>>>>
> >>>>>>
> >>>>>> On Thu, 2008-11-06 at 12:33 +0000, Gary Tully wrote:
> >>>>>>
> >>>>>>             
> >>>>>>> Hi Everyone,
> >>>>>>>
> >>>>>>> I've cut a new release candidate for 5.2.0
> >>>>>>>
> >>>>>>> There are an additional 25 resolved issues since RC2:
> >>>>>>>
> >>>>>>>               
> >>> https://issues.apache.org/activemq/sr/jira.issueviews:searchrequest-printable/temp/SearchRequest.html?&query=%22These+fixes+will+now+make+5.2.0+rc3%22&body=true&pid=10520&fixfor=11841&status=5&tempMax=1000
> >>>       
> >>>>>>> Could you guys review the release artifacts and vote?
> >>>>>>>
> >>>>>>> The release notes are here:
> >>>>>>>
> >>>>>>>               
> >>> http://cwiki.apache.org/confluence/display/ACTIVEMQ/ActiveMQ+5.2.0+Release
> >>>       
> >>>>>>> You can get the binary distributions here:
> >>>>>>>
> >>>>>>>               
> >>> http://people.apache.org/~gtully/staging-repos/activemq-5.2.0/org/apache/activemq/apache-activemq/5.2.0<http://people.apache.org/%7Egtully/staging-repos/activemq-5.2.0/org/apache/activemq/apache-activemq/5.2.0>
> >>>       
> >>>>>>> The Maven2 repository is at:
> >>>>>>> http://people.apache.org/~gtully/staging-repos/activemq-5.2.0<http://people.apache.org/%7Egtully/staging-repos/activemq-5.2.0>
> >>>>>>>
> >>>>>>> The Maven generated website for this version is at:
> >>>>>>>
> >>>>>>>               
> >>> http://people.apache.org/~gtully/staging-sites/activemq-5.2.0/maven/5.2.0<http://people.apache.org/%7Egtully/staging-sites/activemq-5.2.0/maven/5.2.0>
> >>>       
> >>>>>>> Source SVN tag:
> >>>>>>> http://svn.apache.org/viewvc/activemq/tags/activemq-5.2.0
> >>>>>>>
> >>>>>>> Please vote to approve this release binary
> >>>>>>>
> >>>>>>> [ ] +1 Release the binary as Apache ActiveMQ 5.2.0
> >>>>>>> [ ] -1 Veto the release (provide specific comments)
> >>>>>>>
> >>>>>>> Here's my +1
> >>>>>>>
> >>>>>>>               
> >>>>>>
> >>>>>>             
> >>>>>           
> >>>       
> >
> >
> >   
> 


Mime
View raw message