Return-Path: Delivered-To: apmail-activemq-dev-archive@www.apache.org Received: (qmail 27726 invoked from network); 22 Sep 2008 19:19:13 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 22 Sep 2008 19:19:13 -0000 Received: (qmail 15818 invoked by uid 500); 22 Sep 2008 19:19:11 -0000 Delivered-To: apmail-activemq-dev-archive@activemq.apache.org Received: (qmail 15634 invoked by uid 500); 22 Sep 2008 19:19:10 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 15623 invoked by uid 99); 22 Sep 2008 19:19:10 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Sep 2008 12:19:10 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Sep 2008 19:18:19 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id A2C24234C1DF for ; Mon, 22 Sep 2008 12:18:52 -0700 (PDT) Message-ID: <1173411281.1222111132665.JavaMail.jira@brutus> Date: Mon, 22 Sep 2008 12:18:52 -0700 (PDT) From: "Rob Davies (JIRA)" To: dev@activemq.apache.org Subject: [jira] Resolved: (AMQ-1943) hasSpace call looks like it may cause messages to be skipped (AMQ-1080 has not been applied for queues) In-Reply-To: <1068358053.1221730192575.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/activemq/browse/AMQ-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Davies resolved AMQ-1943. ----------------------------- Fix Version/s: 5.3.0 Resolution: Fixed Fixed by SVN revision 697953 > hasSpace call looks like it may cause messages to be skipped (AMQ-1080 has not been applied for queues) > ------------------------------------------------------------------------------------------------------- > > Key: AMQ-1943 > URL: https://issues.apache.org/activemq/browse/AMQ-1943 > Project: ActiveMQ > Issue Type: Bug > Components: Message Store > Affects Versions: 5.1.0, 5.2.0 > Reporter: Bastiaan Bakker > Assignee: Rob Davies > Fix For: 5.3.0 > > > SVN revision 560783 modifies only 1 of the 2 DefaultJDBCAdapater.doRecoverNextMessages() methods to break from the loop if the listener.recoverMessage() returns false. The doRecoverNextMessages for queues just logs it at debug level. > Shouldn't that method break from the loop too? I'm seeing the same problems described in AMQ-1080 with the queues on our test and production servers: > 1) lots of ' Stopped recover next messages' messages and CPU usage going way up > 2) messages being skipped -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.