activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rob Davies <rajdav...@gmail.com>
Subject Re: Commit 692174 (AMQ-1900)
Date Tue, 09 Sep 2008 10:30:57 GMT
thx for the catch Mario!

On 9 Sep 2008, at 10:39, Mario Siegenthaler wrote:

> Hi
> When Rob applied the path to AMQ-1900 he made the following change
> (according to fisheye):
> 	 	199	+	                            if  
> (this.getConsumerInfo().isBrowser()) {
> 	 	200	+	
> node 
> .getRegionDestination 
> ().getDestinationStatistics().getDequeues().increment();
> 	 	201	+	                            }
>
> I think this is wrong, the is should be the other way round [if
> (!this.getConsumerInfo().isBrowser())], else we'll only get dequeues
> when browsing.
>
> I suspect this is just a little typo, but it will kill the
> dequeue-stats completely.
>
> --Mario


Mime
View raw message