activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Tully (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AMQ-1796) expired messages not moved to DLQ on trunk (5.2)
Date Thu, 03 Jul 2008 11:29:00 GMT

    [ https://issues.apache.org/activemq/browse/AMQ-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43904#action_43904
] 

Gary Tully commented on AMQ-1796:
---------------------------------

seeing a classcast exception after these changes.
{code}
SEVERE: Failed to page in more queue messages
java.lang.ClassCastException: org.apache.activemq.command.ActiveMQBytesMessage
at org.apache.activemq.broker.region.Queue.messageExpired(Queue.java:1045)
at org.apache.activemq.broker.region.Queue.messageExpired(Queue.java:1037)
at org.apache.activemq.broker.region.Queue.doPageIn(Queue.java:1117)
at org.apache.activemq.broker.region.Queue.pageInMessages(Queue.java:1196)
at org.apache.activemq.broker.region.Queue.iterate(Queue.java:951)
at org.apache.activemq.thread.DeterministicTaskRunner.runTask(DeterministicTaskRunner.java:84)
at org.apache.activemq.thread.DeterministicTaskRunner$1.run(DeterministicTaskRunner.java:41)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:650)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:675)
at java.lang.Thread.run(Thread.java:595)
{code}
fix seems to be:
{code}
Index: src/main/java/org/apache/activemq/broker/region/Queue.java
===================================================================
--- src/main/java/org/apache/activemq/broker/region/Queue.java  (revision 673649)
+++ src/main/java/org/apache/activemq/broker/region/Queue.java  (working copy)
@@ -1114,7 +1114,7 @@
                                 result.add(ref);
                                 count++;
                             } else {
-                                messageExpired(createConnectionContext(), node);
+                                messageExpired(createConnectionContext(), createMessageReference(node.getMessage()));
                             }
                         }
                     } finally {

{code}

> expired messages not moved to DLQ on trunk (5.2)
> ------------------------------------------------
>
>                 Key: AMQ-1796
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1796
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.2.0
>            Reporter: Mario Lukica
>            Assignee: Rob Davies
>             Fix For: 5.2.0
>
>
> Expired messages (transient) are not moved to DLQ on trunk (667098).
> Following tests are failing:
> Running org.apache.activemq.broker.policy.IndividualDeadLetterTest
> Tests run: 4, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 4.172 sec <<<
FAILURE!
> Running org.apache.activemq.broker.policy.MessageListenerDeadLetterTest
> Tests run: 4, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 9.469 sec <<<
FAILURE!
> Running org.apache.activemq.broker.policy.DeadLetterTest
> Tests run: 4, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 4.359 sec <<<
FAILURE!
> Running org.apache.activemq.camel.CamelJmsTest
> Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.203 sec <<<
FAILURE!
> Running org.apache.activemq.broker.policy.IndividualDeadLetterViaXmlTest
> Tests run: 4, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 4.734 sec <<<
FAILURE!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message