activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rob Davies <rajdav...@gmail.com>
Subject Re: Fix for AMQ-765
Date Thu, 17 Apr 2008 09:48:45 GMT
Hi Kai,

the patch looks great - appreciate it!
What you say about the jira process makes sense - but we only check  
open issues  - as it was marked as fixed - we didn't pay attention to  
it.
The convention is to mark an issue as fixed only after its been  
committed to SVN.
I've only update trunk - so that will get into the 5.2 release

cheers,

Rob


On 17 Apr 2008, at 08:30, khudalla wrote:

>
> Since I did not know the particular process of setting the status  
> according
> to the progress in JIRA, I assumed that once someone had created a  
> patch for
> the bug (thereby fixing it) he would (should?) set the status to  
> fixed. Then
> someone (a committer?) could review the changes and then decide  
> whether it
> should go into the repository. Once this happened the status would  
> then be
> set to closed, right?
>
> However, to what branch did you apply the patch? 5.0? 4.1.1? What do  
> you
> think about it? I have created an additional test case checking the
> serialization issue and my patch doesn't break any of the other test  
> cases
> ...
>
> Regards,
> Kai
>
>
> rajdavies wrote:
>>
>> Have applied the patch - looks like the patch wasn't applied but the
>> issue was marked as fixed?
>>
>>
>
> -- 
> View this message in context: http://www.nabble.com/Fix-for-AMQ-765-tp16722536s2354p16740180.html
> Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
>


Mime
View raw message