Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
Received-SPF: pass (athena.apache.org: domain of rajdavies@gmail.com
 designates 72.14.220.155 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:from:to:in-reply-to:content-type:content-transfer-encoding:mime-version:subject:date:references:x-mailer;
        b=wRO1g05fYBbNQrSr568Nszmk29basxvOm936/S/EZZBH9gcmavDM7Qk/QlJHFdRPb0hQVGAW6gS4pIrYiIk4uH++thR3zUkVyGZrEJ2ZSsSlsdd7nS1yUgcSUb49Om4I+YQfIbkxqkJ/A5Wu7z+ulQlBYZowfO02jWJMH5cl2Kg=
Message-Id: <EE4B4B2E-6E9D-481A-801D-110D0D531AFE@gmail.com>
From: Rob Davies <rajdavies@gmail.com>
To: dev@activemq.apache.org
In-Reply-To: <1200968544.20763.79.camel@gmazza-desktop>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v915)
Subject: Re: svn commit: r613230 - in
 /activemq/trunk/activemq-core/src/main/java/org/apache/activemq: advisory/
 broker/region/ broker/region/policy/
Date: Tue, 22 Jan 2008 07:00:07 +0000
References: <20080118191618.8D6E41A9832@eris.apache.org>
 <1200968544.20763.79.camel@gmazza-desktop>


On Jan 22, 2008, at 2:22 AM, Glen Mazza wrote:

> Am Freitag, den 18.01.2008, 19:16 +0000 schrieb rajdavies@apache.org:
>> Author: rajdavies
>> Date: Fri Jan 18 11:16:15 2008
>> New Revision: 613230
>>
>
>> Modified:
>> activemq/trunk/activemq-core/src/main/java/org/apache/activemq/ 
>> broker/region/BaseDestination.java
>> URL:
>> http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/BaseDestination.java?rev=613230&r1=613229&r2=613230&view=diff
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> =====================================================================
>> +    public ActiveMQDestination getActiveMQDestination() {
>> +        return destination;
>> +    }
>> +
>> +    public final String getDestination() {
>> +        return destination.getPhysicalName();
>> +    }
>> +
>
> The method above is the same as getName() below (and also somewhat
> confusing, as it gives the impression it returns a Destination  
> object).
> It should probably be removed.
>
>
>> +    public final String getName() {
>> +        return getActiveMQDestination().getPhysicalName();
>> +    }
>> +
>
> Regards,
> Glen
>
>

Yes - agreed - it is confusing

cheers,

Rob


Rob Davies
'Go further faster with Apache Camel!'
http://rajdavies.blogspot.com/