Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
Received-SPF: pass (athena.apache.org: domain of rajdavies@gmail.com
 designates 209.85.128.187 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:from:to:in-reply-to:content-type:content-transfer-encoding:mime-version:subject:date:references:x-mailer;
        b=PB0ZveMzMBM4G0uHeqVGsvCxQB0qYOLivRbx0nGeGJs1eleZmbVaPl+dEvamYEhi9ZrXkVxdfiG+Auuld6al0u4RYzAPxb8PRMztlZk2uGXvIOuhEysKa99Hzx+UYuTVZh/nzd5PeGdcmigvMze8GNynRSE2dOUecH+vPJ6pMak=
Message-Id: <498B2217-1286-439C-9ED3-32E5D7B08B4F@gmail.com>
From: Rob Davies <rajdavies@gmail.com>
To: dev@activemq.apache.org
In-Reply-To: <1200965883.20763.56.camel@gmazza-desktop>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v915)
Subject: Re: svn commit: r613830 - in
 /activemq/trunk/activemq-core/src/main/java/org/apache/activemq:	broker/jmx/
 broker/region/ broker/region/policy/ command/
Date: Tue, 22 Jan 2008 06:56:20 +0000
References: <20080121103127.0ECE11A9832@eris.apache.org>
 <1200965883.20763.56.camel@gmazza-desktop>


On Jan 22, 2008, at 1:38 AM, Glen Mazza wrote:

> Am Montag, den 21.01.2008, 10:31 +0000 schrieb rajdavies@apache.org:
>> Author: rajdavies
>> Date: Mon Jan 21 02:31:22 2008
>> New Revision: 613830
>>
>> URL: http://svn.apache.org/viewvc?rev=613830&view=rev
>> Log:
>> Fix for https://issues.apache.org/activemq/browse/AMQ-1510
>>
>> Modified:
>> activemq/trunk/activemq-core/src/main/java/org/apache/activemq/ 
>> broker/region/Queue.java
>> URL: http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/Queue.java?rev=613830&r1=613829&r2=613830&view=diff
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> =====================================================================
>> --- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/ 
>> broker/region/Queue.java (original)
>> +++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/ 
>> broker/region/Queue.java Mon Jan 21 02:31:22 2008
>> @@ -150,6 +150,9 @@
>
> Studying Queue.java, I think I see a minor problem with its
> implementation--the business logic under
> "if (r.lock(LockOwner.HIGH_PRIORITY_LOCK_OWNER)) {" on line 680 is
> equivalent to that of "protected void  
> removeMessage(ConnectionContext c,
> IndirectMessageReference r)" on line 922.  I think the code in the
> former can be simply replaced with a call to the latter.
>
> Glen
>
>

Thanks Glen - will change in my next commit


Rob Davies
'Go further faster with Apache Camel!'
http://rajdavies.blogspot.com/