activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Glen Mazza <glen.ma...@verizon.net>
Subject Re: svn commit: r613830 - in /activemq/trunk/activemq-core/src/main/java/org/apache/activemq: broker/jmx/ broker/region/ broker/region/policy/ command/
Date Tue, 22 Jan 2008 01:38:03 GMT
Am Montag, den 21.01.2008, 10:31 +0000 schrieb rajdavies@apache.org:
> Author: rajdavies
> Date: Mon Jan 21 02:31:22 2008
> New Revision: 613830
> 
> URL: http://svn.apache.org/viewvc?rev=613830&view=rev
> Log:
> Fix for https://issues.apache.org/activemq/browse/AMQ-1510
> 
> Modified:
> activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/Queue.java
> URL: http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/Queue.java?rev=613830&r1=613829&r2=613830&view=diff
> ==============================================================================
> --- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/Queue.java
(original)
> +++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/Queue.java
Mon Jan 21 02:31:22 2008
> @@ -150,6 +150,9 @@

Studying Queue.java, I think I see a minor problem with its
implementation--the business logic under 
"if (r.lock(LockOwner.HIGH_PRIORITY_LOCK_OWNER)) {" on line 680 is
equivalent to that of "protected void removeMessage(ConnectionContext c,
IndirectMessageReference r)" on line 922.  I think the code in the
former can be simply replaced with a call to the latter.

Glen



Mime
View raw message