activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Burgel (JIRA)" <j...@apache.org>
Subject [jira] Created: (AMQ-1484) PooledConnection.close() doesn't always close the ActiveMQConnection
Date Thu, 01 Nov 2007 16:18:23 GMT
PooledConnection.close() doesn't always close the ActiveMQConnection
--------------------------------------------------------------------

                 Key: AMQ-1484
                 URL: https://issues.apache.org/activemq/browse/AMQ-1484
             Project: ActiveMQ
          Issue Type: Bug
          Components: Broker
    Affects Versions: 5.0.0
            Reporter: Alex Burgel
            Priority: Minor


using snapshot apache-activemq-5.0-20071028.173739-45

if you call org.apache.activemq.pool.PooledConnection.close(), it calls ConnectionPool.decrementReferenceCount()

this updates the lastUsed time and decrements the ref count, which if its now zero, calls
expiredCheck();

in this case, ConnectionPool.expiredCheck() will only close the connection if hasFailed or
hasExpired is true (it won't close based on idle time because you've just updated lastUsed)

which means that in a lot of cases it won't actually close the connection. if you are shutting
down the JVM, the connection must be closed otherwise there will be a non-daemon thread still
waiting around which will prevent everything from shutting down cleanly.

to fix, i think if ref count is zero, then it should always close().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message