activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Albert Strasheim (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AMQCPP-140) Add SSL transport
Date Sun, 21 Oct 2007 22:36:23 GMT

    [ https://issues.apache.org/activemq/browse/AMQCPP-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40449
] 

Albert Strasheim commented on AMQCPP-140:
-----------------------------------------

Patch looks promising. Might want to think a bit about these warnings when building on Windows
though:

1>..\src\main\activemq\network\SSLSocket.cpp(58) : warning C4244: 'argument' : conversion
from 'activemq::network::Socket::SocketHandle' to 'int', possible loss of data
1>..\src\main\activemq\network\SSLSocket.cpp(95) : warning C4244: 'argument' : conversion
from 'activemq::network::Socket::SocketHandle' to 'int', possible loss of data

The offending lines look like this:

SSL_set_fd( ssl, socketHandle );

On Windows, SocketHandle is a Winsock2 SOCKET, which seems to be a typedef of UINT_PTR, which
I don't think can safely be cast to an int (if it even makes sense to cast it). Can OpenSSL
work with Winsock2 sockets? Maybe there's an alternative function to SSL_set_fd that should
be called in this case?


> Add SSL transport
> -----------------
>
>                 Key: AMQCPP-140
>                 URL: https://issues.apache.org/activemq/browse/AMQCPP-140
>             Project: ActiveMQ C++ Client
>          Issue Type: New Feature
>    Affects Versions: 2.2
>            Reporter: Nathan Mittler
>            Assignee: Nathan Mittler
>             Fix For: 2.2
>
>         Attachments: amqcpp-ssl.patch1
>
>
> Need a secure transport for activemq-cpp.  Some options for ssl support:
> 1) OpenSSL - fairly robust set of ssl functions
> 2) APR - trunk has added support for ssl sockets.  An attractive option, given that we're
already starting to incorporate API in other areas.
> Should create a Java-like set of classes in decaf to add basic ssl support, then use
those classes to make an SSLTransport in activemq-cpp.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message