activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Bish (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AMQCPP-93) Performance analysis
Date Mon, 25 Jun 2007 16:22:34 GMT

    [ https://issues.apache.org/activemq/browse/AMQCPP-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_39515
] 

Timothy Bish commented on AMQCPP-93:
------------------------------------

Without having a lot of time to look at these, here's some comments.

DataOutputStream patch.

The DataOutputStream changes break everything on Solaris, the methods were implemented the
way they were for this reason.  I should have removed Endian so people wouldn't be tempted
to use it, but forgot. 

DataInputStream Patch

The changes violate the contract of the readXXX methods in they they are supposed to throw
an EOFException if the size of the data item being read is not read from the stream, these
change cause it to only ever throw IOException which is incorrect.  Admittedly the documentation
in the header isn't clear on this, I will fix it when I get some time. 



> Performance analysis
> --------------------
>
>                 Key: AMQCPP-93
>                 URL: https://issues.apache.org/activemq/browse/AMQCPP-93
>             Project: ActiveMQ C++ Client
>          Issue Type: Task
>    Affects Versions: 2.0
>            Reporter: Nathan Mittler
>            Assignee: Nathan Mittler
>             Fix For: 2.2
>
>         Attachments: amqcpp-perf1.patch, amqcpp-perf1v2.patch, bench1.cpp, bench2.cpp,
DataInputStream.patch, DataOutputStreamv0.patch, patch Results.xls
>
>
> Do a performance analysis on openwire vs stomp.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message