Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
Message-ID: <10397644.1177451014479.JavaMail.jira@brutus>
Date: Tue, 24 Apr 2007 14:43:34 -0700 (PDT)
From: "Alex Burgel (JIRA)" <jira@apache.org>
To: dev@activemq.apache.org
Subject: [jira] Updated: (AMQ-1235) Scheduler.cancel uses incorrect argument
 to shutdown threads
In-Reply-To: <32605011.1177419814480.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/activemq/browse/AMQ-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Burgel updated AMQ-1235:
-----------------------------

    Attachment: scheduler.patch

here's a patch.

> Scheduler.cancel uses incorrect argument to shutdown threads
> ------------------------------------------------------------
>
>                 Key: AMQ-1235
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1235
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 4.1.1
>            Reporter: Alex Burgel
>            Priority: Critical
>         Attachments: scheduler.patch
>
>
> looking at the code from 4.1.1 in org.apache.activemq.thread.Scheduler, in the cancel method:
> the Runnable task argument is passed to clockDaemon.remove(). i think this is incorrect. ScheduledFuture ticket should be passed to clockDaemon.remove().
> the javadocs of ScheduledThreadPoolExecutor.remove discuss the possibility that Runnables might be stored in some other form internally, so calling remove with a plain Runnable might not do anything. I think the solution is to call remove with a ScheduledFuture, which is how they are stored internally in ScheduledThreadPoolExecutor.
> i came across this bug after upgrading to the java 5 version of backport-util-concurrent 3.0. that version makes more assumptions about the types that are passed into ScheduledThreadPoolExecutor.remove, so when you pass in a regular Runnable you'll get a ClassCastException.
> this is trivial to fix, so i don't think a patch is necessary. also i think this might address the memory leak mentioned in AMQ-1205

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.