activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Bish (JIRA)" <>
Subject [jira] Commented: (AMQCPP-77) Inconsistency when getting string property between Stomp and Openwire
Date Tue, 13 Mar 2007 12:57:34 GMT


Timothy Bish commented on AMQCPP-77:

I think that the proper way to handle missing string properties is to throw the exception.
 This is how all the property getters in OpenWire work now, if they aren't there a NoSuchElementException
is thrown, The stomp getXXXProperty calls should do the same.

> Inconsistency when getting string property between Stomp and Openwire
> ---------------------------------------------------------------------
>                 Key: AMQCPP-77
>                 URL:
>             Project: ActiveMQ C++ Client
>          Issue Type: Bug
>          Components: Openwire
>    Affects Versions: 2.0
>            Reporter: Albert Strasheim
>         Assigned To: Timothy Bish
>             Fix For: 2.0
> In our current code we call getStringProperty on a BytesMessage for a property that might
not exist. When running with Stomp, this returns an empty string. When running with Openwire,
a NoSuchElementException is thrown.
> We could easily change our code to first check whether the property exists with propertyExists
prior to getting it, but Stomp and Openwire should probably handle missing string properties
in the same way.
> I think this default empty string value was added at some point to avoid null pointers
elsewhere in the code. Refer to AMQCPP-43.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message