Return-Path: Delivered-To: apmail-geronimo-activemq-dev-archive@www.apache.org Received: (qmail 81622 invoked from network); 10 Jan 2007 21:23:09 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 10 Jan 2007 21:23:09 -0000 Received: (qmail 14289 invoked by uid 500); 10 Jan 2007 21:23:15 -0000 Delivered-To: apmail-geronimo-activemq-dev-archive@geronimo.apache.org Received: (qmail 14274 invoked by uid 500); 10 Jan 2007 21:23:15 -0000 Mailing-List: contact activemq-dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: activemq-dev@geronimo.apache.org Delivered-To: mailing list activemq-dev@geronimo.apache.org Received: (qmail 14265 invoked by uid 99); 10 Jan 2007 21:23:15 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jan 2007 13:23:15 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jan 2007 13:23:08 -0800 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 266C67142D4 for ; Wed, 10 Jan 2007 13:22:48 -0800 (PST) Message-ID: <31837193.1168464168153.JavaMail.jira@brutus> Date: Wed, 10 Jan 2007 13:22:48 -0800 (PST) From: "Albert Strasheim (JIRA)" To: activemq-dev@geronimo.apache.org Subject: [jira] Commented: (AMQCPP-40) A few stray unix and sun defines In-Reply-To: <31302847.1168440708120.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/activemq/browse/AMQCPP-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_37864 ] Albert Strasheim commented on AMQCPP-40: ---------------------------------------- Which standard specifies "unix" or "__unix__" as something that is defined on all UNIX systems? I'd like to read up on this. Thanks! > A few stray unix and sun defines > -------------------------------- > > Key: AMQCPP-40 > URL: https://issues.apache.org/activemq/browse/AMQCPP-40 > Project: ActiveMQ C++ Client > Issue Type: Improvement > Affects Versions: 2.0 > Reporter: Albert Strasheim > Assigned To: Nathan Mittler > Priority: Minor > Fix For: 2.0 > > > The AMQCPP code still contains a few references to the unix and sun defines. > {noformat} > ./src/main/activemq/concurrent/Mutex.h:#if (defined(__unix__) || defined(unix) || defined(MACOSX)) && !defined(USG) > ./src/main/activemq/concurrent/Thread.h:#if (defined(__unix__) || defined(unix) || defined(MACOSX) || defined(__APPLE__)) && !defined(USG) > ./src/main/activemq/util/Guid.h: #if defined( unix ) || defined(__APPLE__) > ./src/main/activemq/util/Config.h: // used by unix like systems (including cygwin) > ./src/main/activemq/util/Config.h: #elif defined( unix ) > ./src/main/activemq/util/Endian.h:#if defined( unix ) || defined(__APPLE__) > ./src/main/activemq/util/Endian.h:# if defined( unix ) || defined(__APPLE__) > ./src/main/activemq/network/ServerSocket.h: #if !defined( unix ) || defined( __CYGWIN__ ) > ./src/main/activemq/network/SocketOutputStream.cpp:#elif defined( unix ) && !defined( __CYGWIN__ ) && !defined( sun ) > {noformat} > These should probably be replaced by some kind of AMQ_ variant. It would nice if one could define a single AMQ_something per platform, akin to Windows's _WIN32 define. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira