From activemq-dev-return-4364-apmail-geronimo-activemq-dev-archive=geronimo.apache.org@geronimo.apache.org Fri Dec 22 23:26:24 2006 Return-Path: Delivered-To: apmail-geronimo-activemq-dev-archive@www.apache.org Received: (qmail 33678 invoked from network); 22 Dec 2006 23:26:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 22 Dec 2006 23:26:23 -0000 Received: (qmail 7258 invoked by uid 500); 22 Dec 2006 23:26:31 -0000 Delivered-To: apmail-geronimo-activemq-dev-archive@geronimo.apache.org Received: (qmail 7144 invoked by uid 500); 22 Dec 2006 23:26:30 -0000 Mailing-List: contact activemq-dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: activemq-dev@geronimo.apache.org Delivered-To: mailing list activemq-dev@geronimo.apache.org Received: (qmail 7135 invoked by uid 99); 22 Dec 2006 23:26:30 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Dec 2006 15:26:30 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Dec 2006 15:26:22 -0800 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id BA7F471429F for ; Fri, 22 Dec 2006 15:26:02 -0800 (PST) Message-ID: <31134934.1166829962751.JavaMail.root@brutus> Date: Fri, 22 Dec 2006 15:26:02 -0800 (PST) From: "Albert Strasheim (JIRA)" To: activemq-dev@geronimo.apache.org Subject: [jira] Created: (AMQCPP-31) Consider giving the unix #define a more unique name MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Consider giving the unix #define a more unique name --------------------------------------------------- Key: AMQCPP-31 URL: https://issues.apache.org/activemq/browse/AMQCPP-31 Project: ActiveMQ C++ Client Issue Type: Wish Affects Versions: 1.0, 1.1 Reporter: Albert Strasheim Assigned To: Nathan Mittler src\main\activemq\concurrent\Mutex.h and src\main\activemq\concurrent\Thread.cpp check if "unix" is defined to enable UNIX-specific functionality. >From what I've seen in other projects, it's considered a good practice to "scope" your defines, i.e. unix should rather be something like ACTIVEMQ_CPP_UNIX. This virtually eliminates problems when integrating multiple libraries, where defines like "unix" might mean different things to different libraries, meaning the user will have to do some messy preprocessor gymnastics when trying to include headers from multiple libraries in the same file. This also provides an obvious naming convention for other defines. Need, e.g., OpenBSD-specific code? Use ACTIVEMQ_CPP_OPENBSD. On Unix systems, autoconf can probably take care of this kind of thing. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira