activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Bish (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AMQCPP-36) Cleanup whitespace and member function definitions in header files
Date Mon, 25 Dec 2006 18:01:02 GMT
    [ https://issues.apache.org/activemq/browse/AMQCPP-36?page=comments#action_37770 ] 
            
Timothy Bish commented on AMQCPP-36:
------------------------------------

Yes, I do mind.  I prefer to leave small functions in the headers of little classes like this,
if they get inlined by the compiler or not its fine by me.  Simply by nature of C++ the headers
have implementation detail, and for that matter most people shouldn't need to be in that code
as the CMS interfaces define the core functionality that most users of AMQCPP will be using.
 

The question to ask is does the code work, if yes is the answer, then making all these trivial
changes is just pulling time away from implementing the current enhancement under development.
 

> Cleanup whitespace and member function definitions in header files
> ------------------------------------------------------------------
>
>                 Key: AMQCPP-36
>                 URL: https://issues.apache.org/activemq/browse/AMQCPP-36
>             Project: ActiveMQ C++ Client
>          Issue Type: Improvement
>            Reporter: Albert Strasheim
>         Assigned To: Nathan Mittler
>            Priority: Minor
>             Fix For: 1.1
>
>         Attachments: activemq-concurrent-cleanup.diff, StompFrame-signmismatch.diff
>
>
> The AMQCPP code looks great in general, but many files have some stray whitespace. Also,
there are quite a few headers that contain member function definitions. Some are simple, but
there's also some big ones in there. I usually follow the rule that anything that can go into
the .cpp should.
> Attached is a patch to clean up the files in activemq::concurrent. If Timothy/Nathan
agrees that doing this is useful, I'll submit patches for the rest.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message