activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Albert Strasheim (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AMQCPP-36) Cleanup whitespace and member function definitions in header files
Date Mon, 25 Dec 2006 17:03:02 GMT
    [ https://issues.apache.org/activemq/browse/AMQCPP-36?page=comments#action_37769 ] 
            
Albert Strasheim commented on AMQCPP-36:
----------------------------------------

> I don't follow this rule.

Do you mind if the patches move member functions to .cpp files? As I see it, headers shouldn't
include implementation details.

> One person's extra whitespace is another persons useful code separation.

What I meant by stray whitespace is that there are lines that have 3 or 4 spaces at the end
where they serve no purpose. It's the kind of whitespace that Eclipse's "Remove trailing whitespace"
removes and the kind that Checkstyle warns you about.

I'll update the Linux build files in a new patch.

Meanwhile, here's a signedness fix from StompFrame.h.

> Cleanup whitespace and member function definitions in header files
> ------------------------------------------------------------------
>
>                 Key: AMQCPP-36
>                 URL: https://issues.apache.org/activemq/browse/AMQCPP-36
>             Project: ActiveMQ C++ Client
>          Issue Type: Improvement
>            Reporter: Albert Strasheim
>         Assigned To: Nathan Mittler
>            Priority: Minor
>             Fix For: 1.1
>
>         Attachments: activemq-concurrent-cleanup.diff
>
>
> The AMQCPP code looks great in general, but many files have some stray whitespace. Also,
there are quite a few headers that contain member function definitions. Some are simple, but
there's also some big ones in there. I usually follow the rule that anything that can go into
the .cpp should.
> Attached is a patch to clean up the files in activemq::concurrent. If Timothy/Nathan
agrees that doing this is useful, I'll submit patches for the rest.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message