activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Bish (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AMQCPP-36) Cleanup whitespace and member function definitions in header files
Date Mon, 25 Dec 2006 16:31:02 GMT
    [ https://issues.apache.org/activemq/browse/AMQCPP-36?page=comments#action_37768 ] 
            
Timothy Bish commented on AMQCPP-36:
------------------------------------

> I usually follow the rule that anything that can go into the .cpp should.

I don't follow this rule.

> but many files have some stray whitespace

One person's extra whitespace is another persons useful code separation.


Also patches submitted that add new files shouldn't only update the windows projects, the
makefiles would also need to be updated as well, so you need to update them as well or provide
a source listing of what you added so we can more easily apply the patches.

> Cleanup whitespace and member function definitions in header files
> ------------------------------------------------------------------
>
>                 Key: AMQCPP-36
>                 URL: https://issues.apache.org/activemq/browse/AMQCPP-36
>             Project: ActiveMQ C++ Client
>          Issue Type: Improvement
>            Reporter: Albert Strasheim
>         Assigned To: Nathan Mittler
>            Priority: Minor
>             Fix For: 1.1
>
>         Attachments: activemq-concurrent-cleanup.diff
>
>
> The AMQCPP code looks great in general, but many files have some stray whitespace. Also,
there are quite a few headers that contain member function definitions. Some are simple, but
there's also some big ones in there. I usually follow the rule that anything that can go into
the .cpp should.
> Attached is a patch to clean up the files in activemq::concurrent. If Timothy/Nathan
agrees that doing this is useful, I'll submit patches for the rest.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message