Mailing-List: contact activemq-dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: activemq-dev@geronimo.apache.org
Received-SPF: pass (asf.osuosl.org: domain of james.strachan@gmail.com
 designates 66.249.92.173 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition;
        b=lONGndYnhgnbnZngUQTejmFz1yREBm8rfcHR6WwHr/sWS2fGC5HUOwvChUu4rmD42lHTVkc/+7Q0bw1kIpFwWumGlGVxmqehiT8tS+tMpW9TuIn4TsDdPQvvgeDhZGxSzkFbH9QwvBpghxtFprucC2M4YA58RWtkRdX9hbZO7+c=
Message-ID: <ec6e67fd0607210133t287e5fd3he6a0f41764614e78@mail.gmail.com>
Date: Fri, 21 Jul 2006 09:33:23 +0100
From: "James Strachan" <james.strachan@gmail.com>
To: activemq-dev@geronimo.apache.org
Subject: anyone any idea why RegionBroker.removeConnection() works as it does?
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

in http://rafb.net/paste/results/h7qOVA70.html there's

            // we may be removing the duplicate connection, not the
first connection to be created
            if (oldValue == info) {

I'm just wondering about the == operator here.  I guess the issue is
that a duplicate tries to add a connection, gets a failure then tries
to remove itself and we want to guard against the original connection
being removed right?

Am wondering if it might be better to check for equal connectionId's
instead as I could see cases where oldValue != info but they are the
same connection?

This line of code could mybe be the cause of some duplicate clientID
exceptions some folks have experienced from time to time.

-- 

James
-------
http://radio.weblogs.com/0112098/