activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Bish (JIRA)" <j...@apache.org>
Subject [jira] Updated: (AMQ-823) Incorect handling of message size in ByteArrayOutputStream::write
Date Tue, 25 Jul 2006 17:16:23 GMT
     [ https://issues.apache.org/activemq/browse/AMQ-823?page=all ]

Timothy Bish updated AMQ-823:
-----------------------------

    Attachment: patch.txt

This implements the suggested fix.  The code was incorrect, the offset value is a zero based
index, and when compared against the length, when it is equal to length the buffer needs to
be increased.  The current code would step one past the array size.

> Incorect handling of message size in ByteArrayOutputStream::write
> -----------------------------------------------------------------
>
>                 Key: AMQ-823
>                 URL: https://issues.apache.org/activemq/browse/AMQ-823
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: CMS (C++ client)
>    Affects Versions: incubation
>         Environment: RHEL 4/32bit 
>            Reporter: Radek Sedmak
>         Assigned To: Nathan Mittler
>         Attachments: patch.txt
>
>   Original Estimate: 10 minutes
>  Remaining Estimate: 10 minutes
>
> when you are sending message via openwire protocol, ByteArrayOutputStream::write is called
in certain moment ...
> when message size is greater then defaul CHUNK space is reallocated and there is "check
for EOF offset".
>   
>    if( offset > bodySize )
>             expandBody() ;
>  but should be there 
>   if ( offset >= bodySize ) 
>             expandBody();

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message