From activemq-dev-return-877-apmail-geronimo-activemq-dev-archive=geronimo.apache.org@geronimo.apache.org Thu Apr 27 04:40:02 2006 Return-Path: Delivered-To: apmail-geronimo-activemq-dev-archive@www.apache.org Received: (qmail 36260 invoked from network); 27 Apr 2006 04:40:02 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 27 Apr 2006 04:40:02 -0000 Received: (qmail 83351 invoked by uid 500); 27 Apr 2006 04:40:01 -0000 Delivered-To: apmail-geronimo-activemq-dev-archive@geronimo.apache.org Received: (qmail 83322 invoked by uid 500); 27 Apr 2006 04:40:01 -0000 Mailing-List: contact activemq-dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: activemq-dev@geronimo.apache.org Delivered-To: mailing list activemq-dev@geronimo.apache.org Received: (qmail 83313 invoked by uid 99); 27 Apr 2006 04:40:01 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Apr 2006 21:40:01 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [72.10.46.63] (HELO as.toolazydogs.com) (72.10.46.63) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Apr 2006 21:40:00 -0700 Received: (qmail 19816 invoked from network); 26 Apr 2006 21:39:39 -0700 Received: from unknown (HELO ?192.168.241.141?) (203.177.56.98) by toolazydogs.com with (DHE-RSA-AES256-SHA encrypted) SMTP; 26 Apr 2006 21:39:39 -0700 Message-ID: <44504AF9.4050506@toolazydogs.com> Date: Thu, 27 Apr 2006 12:39:21 +0800 From: "Alan D. Cabrera" User-Agent: Thunderbird 1.5.0.2 (Macintosh/20060308) MIME-Version: 1.0 To: activemq-dev@geronimo.apache.org Subject: Re: MulticastSocketSyncChannelFactory should implement SyncChannelFactory? References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Oi. I simply copied it from another factory but I cannot find it now. I'll fix this. Regards, Alan Bill Dudney wrote: > Hi All, > > I'm playing around with activeio and I found that > MulticastSocketSyncChannelFactory does not implement > SyncChannelFactory. It should right? > > Figured this little patch was not worth a JIRA, be glad to file one if > you'd prefer. > > in case the license grant is important I grant you full rights to do > whatever you wish with this code > > TTFN, > > Bill Dudney > MyFaces - http://myfaces.apache.org > Cayenne - http://incubator.apache.org/projects/cayenne.html > > > Index: > /Users/bdudney/Development/activemq/activeio/activeio-core/src/main/java/org/apache/activeio/packet/sync/multicast/MulticastSocketSyncChannelFactory.java > > =================================================================== > --- > /Users/bdudney/Development/activemq/activeio/activeio-core/src/main/java/org/apache/activeio/packet/sync/multicast/MulticastSocketSyncChannelFactory.java > (revision 397379) > +++ > /Users/bdudney/Development/activemq/activeio/activeio-core/src/main/java/org/apache/activeio/packet/sync/multicast/MulticastSocketSyncChannelFactory.java > (working copy) > @@ -22,13 +22,14 @@ > import java.net.URI; > import org.apache.activeio.packet.sync.SyncChannel; > +import org.apache.activeio.packet.sync.SyncChannelFactory; > import org.apache.activeio.packet.sync.SyncChannelServer; > /** > * @version $Revision: $ $Date: $ > */ > -public class MulticastSocketSyncChannelFactory { > +public class MulticastSocketSyncChannelFactory implements > SyncChannelFactory { > public SyncChannel openSyncChannel(URI groupURI) throws > IOException { > if (groupURI == null) throw new > IllegalArgumentException("group URI cannot be null"); >