Return-Path: 
 <activemq-dev-return-35-apmail-geronimo-activemq-dev-archive=geronimo.apache.org@geronimo.apache.org>
Delivered-To: apmail-geronimo-activemq-dev-archive@www.apache.org
Received: (qmail 73334 invoked from network); 22 Dec 2005 15:17:49 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 22 Dec 2005 15:17:49 -0000
Received: (qmail 77250 invoked by uid 500); 22 Dec 2005 15:17:49 -0000
Delivered-To: apmail-geronimo-activemq-dev-archive@geronimo.apache.org
Received: (qmail 77228 invoked by uid 500); 22 Dec 2005 15:17:49 -0000
Mailing-List: contact activemq-dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:activemq-dev-help@geronimo.apache.org>
List-Unsubscribe: <mailto:activemq-dev-unsubscribe@geronimo.apache.org>
List-Post: <mailto:activemq-dev@geronimo.apache.org>
List-Id: <activemq-dev.geronimo.apache.org>
Reply-To: activemq-dev@geronimo.apache.org
Delivered-To: mailing list activemq-dev@geronimo.apache.org
Received: (qmail 77219 invoked by uid 99); 22 Dec 2005 15:17:48 -0000
Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Dec 2005 07:17:48 -0800
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received-SPF: neutral (asf.osuosl.org: local policy)
Received: from [66.116.97.229] (HELO mail.dudney.net) (66.116.97.229)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Dec 2005 07:17:48 -0800
Received: from localhost (localhost [127.0.0.1])
	by mail.dudney.net (Postfix) with ESMTP id B208611D3DA
	for <activemq-dev@geronimo.apache.org>; Thu, 22 Dec 2005 08:17:25 -0700 (MST)
Received: from mail.dudney.net ([127.0.0.1])
 by localhost (mini.dudney.net [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 25236-09 for <activemq-dev@geronimo.apache.org>;
 Thu, 22 Dec 2005 08:17:19 -0700 (MST)
Received: from [192.168.2.214] (71-211-141-201.hlrn.qwest.net
 [71.211.141.201])
	by mail.dudney.net (Postfix) with ESMTP id 6D2F311D3C0
	for <activemq-dev@geronimo.apache.org>; Thu, 22 Dec 2005 08:17:19 -0700 (MST)
Mime-Version: 1.0 (Apple Message framework v746.2)
Content-Transfer-Encoding: 7bit
Message-Id: <EF1EB750-B06A-4BB4-81A6-FF6500B69826@apache.org>
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
To: activemq-dev@geronimo.apache.org
From: Bill Dudney <bdudney@apache.org>
Subject: generated source added to repo?
Date: Thu, 22 Dec 2005 08:17:16 -0700
X-Mailer: Apple Mail (2.746.2)
X-Virus-Scanned: by amavisd-new at dudney.net
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

Hi All,

While trying to get the latest updates to build with maven 2 I was  
getting compile errors complaining about duplicate class errors.

I believe that problem lies first in a bug in the configuration of  
the javacc plugin (in activemq-core/pom.xml) and second that the  
generated files have been added to SVN.

After a clean checkout and mvn package from the activemq-core  
directory the following two files are modified;

M      src/main/java/org/activemq/selector/ 
SelectorParserTokenManager.java
M      src/main/java/org/activemq/selector/SelectorParser.java

The javacc plugin is being told to write the source code into the src/ 
main directory instead of somewhere in 'target'. The other 4 files  
are not regenerated (javacc is logging that they already exist, not  
sure why it regenerates these two every time).

If the entire src/main/java/org/activemq/selector directory is  
deleted and the <outputDirectory> element is commented out from the  
pom then the parser is still generated but in the target directory.

I'd be glad to generate another patch for the m2 build stuff but I  
want to proceed with how you all want it to look. Here are a couple  
of possible solutions

1) exclude the src/main/java/org/activemq/selector directory from svn  
with svn:ignore and continue to generate code into that directory  
(not the maven way but it works)
2) patch the pom and remove the outputDirectory element, have the src  
generated into the target directory (more the maven way) - if we do  
this the selector directory should be deleted from svn because it  
causes duplicate class compile errors.

There is also a small problem with the <sourceDirectory> element. It  
works fine when the build is run from the activemq-core directory but  
does not work from the top level build (i.e. in the activemq  
directory). To fix that we need to add ${basedir} to the element like

               <sourceDirectory>${basedir}/src/main/grammar</ 
sourceDirectory>

An alternative to making this change is to move the grammar directory  
to javacc (i.e. src/main/grammar => src/main/javacc) and delete the  
sourceDirectory element. This move would fall more in line with the  
maven 2 way but would require changes to the maven 1 build bits.  
Don't you love having choices :-)

TTFN,

Bill Dudney
MyFaces - myfaces.apache.org
Wadi - incubator.apache.org/wadi