Return-Path: Delivered-To: apmail-geronimo-activemq-dev-archive@www.apache.org Received: (qmail 21507 invoked from network); 22 Dec 2005 16:36:15 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 22 Dec 2005 16:36:15 -0000 Received: (qmail 38572 invoked by uid 500); 22 Dec 2005 16:36:14 -0000 Delivered-To: apmail-geronimo-activemq-dev-archive@geronimo.apache.org Received: (qmail 38550 invoked by uid 500); 22 Dec 2005 16:36:14 -0000 Mailing-List: contact activemq-dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: activemq-dev@geronimo.apache.org Delivered-To: mailing list activemq-dev@geronimo.apache.org Received: (qmail 38541 invoked by uid 99); 22 Dec 2005 16:36:14 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Dec 2005 08:36:14 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: local policy) Received: from [66.116.97.229] (HELO mail.dudney.net) (66.116.97.229) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Dec 2005 08:36:13 -0800 Received: from localhost (localhost [127.0.0.1]) by mail.dudney.net (Postfix) with ESMTP id 7D79C11D51A for ; Thu, 22 Dec 2005 09:35:51 -0700 (MST) Received: from mail.dudney.net ([127.0.0.1]) by localhost (mini.dudney.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 27626-04 for ; Thu, 22 Dec 2005 09:35:47 -0700 (MST) Received: from [192.168.2.214] (71-211-141-201.hlrn.qwest.net [71.211.141.201]) by mail.dudney.net (Postfix) with ESMTP id DE39D11D500 for ; Thu, 22 Dec 2005 09:35:42 -0700 (MST) Mime-Version: 1.0 (Apple Message framework v746.2) In-Reply-To: References:

Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Bill Dudney Subject: Re: generated source added to repo? Date: Thu, 22 Dec 2005 09:35:40 -0700 To: activemq-dev@geronimo.apache.org X-Mailer: Apple Mail (2.746.2) X-Virus-Scanned: by amavisd-new at dudney.net X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Hey Hiram, >> >> M src/main/java/org/activemq/selector/ >> SelectorParserTokenManager.java >> M src/main/java/org/activemq/selector/SelectorParser.java >> > > Seems that the javacc version used in m1 and m2 are different and > they generate different parsers. Once we check in the changed > source files, svn should not mark these as being changed anymore. > makes sense - you should be able to run mvn install and get this change and can then check it in, or I'd be happy to post a patch. >> >> 1) exclude the src/main/java/org/activemq/selector directory from >> svn with svn:ignore and continue to generate code into that >> directory (not the maven way but it works) >> 2) patch the pom and remove the outputDirectory element, have the >> src generated into the target directory (more the maven way) - if >> we do this the selector directory should be deleted from svn >> because it causes duplicate class compile errors. >> >> There is also a small problem with the element. >> It works fine when the build is run from the activemq-core >> directory but does not work from the top level build (i.e. in the >> activemq directory). To fix that we need to add ${basedir} to the >> element like >> >> ${basedir}/src/main/grammar> sourceDirectory> >> > > I think this is the easy and simple way to do it for now. Once > totally move off m1, re can revisit this. > cool, do you want a patch for that? TTFN, Bill Dudney MyFaces - myfaces.apache.org Wadi - incubator.apache.org/wadi