activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adrian Co <...@exist.com>
Subject Re: [patch] $ACTIVEMQ_OPTS ignored in "activemq" startup script
Date Thu, 22 Dec 2005 02:31:14 GMT
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
  <meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
  <title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
Hi Brad,<br>
<br>
I have committed your fixed. Thanks for the heads up!<br>
<br>
Much appreciated. <span class="moz-smiley-s1"><span> :-) </span></span><br>
<br>
Regards,<br>
Adrian<br>
<br>
Brad Fritz wrote:
<blockquote cite="mid20051221233111.GA24226@localhost.localdomain"
 type="cite">
  <pre wrap="">I tried to submit this as a JIRA issue but wasn't able to login after
creating an account and receiving a confirmation.  :-/

Anyhow, there are two typos in assembly/src/release/bin/activemq that
prevent the default value for $ACTIVEMQ_OPTS from being overridden.

Th trivial patch attached adds the missing dollar sign and changes
"-n" (test for non-zero length) to "-z" (test for zero length) so that
$ACTIVEMQ_OPTS gets set to the default only if it's not already set.
Patch is against SVN trunk.

--Brad

  </pre>
  <pre wrap="">
<hr size="4" width="90%">
Index: assembly/src/release/bin/activemq
===================================================================
--- assembly/src/release/bin/activemq	(revision 358408)
+++ assembly/src/release/bin/activemq	(working copy)
@@ -114,7 +114,7 @@
 fi
 
 
-if [ -n "ACTIVEMQ_OPTS" ] ; then
+if [ -z "$ACTIVEMQ_OPTS" ] ; then
   ACTIVEMQ_OPTS="-Xmx512M -Dderby.system.home=../data -Dderby.storage.fileSyncTransactionLog=true"
 fi
 
  </pre>
</blockquote>
<br>
</body>
</html>

Mime
View raw message