activemq-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuco...@apache.org
Subject [activemq-artemis] 01/03: NO-JIRA no need to validate default return
Date Tue, 30 Jul 2019 22:05:04 GMT
This is an automated email from the ASF dual-hosted git repository.

clebertsuconic pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git

commit 32a15284cafe8c63f09e8c4febd53304d098e96b
Author: Clebert Suconic <clebertsuconic@apache.org>
AuthorDate: Wed Jul 24 15:36:09 2019 -0400

    NO-JIRA no need to validate default return
---
 .../org/apache/activemq/artemis/utils/XMLConfigurationUtil.java    | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/utils/XMLConfigurationUtil.java
b/artemis-server/src/main/java/org/apache/activemq/artemis/utils/XMLConfigurationUtil.java
index 29cfef9..906fd81 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/utils/XMLConfigurationUtil.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/utils/XMLConfigurationUtil.java
@@ -44,7 +44,6 @@ public class XMLConfigurationUtil {
          validator.validate(name, val);
          return val;
       } else {
-         validator.validate(name, def);
          return def;
       }
    }
@@ -59,7 +58,6 @@ public class XMLConfigurationUtil {
          validator.validate(name, val);
          return val;
       } else {
-         validator.validate(name, def);
          return def;
       }
    }
@@ -74,7 +72,6 @@ public class XMLConfigurationUtil {
          validator.validate(name, val);
          return val;
       } else {
-         validator.validate(name, def);
          return def;
       }
    }
@@ -89,14 +86,13 @@ public class XMLConfigurationUtil {
          validator.validate(name, val);
          return val;
       } else {
-         validator.validate(name, def);
          return def;
       }
    }
 
    public static final Integer getInteger(final Element e,
                                           final String name,
-                                          final int def,
+                                          final Integer def,
                                           final Validators.Validator validator) {
       NodeList nl = e.getElementsByTagName(name);
       if (nl.getLength() > 0) {
@@ -104,7 +100,6 @@ public class XMLConfigurationUtil {
          validator.validate(name, val);
          return val;
       } else {
-         validator.validate(name, def);
          return def;
       }
    }


Mime
View raw message