activemq-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuco...@apache.org
Subject [activemq-artemis] branch 2.6.x updated: ARTEMIS-1058 Improving web temporary cleanup
Date Wed, 06 Feb 2019 15:01:59 GMT
This is an automated email from the ASF dual-hosted git repository.

clebertsuconic pushed a commit to branch 2.6.x
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git


The following commit(s) were added to refs/heads/2.6.x by this push:
     new 3ee6699  ARTEMIS-1058 Improving web temporary cleanup
3ee6699 is described below

commit 3ee6699a0ea576975b78f0248fe061d26296805b
Author: Clebert Suconic <clebertsuconic@apache.org>
AuthorDate: Mon Feb 4 10:20:01 2019 -0500

    ARTEMIS-1058 Improving web temporary cleanup
    
    * Using SpawnedVMSupport (used to be on testsuite, moving it to Utils)
    * Building the classpath for ./lib, similar to what happens on Bootstrap
    * Using Path as much as possible to avoid issues encoding files
    
    (cherry picked from commit 59ada6603354f766dc627a83813af8fd69bab1fd)
---
 .../activemq/artemis/utils}/SpawnedVMSupport.java  | 114 ++++++++++++---------
 .../artemis/component/WebServerComponent.java      |  54 ++++------
 .../activemq/artemis/component}/WebTmpCleaner.java |  30 ++++--
 .../apache/activemq/cli/test/WebServerCLITest.java |   0
 .../integration/amqp/AmqpNoHearbeatsTest.java      |   2 +-
 .../client/IncompatibleVersionTest.java            |   2 +-
 .../tests/integration/client/JournalCrashTest.java |   2 +-
 .../tests/integration/client/SendAckFailTest.java  |   2 +-
 .../integration/clientcrash/ClientCrashTest.java   |   2 +-
 .../integration/clientcrash/ClientExitTest.java    |   2 +-
 .../clientcrash/PendingDeliveriesTest.java         |   2 +-
 .../integration/cluster/RealNodeManagerTest.java   |   2 +-
 .../failover/LiveCrashOnBackupSyncTest.java        |   0
 .../integration/critical/CriticalCrashTest.java    |   2 +-
 .../integration/journal/CrashOnCompactTest.java    |   2 +-
 .../journal/ValidateTransactionHealthTest.java     |   2 +-
 .../integration/paging/PageCountSyncServer.java    |   2 +-
 .../paging/PagingWithFailoverBackup.java           |   2 +-
 .../paging/PagingWithFailoverServer.java           |   2 +-
 .../security/NettySecurityClientTest.java          |   2 +-
 .../activemq/artemis/common/AbstractAdmin.java     |   2 +-
 .../unit/core/util/RandomUtilDistributionTest.java |   2 +-
 .../artemis/tests/util/SpawnedVMCheck.java         |   1 +
 23 files changed, 127 insertions(+), 106 deletions(-)

diff --git a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/util/SpawnedVMSupport.java
b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/SpawnedVMSupport.java
similarity index 81%
rename from tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/util/SpawnedVMSupport.java
rename to artemis-commons/src/main/java/org/apache/activemq/artemis/utils/SpawnedVMSupport.java
index 544b04f..64ead66 100644
--- a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/util/SpawnedVMSupport.java
+++ b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/SpawnedVMSupport.java
@@ -14,35 +14,26 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package org.apache.activemq.artemis.tests.util;
+package org.apache.activemq.artemis.utils;
 
 import java.io.BufferedReader;
+import java.io.File;
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.InputStreamReader;
 import java.nio.file.Paths;
 import java.util.HashSet;
 import java.util.List;
-import java.util.concurrent.Callable;
 import java.util.concurrent.ConcurrentHashMap;
-import java.util.concurrent.ExecutionException;
-import java.util.concurrent.Executors;
-import java.util.concurrent.Future;
-import java.util.concurrent.ScheduledExecutorService;
 import java.util.concurrent.TimeUnit;
-import java.util.concurrent.TimeoutException;
 
-import org.apache.activemq.artemis.tests.unit.UnitTestLogger;
-import org.apache.activemq.artemis.utils.ActiveMQThreadFactory;
-import org.junit.Assert;
+import org.jboss.logging.Logger;
 
-import static java.util.concurrent.TimeUnit.SECONDS;
-
-public final class SpawnedVMSupport {
+public class SpawnedVMSupport {
 
    static ConcurrentHashMap<Process, String> startedProcesses = new ConcurrentHashMap();
 
-   private static final UnitTestLogger log = UnitTestLogger.LOGGER;
+   private static final Logger log = Logger.getLogger(SpawnedVMSupport.class);
 
    public static Process spawnVM(final String className, final String... args) throws Exception
{
       return SpawnedVMSupport.spawnVM(className, new String[0], true, args);
@@ -53,6 +44,12 @@ public final class SpawnedVMSupport {
                                  final String... args) throws Exception {
       return SpawnedVMSupport.spawnVM(className, new String[0], logOutput, args);
    }
+   public static Process spawnVM(final String classPath,
+                                 final String className,
+                                 final boolean logOutput,
+                                 final String... args) throws Exception {
+      return SpawnedVMSupport.spawnVM(classPath, className, new String[0], logOutput, args);
+   }
 
    public static Process spawnVM(final String className, final String[] vmargs, final String...
args) throws Exception {
       return SpawnedVMSupport.spawnVM(className, vmargs, true, args);
@@ -65,6 +62,14 @@ public final class SpawnedVMSupport {
       return SpawnedVMSupport.spawnVM(className, "-Xms512m", "-Xmx512m", vmargs, logOutput,
true, true, args);
    }
 
+   public static Process spawnVM(final String classpath,
+                                 final String className,
+                                 final String[] vmargs,
+                                 final boolean logOutput,
+                                 final String... args) throws Exception {
+      return SpawnedVMSupport.spawnVM(classpath, className, "-Xms512m", "-Xmx512m", vmargs,
logOutput, true, true, args);
+   }
+
    public static Process spawnVMWithLogMacher(String wordMatch,
                                               Runnable runnable,
                                               final String className,
@@ -85,6 +90,18 @@ public final class SpawnedVMSupport {
       return spawnVM(null, null, className, memoryArg1, memoryArg2, vmargs, logOutput, logErrorOutput,
useLogging, args);
    }
 
+   public static Process spawnVM(final String classPath,
+                                 final String className,
+                                 final String memoryArg1,
+                                 final String memoryArg2,
+                                 final String[] vmargs,
+                                 final boolean logOutput,
+                                 final boolean logErrorOutput,
+                                 final boolean useLogging,
+                                 final String... args) throws Exception {
+      return spawnVM(classPath, null, null, className, memoryArg1, memoryArg2, vmargs, logOutput,
logErrorOutput, useLogging, args);
+   }
+
    public static Process spawnVM(final String wordMatch,
                                  final Runnable wordRunning,
                                  final String className,
@@ -95,7 +112,7 @@ public final class SpawnedVMSupport {
                                  final boolean logErrorOutput,
                                  final boolean useLogging,
                                  final String... args) throws Exception {
-      return spawnVM(System.getProperty("java.class.path"), wordMatch, wordRunning, className,
memoryArg1, memoryArg2, vmargs, logOutput, logErrorOutput, useLogging, args);
+      return spawnVM(getClassPath(), wordMatch, wordRunning, className, memoryArg1, memoryArg2,
vmargs, logOutput, logErrorOutput, useLogging, args);
 
    }
 
@@ -113,6 +130,30 @@ public final class SpawnedVMSupport {
       return spawnVM(classPath, wordMatch, wordRunning, className, memoryArg1, memoryArg2,
vmargs, logOutput, logErrorOutput, useLogging, -1, args);
    }
 
+   public static String getClassPath() {
+      return System.getProperty("java.class.path");
+   }
+
+   public static String getClassPath(File libfolder) {
+      if (libfolder == null) {
+         return getClassPath();
+      }
+
+      StringBuilder stringBuilder = new StringBuilder();
+      boolean empty = true;
+      for (File f : libfolder.listFiles()) {
+         if (f.getName().endsWith(".jar") || f.getName().endsWith(".zip")) {
+            if (!empty) {
+               stringBuilder.append(File.pathSeparator);
+            }
+            empty = false;
+            stringBuilder.append(f.toString());
+         }
+      }
+
+      return stringBuilder.toString();
+   }
+
    /**
     * @param classPath
     * @param wordMatch
@@ -251,7 +292,14 @@ public final class SpawnedVMSupport {
 
    }
 
-   public static void checkProcess() {
+   public static void enableCheck() {
+      startedProcesses = new ConcurrentHashMap<>();
+   }
+
+   /**
+    * Check if all spawned processes are finished.
+    */
+   public static boolean checkProcess() {
 
       HashSet<Process> aliveProcess = getAliveProcesses();
 
@@ -262,11 +310,13 @@ public final class SpawnedVMSupport {
                alive.destroyForcibly();
                buffer.append(startedProcesses.get(alive) + " ");
             }
-            Assert.fail("There are " + aliveProcess.size() + " processes alive :: " + buffer.toString());
+            return false;
          }
       } finally {
          startedProcesses.clear();
       }
+
+      return true;
    }
 
    /**
@@ -293,36 +343,6 @@ public final class SpawnedVMSupport {
    }
 
    /**
-    * Assert that a process exits with the expected value (or not depending if
-    * the <code>sameValue</code> is expected or not). The method waits 5
-    * seconds for the process to exit, then an Exception is thrown. In any case,
-    * the process is destroyed before the method returns.
-    */
-   public static void assertProcessExits(final boolean sameValue,
-                                         final int value,
-                                         final Process p) throws InterruptedException, ExecutionException,
TimeoutException {
-      ScheduledExecutorService executor = Executors.newSingleThreadScheduledExecutor(ActiveMQThreadFactory.defaultThreadFactory());
-      Future<Integer> future = executor.submit(new Callable<Integer>() {
-
-         @Override
-         public Integer call() throws Exception {
-            p.waitFor();
-            return p.exitValue();
-         }
-      });
-      try {
-         int exitValue = future.get(10, SECONDS);
-         if (sameValue) {
-            Assert.assertSame(value, exitValue);
-         } else {
-            Assert.assertNotSame(value, exitValue);
-         }
-      } finally {
-         p.destroy();
-      }
-   }
-
-   /**
     * Redirect the input stream to a logger (as debug logs)
     */
    static class ProcessLogger extends Thread {
diff --git a/artemis-web/src/main/java/org/apache/activemq/artemis/component/WebServerComponent.java
b/artemis-web/src/main/java/org/apache/activemq/artemis/component/WebServerComponent.java
index a78d866..fcdabfd 100644
--- a/artemis-web/src/main/java/org/apache/activemq/artemis/component/WebServerComponent.java
+++ b/artemis-web/src/main/java/org/apache/activemq/artemis/component/WebServerComponent.java
@@ -29,7 +29,6 @@ import org.apache.activemq.artemis.components.ExternalComponent;
 import org.apache.activemq.artemis.dto.AppDTO;
 import org.apache.activemq.artemis.dto.ComponentDTO;
 import org.apache.activemq.artemis.dto.WebServerDTO;
-import org.apache.activemq.artemis.utils.FileUtil;
 import org.eclipse.jetty.server.ConnectionFactory;
 import org.eclipse.jetty.server.Connector;
 import org.eclipse.jetty.server.HttpConfiguration;
@@ -57,12 +56,11 @@ public class WebServerComponent implements ExternalComponent {
    private String consoleUrl;
    private List<WebAppContext> webContexts;
    private ServerConnector connector;
-   private String artemisHome;
+   private Path artemisHomePath;
 
    @Override
    public void configure(ComponentDTO config, String artemisInstance, String artemisHome)
throws Exception {
       webServerConfig = (WebServerDTO) config;
-      this.artemisHome = artemisHome;
       uri = new URI(webServerConfig.bind);
       server = new Server();
       String scheme = uri.getScheme();
@@ -101,7 +99,8 @@ public class WebServerComponent implements ExternalComponent {
 
       handlers = new HandlerList();
 
-      Path homeWarDir = Paths.get(artemisHome != null ? artemisHome : ".").resolve(webServerConfig.path).toAbsolutePath();
+      this.artemisHomePath = Paths.get(artemisHome != null ? artemisHome : ".");
+      Path homeWarDir = artemisHomePath.resolve(webServerConfig.path).toAbsolutePath();
       Path instanceWarDir = Paths.get(artemisInstance != null ? artemisInstance : ".").resolve(webServerConfig.path).toAbsolutePath();
 
       if (webServerConfig.apps != null && webServerConfig.apps.size() > 0) {
@@ -165,41 +164,30 @@ public class WebServerComponent implements ExternalComponent {
    }
 
    public void internalStop() throws Exception {
+      System.out.println("Stopping");
       server.stop();
       if (webContexts != null) {
+         cleanupWebTemporaryFiles(webContexts);
 
-         File tmpdir = null;
-         StringBuilder strBuilder = new StringBuilder();
-         boolean found = false;
-         for (WebAppContext context : webContexts) {
-            tmpdir = context.getTempDirectory();
-
-            if (tmpdir != null && tmpdir.exists() && !context.isPersistTempDirectory())
{
-               //tmpdir will be removed by deleteOnExit()
-               //However because the URLClassLoader never release/close its opened
-               //jars the jar file won't be able to get deleted on Windows platform
-               //until after the process fully terminated. To fix this here arranges
-               //a separate process to try clean up the temp dir
-               FileUtil.deleteDirectory(tmpdir);
-               if (tmpdir.exists()) {
-                  ActiveMQWebLogger.LOGGER.tmpFileNotDeleted(tmpdir);
-                  strBuilder.append(tmpdir);
-                  strBuilder.append(",");
-                  found = true;
-               }
-            }
-         }
-
-         if (found) {
-            String bootJar = artemisHome + File.separator + "lib" + File.separator + "artemis-boot.jar";
+         webContexts.clear();
+      }
+   }
 
-            String[] command = {"java", "-cp", bootJar, "org.apache.activemq.artemis.boot.WebTmpCleaner",
strBuilder.toString()};
-            ProcessBuilder pb = new ProcessBuilder(command);
+   private File getLibFolder() {
+      Path lib = artemisHomePath.resolve("lib");
+      File libFolder = new File(lib.toUri());
+      return libFolder;
+   }
 
-            pb.start();
-         }
+   public void cleanupWebTemporaryFiles(List<WebAppContext> webContexts) throws Exception
{
+      List<File> temporaryFiles = new ArrayList<>();
+      for (WebAppContext context : webContexts) {
+         File tmpdir = context.getTempDirectory();
+         temporaryFiles.add(tmpdir);
+      }
 
-         webContexts.clear();
+      if (!temporaryFiles.isEmpty()) {
+         WebTmpCleaner.cleanupTmpFiles(getLibFolder(), temporaryFiles);
       }
    }
 
diff --git a/artemis-boot/src/main/java/org/apache/activemq/artemis/boot/WebTmpCleaner.java
b/artemis-web/src/main/java/org/apache/activemq/artemis/component/WebTmpCleaner.java
similarity index 64%
rename from artemis-boot/src/main/java/org/apache/activemq/artemis/boot/WebTmpCleaner.java
rename to artemis-web/src/main/java/org/apache/activemq/artemis/component/WebTmpCleaner.java
index 42ba220..0bc0b67 100644
--- a/artemis-boot/src/main/java/org/apache/activemq/artemis/boot/WebTmpCleaner.java
+++ b/artemis-web/src/main/java/org/apache/activemq/artemis/component/WebTmpCleaner.java
@@ -14,9 +14,14 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package org.apache.activemq.artemis.boot;
+package org.apache.activemq.artemis.component;
 
 import java.io.File;
+import java.net.URI;
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.activemq.artemis.utils.SpawnedVMSupport;
 
 /**
  * This class is used to remove the jar files
@@ -26,10 +31,7 @@ import java.io.File;
  */
 public class WebTmpCleaner {
 
-   public static void main(String[] args) throws Exception {
-
-      String[] filesToClean = args[0].split(",");
-
+   public static void main(String[] filesToClean) throws Exception {
       //It needs to retry a bit as we are not sure
       //when the main VM exists.
       boolean allCleaned = false;
@@ -38,9 +40,10 @@ public class WebTmpCleaner {
          allCleaned = true;
          for (String f : filesToClean) {
             if (!f.trim().isEmpty()) {
-               File file = new File(f);
+               URI url = new URI(f);
+               File file = new File(url);
                if (file.exists()) {
-                  deleteFile(file);
+                  deleteFolder(file);
                   allCleaned = false;
                }
             }
@@ -49,13 +52,22 @@ public class WebTmpCleaner {
       }
    }
 
+   public static Process cleanupTmpFiles(File libFolder, List<File> temporaryFiles)
throws Exception {
+      ArrayList<String> files = new ArrayList<>(temporaryFiles.size());
+      for (File f : temporaryFiles) {
+         files.add(f.toURI().toString());
+      }
+
+      String classPath = SpawnedVMSupport.getClassPath(libFolder);
+      return SpawnedVMSupport.spawnVM(classPath, WebTmpCleaner.class.getName(), false, (String[])
files.toArray(new String[files.size()]));
+   }
 
-   public static final void deleteFile(final File file) {
+   public static final void deleteFolder(final File file) {
       if (file.isDirectory()) {
          String[] files = file.list();
          for (String path : files) {
             File f = new File(file, path);
-            deleteFile(f);
+            deleteFolder(f);
          }
       }
       file.delete();
diff --git a/artemis-web/src/test/java/org/apache/activemq/cli/test/WebServerCLITest.java
b/artemis-web/src/test/java/org/apache/activemq/cli/test/WebServerCLITest.java
new file mode 100644
index 0000000..e69de29
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpNoHearbeatsTest.java
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpNoHearbeatsTest.java
index a7e82d0..9f155cb 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpNoHearbeatsTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpNoHearbeatsTest.java
@@ -23,7 +23,7 @@ import java.util.Map;
 import java.util.concurrent.TimeUnit;
 
 import org.apache.activemq.artemis.core.server.ActiveMQServer;
-import org.apache.activemq.artemis.tests.util.SpawnedVMSupport;
+import org.apache.activemq.artemis.utils.SpawnedVMSupport;
 import org.apache.activemq.transport.amqp.client.AmqpClient;
 import org.apache.activemq.transport.amqp.client.AmqpConnection;
 import org.apache.activemq.transport.amqp.client.AmqpMessage;
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/IncompatibleVersionTest.java
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/IncompatibleVersionTest.java
index 20f98ec..ec641bd 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/IncompatibleVersionTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/IncompatibleVersionTest.java
@@ -42,7 +42,7 @@ import org.apache.activemq.artemis.core.server.ActiveMQServers;
 import org.apache.activemq.artemis.core.version.impl.VersionImpl;
 import org.apache.activemq.artemis.tests.integration.IntegrationTestLogger;
 import org.apache.activemq.artemis.tests.util.SpawnedTestBase;
-import org.apache.activemq.artemis.tests.util.SpawnedVMSupport;
+import org.apache.activemq.artemis.utils.SpawnedVMSupport;
 import org.apache.activemq.artemis.utils.VersionLoader;
 import org.junit.After;
 import org.junit.Assert;
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/JournalCrashTest.java
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/JournalCrashTest.java
index 944660a..c10f2ba 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/JournalCrashTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/JournalCrashTest.java
@@ -35,7 +35,7 @@ import org.apache.activemq.artemis.core.journal.RecordInfo;
 import org.apache.activemq.artemis.core.journal.impl.JournalImpl;
 import org.apache.activemq.artemis.core.server.ActiveMQServer;
 import org.apache.activemq.artemis.tests.util.SpawnedTestBase;
-import org.apache.activemq.artemis.tests.util.SpawnedVMSupport;
+import org.apache.activemq.artemis.utils.SpawnedVMSupport;
 import org.junit.Assert;
 import org.junit.Test;
 
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/SendAckFailTest.java
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/SendAckFailTest.java
index 210a9d1..b9b686c 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/SendAckFailTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/SendAckFailTest.java
@@ -79,7 +79,7 @@ import org.apache.activemq.artemis.spi.core.security.ActiveMQJAASSecurityManager
 import org.apache.activemq.artemis.spi.core.security.ActiveMQSecurityManager;
 import org.apache.activemq.artemis.spi.core.security.jaas.InVMLoginModule;
 import org.apache.activemq.artemis.tests.util.SpawnedTestBase;
-import org.apache.activemq.artemis.tests.util.SpawnedVMSupport;
+import org.apache.activemq.artemis.utils.SpawnedVMSupport;
 import org.apache.activemq.artemis.tests.util.Wait;
 import org.junit.After;
 import org.junit.Assert;
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/clientcrash/ClientCrashTest.java
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/clientcrash/ClientCrashTest.java
index e9f282e..532a79d 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/clientcrash/ClientCrashTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/clientcrash/ClientCrashTest.java
@@ -29,7 +29,7 @@ import org.apache.activemq.artemis.api.core.client.ServerLocator;
 import org.apache.activemq.artemis.core.settings.impl.AddressSettings;
 import org.apache.activemq.artemis.jms.client.ActiveMQTextMessage;
 import org.apache.activemq.artemis.tests.integration.IntegrationTestLogger;
-import org.apache.activemq.artemis.tests.util.SpawnedVMSupport;
+import org.apache.activemq.artemis.utils.SpawnedVMSupport;
 import org.junit.After;
 import org.junit.Assert;
 import org.junit.Before;
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/clientcrash/ClientExitTest.java
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/clientcrash/ClientExitTest.java
index 23fa0a6..0c0f27e 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/clientcrash/ClientExitTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/clientcrash/ClientExitTest.java
@@ -23,7 +23,7 @@ import org.apache.activemq.artemis.api.core.client.ClientSession;
 import org.apache.activemq.artemis.api.core.client.ClientSessionFactory;
 import org.apache.activemq.artemis.api.core.client.ServerLocator;
 import org.apache.activemq.artemis.tests.integration.IntegrationTestLogger;
-import org.apache.activemq.artemis.tests.util.SpawnedVMSupport;
+import org.apache.activemq.artemis.utils.SpawnedVMSupport;
 import org.apache.activemq.artemis.utils.RandomUtil;
 import org.junit.Before;
 import org.junit.Test;
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/clientcrash/PendingDeliveriesTest.java
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/clientcrash/PendingDeliveriesTest.java
index 9180532..8af9290 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/clientcrash/PendingDeliveriesTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/clientcrash/PendingDeliveriesTest.java
@@ -30,7 +30,7 @@ import org.apache.activemq.artemis.api.core.RoutingType;
 import org.apache.activemq.artemis.core.server.impl.AddressInfo;
 import org.apache.activemq.artemis.jms.client.ActiveMQConnectionFactory;
 import org.apache.activemq.artemis.logs.AssertionLoggerHandler;
-import org.apache.activemq.artemis.tests.util.SpawnedVMSupport;
+import org.apache.activemq.artemis.utils.SpawnedVMSupport;
 import org.apache.qpid.jms.JmsConnectionFactory;
 import org.junit.After;
 import org.junit.Assert;
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/RealNodeManagerTest.java
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/RealNodeManagerTest.java
index 1a49f94..1dfe48b 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/RealNodeManagerTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/RealNodeManagerTest.java
@@ -23,7 +23,7 @@ import java.util.List;
 import org.apache.activemq.artemis.core.server.NodeManager;
 import org.apache.activemq.artemis.core.server.impl.FileLockNodeManager;
 import org.apache.activemq.artemis.tests.util.ActiveMQTestBase;
-import org.apache.activemq.artemis.tests.util.SpawnedVMSupport;
+import org.apache.activemq.artemis.utils.SpawnedVMSupport;
 import org.apache.activemq.artemis.utils.UUID;
 import org.junit.Assert;
 import org.junit.Test;
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/LiveCrashOnBackupSyncTest.java
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/LiveCrashOnBackupSyncTest.java
new file mode 100644
index 0000000..e69de29
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/critical/CriticalCrashTest.java
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/critical/CriticalCrashTest.java
index df69af9..548b99e 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/critical/CriticalCrashTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/critical/CriticalCrashTest.java
@@ -36,7 +36,7 @@ import org.apache.activemq.artemis.spi.core.security.ActiveMQJAASSecurityManager
 import org.apache.activemq.artemis.spi.core.security.ActiveMQSecurityManager;
 import org.apache.activemq.artemis.spi.core.security.jaas.InVMLoginModule;
 import org.apache.activemq.artemis.tests.util.SpawnedTestBase;
-import org.apache.activemq.artemis.tests.util.SpawnedVMSupport;
+import org.apache.activemq.artemis.utils.SpawnedVMSupport;
 import org.junit.Assert;
 import org.junit.Test;
 
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/journal/CrashOnCompactTest.java
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/journal/CrashOnCompactTest.java
index 3badf29..e8b0e4b 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/journal/CrashOnCompactTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/journal/CrashOnCompactTest.java
@@ -33,7 +33,7 @@ import org.apache.activemq.artemis.core.journal.impl.JournalCompactor;
 import org.apache.activemq.artemis.core.journal.impl.JournalFile;
 import org.apache.activemq.artemis.core.journal.impl.JournalImpl;
 import org.apache.activemq.artemis.tests.util.SpawnedTestBase;
-import org.apache.activemq.artemis.tests.util.SpawnedVMSupport;
+import org.apache.activemq.artemis.utils.SpawnedVMSupport;
 import org.junit.Assert;
 import org.junit.Before;
 import org.junit.Test;
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/journal/ValidateTransactionHealthTest.java
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/journal/ValidateTransactionHealthTest.java
index 5de80f3..1a72b98 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/journal/ValidateTransactionHealthTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/journal/ValidateTransactionHealthTest.java
@@ -32,7 +32,7 @@ import org.apache.activemq.artemis.core.journal.RecordInfo;
 import org.apache.activemq.artemis.core.journal.impl.JournalImpl;
 import org.apache.activemq.artemis.jlibaio.LibaioContext;
 import org.apache.activemq.artemis.tests.util.SpawnedTestBase;
-import org.apache.activemq.artemis.tests.util.SpawnedVMSupport;
+import org.apache.activemq.artemis.utils.SpawnedVMSupport;
 import org.junit.Assert;
 import org.junit.Test;
 
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/PageCountSyncServer.java
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/PageCountSyncServer.java
index 3711965..2bc72c9 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/PageCountSyncServer.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/PageCountSyncServer.java
@@ -17,7 +17,7 @@
 package org.apache.activemq.artemis.tests.integration.paging;
 
 import org.apache.activemq.artemis.core.server.ActiveMQServer;
-import org.apache.activemq.artemis.tests.util.SpawnedVMSupport;
+import org.apache.activemq.artemis.utils.SpawnedVMSupport;
 
 /**
  * This is a sub process of the test {@link PageCountSyncOnNonTXTest}
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/PagingWithFailoverBackup.java
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/PagingWithFailoverBackup.java
index 928f8a8..b02224c 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/PagingWithFailoverBackup.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/PagingWithFailoverBackup.java
@@ -16,7 +16,7 @@
  */
 package org.apache.activemq.artemis.tests.integration.paging;
 
-import org.apache.activemq.artemis.tests.util.SpawnedVMSupport;
+import org.apache.activemq.artemis.utils.SpawnedVMSupport;
 
 /**
  * There is no difference between this class and {@link PagingWithFailoverServer}
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/PagingWithFailoverServer.java
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/PagingWithFailoverServer.java
index 99e0aac..c2fb8bd 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/PagingWithFailoverServer.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/PagingWithFailoverServer.java
@@ -17,7 +17,7 @@
 package org.apache.activemq.artemis.tests.integration.paging;
 
 import org.apache.activemq.artemis.core.server.ActiveMQServer;
-import org.apache.activemq.artemis.tests.util.SpawnedVMSupport;
+import org.apache.activemq.artemis.utils.SpawnedVMSupport;
 
 public class PagingWithFailoverServer extends SpawnedServerSupport {
 
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/security/NettySecurityClientTest.java
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/security/NettySecurityClientTest.java
index 15e287b..7e6b035 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/security/NettySecurityClientTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/security/NettySecurityClientTest.java
@@ -25,7 +25,7 @@ import org.apache.activemq.artemis.core.config.impl.ConfigurationImpl;
 import org.apache.activemq.artemis.core.server.ActiveMQServer;
 import org.apache.activemq.artemis.tests.integration.IntegrationTestLogger;
 import org.apache.activemq.artemis.tests.util.SpawnedTestBase;
-import org.apache.activemq.artemis.tests.util.SpawnedVMSupport;
+import org.apache.activemq.artemis.utils.SpawnedVMSupport;
 import org.junit.Assert;
 import org.junit.Before;
 import org.junit.Test;
diff --git a/tests/joram-tests/src/test/java/org/apache/activemq/artemis/common/AbstractAdmin.java
b/tests/joram-tests/src/test/java/org/apache/activemq/artemis/common/AbstractAdmin.java
index 70ce6be..b400613 100644
--- a/tests/joram-tests/src/test/java/org/apache/activemq/artemis/common/AbstractAdmin.java
+++ b/tests/joram-tests/src/test/java/org/apache/activemq/artemis/common/AbstractAdmin.java
@@ -35,7 +35,7 @@ import org.apache.activemq.artemis.api.core.management.ManagementHelper;
 import org.apache.activemq.artemis.api.core.management.ResourceNames;
 import org.apache.activemq.artemis.core.remoting.impl.netty.NettyConnectorFactory;
 import org.apache.activemq.artemis.api.core.RoutingType;
-import org.apache.activemq.artemis.tests.util.SpawnedVMSupport;
+import org.apache.activemq.artemis.utils.SpawnedVMSupport;
 import org.objectweb.jtests.jms.admin.Admin;
 
 /**
diff --git a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/util/RandomUtilDistributionTest.java
b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/util/RandomUtilDistributionTest.java
index caa0fc9..e324545 100644
--- a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/util/RandomUtilDistributionTest.java
+++ b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/util/RandomUtilDistributionTest.java
@@ -20,8 +20,8 @@ package org.apache.activemq.artemis.tests.unit.core.util;
 import java.util.HashSet;
 
 import org.apache.activemq.artemis.tests.util.SpawnedVMCheck;
-import org.apache.activemq.artemis.tests.util.SpawnedVMSupport;
 import org.apache.activemq.artemis.utils.RandomUtil;
+import org.apache.activemq.artemis.utils.SpawnedVMSupport;
 import org.junit.Assert;
 import org.junit.Rule;
 import org.junit.Test;
diff --git a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/util/SpawnedVMCheck.java
b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/util/SpawnedVMCheck.java
index cc1c043..79aa653 100644
--- a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/util/SpawnedVMCheck.java
+++ b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/util/SpawnedVMCheck.java
@@ -17,6 +17,7 @@
 
 package org.apache.activemq.artemis.tests.util;
 
+import org.apache.activemq.artemis.utils.SpawnedVMSupport;
 import org.junit.rules.ExternalResource;
 
 public class SpawnedVMCheck extends ExternalResource {


Mime
View raw message