Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 49421200CD8 for ; Tue, 18 Jul 2017 22:12:03 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 47F9116781B; Tue, 18 Jul 2017 20:12:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9103B167818 for ; Tue, 18 Jul 2017 22:12:02 +0200 (CEST) Received: (qmail 92858 invoked by uid 500); 18 Jul 2017 20:12:01 -0000 Mailing-List: contact commits-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list commits@activemq.apache.org Received: (qmail 92796 invoked by uid 99); 18 Jul 2017 20:12:01 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Jul 2017 20:12:01 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 8F6AEE360F; Tue, 18 Jul 2017 20:12:01 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: clebertsuconic@apache.org To: commits@activemq.apache.org Date: Tue, 18 Jul 2017 20:12:03 -0000 Message-Id: In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: [3/4] activemq-artemis git commit: ARTEMIS-1287/ARTEMIS-1292 Fixing intermittent failure on reconnects archived-at: Tue, 18 Jul 2017 20:12:03 -0000 ARTEMIS-1287/ARTEMIS-1292 Fixing intermittent failure on reconnects Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/41a03de0 Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/41a03de0 Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/41a03de0 Branch: refs/heads/master Commit: 41a03de02fac02f4af1dd7280997144948ddd924 Parents: de4ea0f Author: Clebert Suconic Authored: Mon Jul 17 09:11:39 2017 -0400 Committer: Clebert Suconic Committed: Tue Jul 18 10:24:39 2017 -0400 ---------------------------------------------------------------------- .../core/protocol/core/ServerSessionPacketHandler.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/41a03de0/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/ServerSessionPacketHandler.java ---------------------------------------------------------------------- diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/ServerSessionPacketHandler.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/ServerSessionPacketHandler.java index bd97939..06fb288 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/ServerSessionPacketHandler.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/ServerSessionPacketHandler.java @@ -180,8 +180,11 @@ public class ServerSessionPacketHandler implements ChannelHandler { this.callExecutor = server.getExecutorFactory().getExecutor(); - // TODO: I wish I could figure out how to create this through OrderedExecutor - this.packetActor = new Actor<>(server.getThreadPool(), this::onMessagePacket); + // In an optimized way packetActor should use the threadPool as the parent executor + // directly from server.getThreadPool(); + // However due to how transferConnection is handled we need to + // use the same executor + this.packetActor = new Actor<>(callExecutor, this::onMessagePacket); if (conn instanceof NettyConnection) { direct = ((NettyConnection) conn).isDirectDeliver();