Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 79E5E200CCC for ; Fri, 7 Jul 2017 02:26:03 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 78410167C4B; Fri, 7 Jul 2017 00:26:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BDF15167C4A for ; Fri, 7 Jul 2017 02:26:02 +0200 (CEST) Received: (qmail 19734 invoked by uid 500); 7 Jul 2017 00:26:02 -0000 Mailing-List: contact commits-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list commits@activemq.apache.org Received: (qmail 19725 invoked by uid 99); 7 Jul 2017 00:26:01 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Jul 2017 00:26:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 8C30BC11CD for ; Fri, 7 Jul 2017 00:26:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.011 X-Spam-Level: X-Spam-Status: No, score=-100.011 tagged_above=-999 required=6.31 tests=[SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id MOLDG1JV0342 for ; Fri, 7 Jul 2017 00:26:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C10E95FB32 for ; Fri, 7 Jul 2017 00:26:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 54B94E0641 for ; Fri, 7 Jul 2017 00:26:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0D45624688 for ; Fri, 7 Jul 2017 00:26:00 +0000 (UTC) Date: Fri, 7 Jul 2017 00:26:00 +0000 (UTC) From: "Timothy Bish (JIRA)" To: commits@activemq.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Closed] (APLO-399) Code style issues MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 07 Jul 2017 00:26:03 -0000 [ https://issues.apache.org/jira/browse/APLO-399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Bish closed APLO-399. ----------------------------- Resolution: Won't Fix Apollo is no longer being maintained, please take a look at ActiveMQ or ActiveMQ Artemis projects > Code style issues > ----------------- > > Key: APLO-399 > URL: https://issues.apache.org/jira/browse/APLO-399 > Project: ActiveMQ Apollo > Issue Type: New Feature > Reporter: Tianyin Xu > > Hi, > I was trying hard to find the code-style specifications in the current code base, > but failed (let me know if it's somewhere). > I run {{CheckStyle}} on the current code base, and see that the style is very inconsistent. > Pick {{apollo-util/src/main/scala/org/apache/activemq/apollo/util/Scheduler.java}} in trunk for example, > in the 58 lines of code, there're 4 lines using {{tab}} for indentation and the rest using {{4 space}}. > (there are many like this) > There're also many other inconsistent style issues, such as all different {{LineLength}} and redundant {{import}}. > Let me know if you'd like to integrate {{CheckStyle}} or something alike in the Maven build > (which can rule out such issues) > Thanks! -- This message was sent by Atlassian JIRA (v6.4.14#64029)