activemq-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuco...@apache.org
Subject [2/3] activemq-artemis git commit: ARTEMIS-1244 Retain flag code todo comment
Date Thu, 22 Jun 2017 15:51:26 GMT
ARTEMIS-1244 Retain flag code todo comment

Identified possible bug in MQTT receive of missing retained flag.


Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/2b804261
Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/2b804261
Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/2b804261

Branch: refs/heads/master
Commit: 2b804261532ae10db073cdccbfdf04ace999dc95
Parents: e801df7
Author: Michal Tóth <mtoth@redhat.com>
Authored: Wed Jun 21 13:17:54 2017 +0200
Committer: Clebert Suconic <clebertsuconic@apache.org>
Committed: Thu Jun 22 11:51:11 2017 -0400

----------------------------------------------------------------------
 .../integration/mqtt/imported/MQTTInterceptorPropertiesTest.java    | 1 +
 1 file changed, 1 insertion(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/2b804261/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt/imported/MQTTInterceptorPropertiesTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt/imported/MQTTInterceptorPropertiesTest.java
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt/imported/MQTTInterceptorPropertiesTest.java
index 375e2f2..0b62194 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt/imported/MQTTInterceptorPropertiesTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt/imported/MQTTInterceptorPropertiesTest.java
@@ -64,6 +64,7 @@ public class MQTTInterceptorPropertiesTest extends MQTTTestSupport {
          MqttFixedHeader header = message.fixedHeader();
          assertNotNull(header.messageType());
          assertEquals(header.qosLevel().value(), AT_MOST_ONCE);
+         // TODO resolve the following line based on result of ARTEMIS-1244, currently fails
(2.1.0)
          assertEquals(header.isRetain(), expectedProperties.get(RETAINED));
       } catch (Throwable t) {
          collector.addError(t);


Mime
View raw message