activemq-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuco...@apache.org
Subject [2/3] activemq-artemis git commit: ARTEMIS-1189 - Fix checkstyle violations post checkstyle upgrade
Date Tue, 30 May 2017 17:40:28 GMT
ARTEMIS-1189 - Fix checkstyle violations post checkstyle upgrade

After upgrade of checkstyle, resolve violations

remove checkstyle override added as temp measure at point of upgrade forced by sevntu


Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/c65ea783
Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/c65ea783
Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/c65ea783

Branch: refs/heads/master
Commit: c65ea783ead733bfd1ca837a5032001efa0ade05
Parents: e8cd6b5
Author: Michael Andre Pearce <Michael.Andre.Pearce@me.com>
Authored: Mon May 29 23:48:50 2017 +0100
Committer: Clebert Suconic <clebertsuconic@apache.org>
Committed: Tue May 30 13:40:00 2017 -0400

----------------------------------------------------------------------
 .../artemis/cli/commands/InputAbstract.java     |  9 ++++--
 .../artemis/logs/AssertionLoggerHandler.java    |  3 +-
 .../apache/activemq/artemis/utils/Base64.java   |  3 +-
 .../artemis/utils/OrderedExecutorFactory.java   |  3 +-
 .../activemq/artemis/utils/UUIDTimer.java       |  3 +-
 .../activemq/artemis/api/core/ICoreMessage.java |  2 +-
 .../artemis/api/core/client/ClientSession.java  |  4 +--
 .../artemis/api/core/client/ServerLocator.java  |  6 ++--
 .../api/core/management/AddressControl.java     |  2 +-
 .../api/core/management/QueueControl.java       |  2 +-
 .../client/impl/ClientConsumerInternal.java     |  2 +-
 .../core/client/impl/ClientProducerImpl.java    |  3 +-
 .../impl/ClientSessionFactoryInternal.java      |  2 +-
 .../core/client/impl/ClientSessionInternal.java |  2 +-
 .../client/impl/LargeMessageController.java     |  4 +--
 .../core/client/impl/ServerLocatorImpl.java     |  3 +-
 .../core/client/impl/ServerLocatorInternal.java |  2 +-
 .../artemis/core/protocol/core/Channel.java     |  2 +-
 .../impl/ActiveMQClientProtocolManager.java     |  3 +-
 .../core/impl/ActiveMQSessionContext.java       |  3 +-
 .../core/protocol/core/impl/PacketDecoder.java  |  2 +-
 .../core/remoting/ClientProtocolManager.java    | 14 ++++----
 .../spi/core/remoting/SessionContext.java       | 30 ++++++++---------
 .../core/remoting/TopologyResponseHandler.java  | 12 +++----
 .../artemis/jdbc/store/drivers/JDBCUtils.java   |  3 +-
 .../artemis/api/jms/JMSFactoryType.java         |  8 ++---
 .../artemis/jms/bridge/impl/JMSBridgeImpl.java  |  3 +-
 .../jms/server/JMSServerConfigParser.java       |  8 ++---
 .../artemis/jms/server/JMSServerManager.java    |  8 ++---
 .../activemq/artemis/core/journal/Journal.java  | 22 ++++++-------
 .../artemis/journal/ActiveMQJournalLogger.java  |  2 +-
 .../protocol/stomp/StompProtocolManager.java    |  3 +-
 .../artemis/core/config/Configuration.java      | 32 +++++++++---------
 .../core/paging/PageTransactionInfo.java        |  8 ++---
 .../artemis/core/paging/PagingStore.java        |  4 +--
 .../core/paging/cursor/PageCursorProvider.java  |  2 +-
 .../core/paging/cursor/PageSubscription.java    |  4 +--
 .../paging/cursor/PageSubscriptionCounter.java  |  6 ++--
 .../cursor/impl/PageSubscriptionImpl.java       |  3 +-
 .../core/persistence/StorageManager.java        | 14 ++++----
 .../core/postoffice/DuplicateIDCache.java       |  4 +--
 .../artemis/core/postoffice/PostOffice.java     |  6 ++--
 .../remoting/impl/netty/ConnectionCreator.java  |  2 +-
 .../impl/netty/HttpAcceptorHandler.java         |  6 ++--
 .../core/replication/ReplicationManager.java    |  4 +--
 .../artemis/core/security/CheckType.java        |  2 +-
 .../artemis/core/server/ActiveMQServer.java     |  8 ++---
 .../activemq/artemis/core/server/Queue.java     | 12 +++----
 .../artemis/core/server/QueueFactory.java       |  4 +--
 .../core/server/ScheduledDeliveryHandler.java   |  2 +-
 .../artemis/core/server/ServerConsumer.java     |  4 +--
 .../artemis/core/server/ServerSession.java      | 34 ++++++++++----------
 .../core/server/cluster/qourum/Vote.java        |  4 +--
 .../group/impl/RemoteGroupingHandler.java       |  3 +-
 .../core/server/impl/FileLockNodeManager.java   |  6 ++--
 .../core/server/impl/InVMNodeManager.java       |  3 +-
 .../core/server/impl/ServerConsumerImpl.java    |  3 +-
 .../impl/SharedNothingBackupActivation.java     |  3 +-
 .../server/management/ManagementService.java    | 30 ++++++++---------
 .../spi/core/protocol/ProtocolManager.java      |  2 +-
 .../security/jaas/CertificateLoginModule.java   |  4 +--
 .../artemis/tests/util/ActiveMQTestBase.java    | 12 ++++---
 .../xa/recovery/ActiveMQRegistry.java           |  4 +--
 etc/checkstyle.xml                              |  6 ++--
 .../transport/amqp/client/AmqpConnection.java   |  3 +-
 .../transport/amqp/client/AmqpReceiver.java     |  3 +-
 ...MDBMultipleHandlersServerDisconnectTest.java |  3 +-
 .../client/ConsumerWindowSizeTest.java          |  3 +-
 .../integration/client/SlowConsumerTest.java    |  3 +-
 .../cluster/bridge/BridgeReconnectTest.java     |  3 +-
 .../cluster/distribution/ClusterTestBase.java   | 15 ++++++---
 .../failover/AsynchronousFailoverTest.java      | 12 ++++---
 .../ClusterWithBackupFailoverTestBase.java      |  2 +-
 .../cluster/failover/FailoverTestBase.java      |  2 +-
 .../failover/GroupingFailoverTestBase.java      |  3 +-
 .../MultipleServerFailoverTestBase.java         |  3 +-
 .../MultiThreadReattachSupportTestBase.java     |  5 +--
 .../cluster/reattach/RandomReattachTest.java    |  5 +--
 .../topology/TopologyClusterTestBase.java       |  6 ++--
 .../jms/cluster/BindingsClusterTest.java        |  3 +-
 .../jms/cluster/JMSFailoverTest.java            |  3 +-
 .../jms/server/management/JMSUtil.java          |  3 +-
 .../management/NotificationTest.java            |  3 +-
 .../management/SecurityNotificationTest.java    |  3 +-
 .../integration/mqtt/imported/MQTTTest.java     | 12 ++++---
 .../integration/server/ExpiryRunnerTest.java    |  6 ++--
 .../jms/tests/tools/container/Server.java       | 14 ++++----
 .../tests/stress/paging/PageStressTest.java     |  9 ++++--
 .../impl/fakes/FakeSequentialFileFactory.java   |  2 +-
 89 files changed, 304 insertions(+), 244 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/InputAbstract.java
----------------------------------------------------------------------
diff --git a/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/InputAbstract.java b/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/InputAbstract.java
index d4535be..cadb702 100644
--- a/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/InputAbstract.java
+++ b/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/InputAbstract.java
@@ -59,7 +59,8 @@ public class InputAbstract extends ActionAbstract {
             case "N":
                booleanValue = Boolean.FALSE; break;
          }
-      } while (booleanValue == null);
+      }
+      while (booleanValue == null);
 
       return booleanValue.booleanValue();
    }
@@ -85,7 +86,8 @@ public class InputAbstract extends ActionAbstract {
          } else {
             valid = true;
          }
-      } while (!valid);
+      }
+      while (!valid);
 
       return inputStr.trim();
    }
@@ -116,7 +118,8 @@ public class InputAbstract extends ActionAbstract {
          } else {
             valid = true;
          }
-      } while (!valid);
+      }
+      while (!valid);
 
       return inputStr.trim();
    }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-commons/src/main/java/org/apache/activemq/artemis/logs/AssertionLoggerHandler.java
----------------------------------------------------------------------
diff --git a/artemis-commons/src/main/java/org/apache/activemq/artemis/logs/AssertionLoggerHandler.java b/artemis-commons/src/main/java/org/apache/activemq/artemis/logs/AssertionLoggerHandler.java
index ac89fc2..6191e76 100644
--- a/artemis-commons/src/main/java/org/apache/activemq/artemis/logs/AssertionLoggerHandler.java
+++ b/artemis-commons/src/main/java/org/apache/activemq/artemis/logs/AssertionLoggerHandler.java
@@ -78,7 +78,8 @@ public class AssertionLoggerHandler extends ExtHandler {
          if (findText(text)) {
             return true;
          }
-      } while (timeMax > System.currentTimeMillis());
+      }
+      while (timeMax > System.currentTimeMillis());
 
       return false;
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/Base64.java
----------------------------------------------------------------------
diff --git a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/Base64.java b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/Base64.java
index ebe18ec..7b7cac4 100644
--- a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/Base64.java
+++ b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/Base64.java
@@ -1311,7 +1311,8 @@ public class Base64 {
                   int b = 0;
                   do {
                      b = in.read();
-                  } while (b >= 0 && decodabet[b & 0x7f] <= Base64.WHITE_SPACE_ENC);
+                  }
+                  while (b >= 0 && decodabet[b & 0x7f] <= Base64.WHITE_SPACE_ENC);
 
                   if (b < 0) {
                      break; // Reads a -1 if end of stream

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/OrderedExecutorFactory.java
----------------------------------------------------------------------
diff --git a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/OrderedExecutorFactory.java b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/OrderedExecutorFactory.java
index c7d5c03..24fa5e7 100644
--- a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/OrderedExecutorFactory.java
+++ b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/OrderedExecutorFactory.java
@@ -115,7 +115,8 @@ public final class OrderedExecutorFactory implements ExecutorFactory {
                //we loop again based on tasks not being empty. Otherwise there is a window where the state is running,
                //but poll() has returned null, so a submitting thread will believe that it does not need re-execute.
                //this check fixes the issue
-            } while (!tasks.isEmpty());
+            }
+            while (!tasks.isEmpty());
          }
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/UUIDTimer.java
----------------------------------------------------------------------
diff --git a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/UUIDTimer.java b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/UUIDTimer.java
index 0945d23..d96313b 100644
--- a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/UUIDTimer.java
+++ b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/UUIDTimer.java
@@ -293,6 +293,7 @@ public class UUIDTimer {
          if (++counter > UUIDTimer.MAX_WAIT_COUNT) {
             break;
          }
-      } while (System.currentTimeMillis() < waitUntil);
+      }
+      while (System.currentTimeMillis() < waitUntil);
    }
 }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/ICoreMessage.java
----------------------------------------------------------------------
diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/ICoreMessage.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/ICoreMessage.java
index 779470e..f49ef68 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/ICoreMessage.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/ICoreMessage.java
@@ -63,7 +63,7 @@ public interface ICoreMessage extends Message {
 
 
    /** Used on large messages treatment */
-   void copyHeadersAndProperties(final Message msg);
+   void copyHeadersAndProperties(Message msg);
 
    /**
     * @return Returns the message in Map form, useful when encoding to JSON

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/ClientSession.java
----------------------------------------------------------------------
diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/ClientSession.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/ClientSession.java
index 16b3cd4..c3d6749 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/ClientSession.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/ClientSession.java
@@ -216,7 +216,7 @@ public interface ClientSession extends XAResource, AutoCloseable {
     * @param autoCreated
     * @throws ActiveMQException
     */
-   void createAddress(final SimpleString address, Set<RoutingType> routingTypes, final boolean autoCreated) throws ActiveMQException;
+   void createAddress(SimpleString address, Set<RoutingType> routingTypes, boolean autoCreated) throws ActiveMQException;
 
    /**
     * Create Address with a single initial routing type
@@ -225,7 +225,7 @@ public interface ClientSession extends XAResource, AutoCloseable {
     * @param autoCreated
     * @throws ActiveMQException
     */
-   void createAddress(final SimpleString address, RoutingType routingType, final boolean autoCreated) throws ActiveMQException;
+   void createAddress(SimpleString address, RoutingType routingType, boolean autoCreated) throws ActiveMQException;
 
    // Queue Operations ----------------------------------------------
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/ServerLocator.java
----------------------------------------------------------------------
diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/ServerLocator.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/ServerLocator.java
index db4b6fd..69e287c 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/ServerLocator.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/ServerLocator.java
@@ -74,7 +74,7 @@ public interface ServerLocator extends AutoCloseable {
     * @throws Exception if a failure happened in creating the ClientSessionFactory or the
     *                   ServerLocator does not know about the passed in transportConfiguration
     */
-   ClientSessionFactory createSessionFactory(final String nodeID) throws Exception;
+   ClientSessionFactory createSessionFactory(String nodeID) throws Exception;
 
    /**
     * Creates a {@link ClientSessionFactory} to a specific server. The server must already be known
@@ -86,7 +86,7 @@ public interface ServerLocator extends AutoCloseable {
     * @throws Exception if a failure happened in creating the ClientSessionFactory or the
     *                   ServerLocator does not know about the passed in transportConfiguration
     */
-   ClientSessionFactory createSessionFactory(final TransportConfiguration transportConfiguration) throws Exception;
+   ClientSessionFactory createSessionFactory(TransportConfiguration transportConfiguration) throws Exception;
 
    /**
     * Creates a {@link ClientSessionFactory} to a specific server. The server must already be known
@@ -100,7 +100,7 @@ public interface ServerLocator extends AutoCloseable {
     * @throws Exception if a failure happened in creating the ClientSessionFactory or the
     *                   ServerLocator does not know about the passed in transportConfiguration
     */
-   ClientSessionFactory createSessionFactory(final TransportConfiguration transportConfiguration,
+   ClientSessionFactory createSessionFactory(TransportConfiguration transportConfiguration,
                                              int reconnectAttempts,
                                              boolean failoverOnInitialConnection) throws Exception;
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/AddressControl.java
----------------------------------------------------------------------
diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/AddressControl.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/AddressControl.java
index 0dadad1..93a2822 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/AddressControl.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/AddressControl.java
@@ -116,7 +116,7 @@ public interface AddressControl {
     */
    @Operation(desc = "Sends a TextMessage to a password-protected address.", impact = MBeanOperationInfo.ACTION)
    String sendMessage(@Parameter(name = "headers", desc = "The headers to add to the message") Map<String, String> headers,
-                      @Parameter(name = "type", desc = "A type for the message") final int type,
+                      @Parameter(name = "type", desc = "A type for the message") int type,
                       @Parameter(name = "body", desc = "The body (byte[]) of the message encoded as a string using Base64") String body,
                       @Parameter(name = "durable", desc = "Whether the message is durable") boolean durable,
                       @Parameter(name = "user", desc = "The user to authenticate with") String user,

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/QueueControl.java
----------------------------------------------------------------------
diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/QueueControl.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/QueueControl.java
index 1bc28d4..89517aa 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/QueueControl.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/QueueControl.java
@@ -363,7 +363,7 @@ public interface QueueControl {
     */
    @Operation(desc = "Sends a TextMessage to a password-protected destination.", impact = MBeanOperationInfo.ACTION)
    String sendMessage(@Parameter(name = "headers", desc = "The headers to add to the message") Map<String, String> headers,
-                      @Parameter(name = "type", desc = "A type for the message") final int type,
+                      @Parameter(name = "type", desc = "A type for the message") int type,
                       @Parameter(name = "body", desc = "The body (byte[]) of the message encoded as a string using Base64") String body,
                       @Parameter(name = "durable", desc = "Whether the message is durable") boolean durable,
                       @Parameter(name = "user", desc = "The user to authenticate with") String user,

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientConsumerInternal.java
----------------------------------------------------------------------
diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientConsumerInternal.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientConsumerInternal.java
index 82f3dbb..cc5f3f1 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientConsumerInternal.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientConsumerInternal.java
@@ -37,7 +37,7 @@ public interface ClientConsumerInternal extends ClientConsumer {
 
    void handleLargeMessageContinuation(byte[] chunk, int flowControlSize, boolean isContinues) throws Exception;
 
-   void flowControl(final int messageBytes, final boolean discountSlowConsumer) throws ActiveMQException;
+   void flowControl(int messageBytes, boolean discountSlowConsumer) throws ActiveMQException;
 
    void clear(boolean waitForOnMessage) throws ActiveMQException;
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientProducerImpl.java
----------------------------------------------------------------------
diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientProducerImpl.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientProducerImpl.java
index ce4a8a1..5504093 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientProducerImpl.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientProducerImpl.java
@@ -457,7 +457,8 @@ public class ClientProducerImpl implements ClientProducerInternal {
             }
 
             pos += numberOfBytesRead;
-         } while (pos < minLargeMessageSize);
+         }
+         while (pos < minLargeMessageSize);
 
          totalSize += pos;
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryInternal.java
----------------------------------------------------------------------
diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryInternal.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryInternal.java
index be98a8e..f72ca5e 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryInternal.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryInternal.java
@@ -45,7 +45,7 @@ public interface ClientSessionFactoryInternal extends ClientSessionFactory {
 
    int numSessions();
 
-   void removeSession(final ClientSessionInternal session, boolean failingOver);
+   void removeSession(ClientSessionInternal session, boolean failingOver);
 
    void connect(int reconnectAttempts, boolean failoverOnInitialConnection) throws ActiveMQException;
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionInternal.java
----------------------------------------------------------------------
diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionInternal.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionInternal.java
index 4e06068..3c6829a 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionInternal.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionInternal.java
@@ -33,7 +33,7 @@ public interface ClientSessionInternal extends ClientSession {
 
    void acknowledge(ClientConsumer consumer, Message message) throws ActiveMQException;
 
-   void individualAcknowledge(final ClientConsumer consumer, final Message message) throws ActiveMQException;
+   void individualAcknowledge(ClientConsumer consumer, Message message) throws ActiveMQException;
 
    boolean isCacheLargeMessageClient();
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/LargeMessageController.java
----------------------------------------------------------------------
diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/LargeMessageController.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/LargeMessageController.java
index ced3028..165a4d6 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/LargeMessageController.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/LargeMessageController.java
@@ -46,13 +46,13 @@ public interface LargeMessageController extends ActiveMQBuffer {
    /**
     * Sets the OutputStream of this buffer to the specified output.
     */
-   void setOutputStream(final OutputStream output) throws ActiveMQException;
+   void setOutputStream(OutputStream output) throws ActiveMQException;
 
    /**
     * Saves this buffer to the specified output. This is just a blocking version of
     * {@link #setOutputStream(OutputStream)}.
     */
-   void saveBuffer(final OutputStream output) throws ActiveMQException;
+   void saveBuffer(OutputStream output) throws ActiveMQException;
 
    void addPacket(byte[] chunk, int flowControlSize, boolean isContinues);
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ServerLocatorImpl.java
----------------------------------------------------------------------
diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ServerLocatorImpl.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ServerLocatorImpl.java
index 949ef90..908f91f 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ServerLocatorImpl.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ServerLocatorImpl.java
@@ -792,7 +792,8 @@ public final class ServerLocatorImpl implements ServerLocatorInternal, Discovery
                   throw e;
                }
             }
-         } while (retry);
+         }
+         while (retry);
       }
 
       // ATM topology is never != null. Checking here just to be consistent with

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ServerLocatorInternal.java
----------------------------------------------------------------------
diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ServerLocatorInternal.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ServerLocatorInternal.java
index d7522b7..8219833 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ServerLocatorInternal.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ServerLocatorInternal.java
@@ -29,7 +29,7 @@ public interface ServerLocatorInternal extends ServerLocator {
 
    void start(Executor executor) throws Exception;
 
-   void factoryClosed(final ClientSessionFactory factory);
+   void factoryClosed(ClientSessionFactory factory);
 
    AfterConnectInternalListener getAfterConnectInternalListener();
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/Channel.java
----------------------------------------------------------------------
diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/Channel.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/Channel.java
index 9771795..127a69a 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/Channel.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/Channel.java
@@ -73,7 +73,7 @@ public interface Channel {
     * @return false if the packet was rejected by an outgoing interceptor; true if the send was
     * successful
     */
-   boolean send(Packet packet, final int reconnectID);
+   boolean send(Packet packet, int reconnectID);
 
    /**
     * Sends a packet on this channel using batching algorithm if appropriate

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQClientProtocolManager.java
----------------------------------------------------------------------
diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQClientProtocolManager.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQClientProtocolManager.java
index c79fc70..1ebc1d0 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQClientProtocolManager.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQClientProtocolManager.java
@@ -324,7 +324,8 @@ public class ActiveMQClientProtocolManager implements ClientProtocolManager {
             inCreateSession = false;
             inCreateSessionLatch.countDown();
          }
-      } while (retry);
+      }
+      while (retry);
       return newSessionContext(name, confirmationWindowSize, sessionChannel, response);
 
    }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java
----------------------------------------------------------------------
diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java
index 7799395..f9af0b1 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java
@@ -676,7 +676,8 @@ public class ActiveMQSessionContext extends SessionContext {
                throw e;
             }
          }
-      } while (retry && !session.isClosing());
+      }
+      while (retry && !session.isClosing());
    }
 
    protected CreateSessionMessage newCreateSession(String username,

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/PacketDecoder.java
----------------------------------------------------------------------
diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/PacketDecoder.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/PacketDecoder.java
index e39e16b..2755b9a 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/PacketDecoder.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/PacketDecoder.java
@@ -160,7 +160,7 @@ import static org.apache.activemq.artemis.core.protocol.core.impl.PacketImpl.SUB
 
 public abstract class PacketDecoder implements Serializable {
 
-   public abstract Packet decode(final ActiveMQBuffer in);
+   public abstract Packet decode(ActiveMQBuffer in);
 
    public Packet decode(byte packetType) {
       Packet packet;

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/remoting/ClientProtocolManager.java
----------------------------------------------------------------------
diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/remoting/ClientProtocolManager.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/remoting/ClientProtocolManager.java
index a3f83dc..e2c9fc1 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/remoting/ClientProtocolManager.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/remoting/ClientProtocolManager.java
@@ -58,13 +58,13 @@ public interface ClientProtocolManager {
 
    void ping(long connectionTTL);
 
-   SessionContext createSessionContext(final String name,
-                                       final String username,
-                                       final String password,
-                                       final boolean xa,
-                                       final boolean autoCommitSends,
-                                       final boolean autoCommitAcks,
-                                       final boolean preAcknowledge,
+   SessionContext createSessionContext(String name,
+                                       String username,
+                                       String password,
+                                       boolean xa,
+                                       boolean autoCommitSends,
+                                       boolean autoCommitAcks,
+                                       boolean preAcknowledge,
                                        int minLargeMessageSize,
                                        int confirmationWindowSize) throws ActiveMQException;
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/remoting/SessionContext.java
----------------------------------------------------------------------
diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/remoting/SessionContext.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/remoting/SessionContext.java
index 3fddb8e..fe3feb2 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/remoting/SessionContext.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/remoting/SessionContext.java
@@ -94,7 +94,7 @@ public abstract class SessionContext {
    }
 
    protected void handleReceiveMessage(ConsumerContext consumerID,
-                                       final ClientMessageInternal message) throws Exception {
+                                       ClientMessageInternal message) throws Exception {
 
       ClientSessionInternal session = this.session;
       if (session != null) {
@@ -102,7 +102,7 @@ public abstract class SessionContext {
       }
    }
 
-   protected void handleReceiveContinuation(final ConsumerContext consumerID,
+   protected void handleReceiveContinuation(ConsumerContext consumerID,
                                             byte[] chunk,
                                             int flowControlSize,
                                             boolean isContinues) throws Exception {
@@ -159,7 +159,7 @@ public abstract class SessionContext {
                                                    byte[] chunk,
                                                    SendAcknowledgementHandler messageHandler) throws ActiveMQException;
 
-   public abstract void setSendAcknowledgementHandler(final SendAcknowledgementHandler handler);
+   public abstract void setSendAcknowledgementHandler(SendAcknowledgementHandler handler);
 
    /**
     * Creates a shared queue using the routing type set by the Address.  If the Address supports more than one type of delivery
@@ -210,7 +210,7 @@ public abstract class SessionContext {
 
    public abstract void forceDelivery(ClientConsumer consumer, long sequence) throws ActiveMQException;
 
-   public abstract ClientSession.AddressQuery addressQuery(final SimpleString address) throws ActiveMQException;
+   public abstract ClientSession.AddressQuery addressQuery(SimpleString address) throws ActiveMQException;
 
    public abstract void simpleCommit() throws ActiveMQException;
 
@@ -231,10 +231,10 @@ public abstract class SessionContext {
 
    public abstract void sendACK(boolean individual,
                                 boolean block,
-                                final ClientConsumer consumer,
-                                final Message message) throws ActiveMQException;
+                                ClientConsumer consumer,
+                                Message message) throws ActiveMQException;
 
-   public abstract void expireMessage(final ClientConsumer consumer, Message message) throws ActiveMQException;
+   public abstract void expireMessage(ClientConsumer consumer, Message message) throws ActiveMQException;
 
    public abstract void sessionClose() throws ActiveMQException;
 
@@ -242,7 +242,7 @@ public abstract class SessionContext {
 
    public abstract void addUniqueMetaData(String key, String data) throws ActiveMQException;
 
-   public abstract void sendProducerCreditsMessage(final int credits, final SimpleString address);
+   public abstract void sendProducerCreditsMessage(int credits, SimpleString address);
 
    public abstract void xaCommit(Xid xid, boolean onePhase) throws XAException, ActiveMQException;
 
@@ -278,13 +278,13 @@ public abstract class SessionContext {
 
    public abstract int getServerVersion();
 
-   public abstract void recreateSession(final String username,
-                                        final String password,
-                                        final int minLargeMessageSize,
-                                        final boolean xa,
-                                        final boolean autoCommitSends,
-                                        final boolean autoCommitAcks,
-                                        final boolean preAcknowledge) throws ActiveMQException;
+   public abstract void recreateSession(String username,
+                                        String password,
+                                        int minLargeMessageSize,
+                                        boolean xa,
+                                        boolean autoCommitSends,
+                                        boolean autoCommitAcks,
+                                        boolean preAcknowledge) throws ActiveMQException;
 
    public abstract void recreateConsumerOnServer(ClientConsumerInternal consumerInternal) throws ActiveMQException;
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/remoting/TopologyResponseHandler.java
----------------------------------------------------------------------
diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/remoting/TopologyResponseHandler.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/remoting/TopologyResponseHandler.java
index eda05ee..55e202c 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/remoting/TopologyResponseHandler.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/remoting/TopologyResponseHandler.java
@@ -26,12 +26,12 @@ public interface TopologyResponseHandler {
    void nodeDisconnected(RemotingConnection conn, String nodeID, String scaleDownTargetNodeID);
 
    void notifyNodeUp(long uniqueEventID,
-                     final String backupGroupName,
-                     final String scaleDownGroupName,
-                     final String nodeName,
-                     final Pair<TransportConfiguration, TransportConfiguration> connectorPair,
-                     final boolean isLast);
+                     String backupGroupName,
+                     String scaleDownGroupName,
+                     String nodeName,
+                     Pair<TransportConfiguration, TransportConfiguration> connectorPair,
+                     boolean isLast);
 
    // This is sent when any node on the cluster topology is going down
-   void notifyNodeDown(final long eventTime, final String nodeID);
+   void notifyNodeDown(long eventTime, String nodeID);
 }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/JDBCUtils.java
----------------------------------------------------------------------
diff --git a/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/JDBCUtils.java b/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/JDBCUtils.java
index bbe4865..33381de 100644
--- a/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/JDBCUtils.java
+++ b/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/JDBCUtils.java
@@ -117,7 +117,8 @@ public class JDBCUtils {
          formatSqlException(errorMessage, nextEx);
          nextEx = exception.getNextException();
          level++;
-      } while (nextEx != null);
+      }
+      while (nextEx != null);
       return errorMessage;
    }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-jms-client/src/main/java/org/apache/activemq/artemis/api/jms/JMSFactoryType.java
----------------------------------------------------------------------
diff --git a/artemis-jms-client/src/main/java/org/apache/activemq/artemis/api/jms/JMSFactoryType.java b/artemis-jms-client/src/main/java/org/apache/activemq/artemis/api/jms/JMSFactoryType.java
index 3e99960..e3dfcf1 100644
--- a/artemis-jms-client/src/main/java/org/apache/activemq/artemis/api/jms/JMSFactoryType.java
+++ b/artemis-jms-client/src/main/java/org/apache/activemq/artemis/api/jms/JMSFactoryType.java
@@ -260,7 +260,7 @@ public enum JMSFactoryType {
     * @param groupConfiguration
     * @return the ActiveMQConnectionFactory
     */
-   public abstract ActiveMQConnectionFactory createConnectionFactoryWithHA(final DiscoveryGroupConfiguration groupConfiguration);
+   public abstract ActiveMQConnectionFactory createConnectionFactoryWithHA(DiscoveryGroupConfiguration groupConfiguration);
 
    /**
     * Create an ActiveMQConnectionFactory which creates session factories from a set of live servers, no HA backup information is propagated to the client
@@ -270,7 +270,7 @@ public enum JMSFactoryType {
     * @param groupConfiguration
     * @return the ActiveMQConnectionFactory
     */
-   public abstract ActiveMQConnectionFactory createConnectionFactoryWithoutHA(final DiscoveryGroupConfiguration groupConfiguration);
+   public abstract ActiveMQConnectionFactory createConnectionFactoryWithoutHA(DiscoveryGroupConfiguration groupConfiguration);
 
    /**
     * Create an ActiveMQConnectionFactory which will receive cluster topology updates from the cluster
@@ -287,7 +287,7 @@ public enum JMSFactoryType {
     *                       is made, the cluster topology is downloaded and the rest of the list is ignored.
     * @return the ActiveMQConnectionFactory
     */
-   public abstract ActiveMQConnectionFactory createConnectionFactoryWithHA(final TransportConfiguration... initialServers);
+   public abstract ActiveMQConnectionFactory createConnectionFactoryWithHA(TransportConfiguration... initialServers);
 
    /**
     * Create an ActiveMQConnectionFactory which creates session factories using a static list of
@@ -299,7 +299,7 @@ public enum JMSFactoryType {
     * @param transportConfigurations
     * @return the ActiveMQConnectionFactory
     */
-   public abstract ActiveMQConnectionFactory createConnectionFactoryWithoutHA(final TransportConfiguration... transportConfigurations);
+   public abstract ActiveMQConnectionFactory createConnectionFactoryWithoutHA(TransportConfiguration... transportConfigurations);
 
    /**
     * Returns the connection factory interface that this JMSFactoryType creates.

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/bridge/impl/JMSBridgeImpl.java
----------------------------------------------------------------------
diff --git a/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/bridge/impl/JMSBridgeImpl.java b/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/bridge/impl/JMSBridgeImpl.java
index e06231a..c8d64fe 100644
--- a/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/bridge/impl/JMSBridgeImpl.java
+++ b/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/bridge/impl/JMSBridgeImpl.java
@@ -1314,7 +1314,8 @@ public final class JMSBridgeImpl implements JMSBridge {
                ActiveMQJMSBridgeLogger.LOGGER.warn(e.getMessage() + ", retrying TX", e);
                exHappened = true;
             }
-         } while (exHappened);
+         }
+         while (exHappened);
 
          if (maxBatchSize > 1) {
             // The sending session is transacted - we need to commit it

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/JMSServerConfigParser.java
----------------------------------------------------------------------
diff --git a/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/JMSServerConfigParser.java b/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/JMSServerConfigParser.java
index 3ca65fe..e1c5554 100644
--- a/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/JMSServerConfigParser.java
+++ b/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/JMSServerConfigParser.java
@@ -28,12 +28,12 @@ public interface JMSServerConfigParser {
    /**
     * Parse the JMS Configuration XML as a JMSConfiguration object
     */
-   JMSConfiguration parseConfiguration(final InputStream stream) throws Exception;
+   JMSConfiguration parseConfiguration(InputStream stream) throws Exception;
 
    /**
     * Parse the JMS Configuration XML as a JMSConfiguration object
     */
-   JMSConfiguration parseConfiguration(final Node rootnode) throws Exception;
+   JMSConfiguration parseConfiguration(Node rootnode) throws Exception;
 
    /**
     * Parse the topic node as a TopicConfiguration object
@@ -42,7 +42,7 @@ public interface JMSServerConfigParser {
     * @return {@link TopicConfiguration} parsed from the node
     * @throws Exception
     */
-   TopicConfiguration parseTopicConfiguration(final Node node) throws Exception;
+   TopicConfiguration parseTopicConfiguration(Node node) throws Exception;
 
    /**
     * Parse the Queue Configuration node as a QueueConfiguration object
@@ -51,5 +51,5 @@ public interface JMSServerConfigParser {
     * @return {@link JMSQueueConfiguration} parsed from the node
     * @throws Exception
     */
-   JMSQueueConfiguration parseQueueConfiguration(final Node node) throws Exception;
+   JMSQueueConfiguration parseQueueConfiguration(Node node) throws Exception;
 }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/JMSServerManager.java
----------------------------------------------------------------------
diff --git a/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/JMSServerManager.java b/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/JMSServerManager.java
index ec95324..6df68f3 100644
--- a/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/JMSServerManager.java
+++ b/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/JMSServerManager.java
@@ -60,11 +60,11 @@ public interface JMSServerManager extends ActiveMQComponent {
                        boolean durable,
                        String... bindings) throws Exception;
 
-   boolean addTopicToBindingRegistry(final String topicName, final String binding) throws Exception;
+   boolean addTopicToBindingRegistry(String topicName, String binding) throws Exception;
 
-   boolean addQueueToBindingRegistry(final String queueName, final String binding) throws Exception;
+   boolean addQueueToBindingRegistry(String queueName, String binding) throws Exception;
 
-   boolean addConnectionFactoryToBindingRegistry(final String name, final String binding) throws Exception;
+   boolean addConnectionFactoryToBindingRegistry(String name, String binding) throws Exception;
 
    /**
     * Creates a JMS Topic
@@ -306,7 +306,7 @@ public interface JMSServerManager extends ActiveMQComponent {
 
    void addSecurity(String addressMatch, Set<Role> roles);
 
-   Set<Role> getSecurity(final String addressMatch);
+   Set<Role> getSecurity(String addressMatch);
 
    BindingRegistry getRegistry();
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/Journal.java
----------------------------------------------------------------------
diff --git a/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/Journal.java b/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/Journal.java
index ca194b8..5c03611 100644
--- a/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/Journal.java
+++ b/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/Journal.java
@@ -98,12 +98,12 @@ public interface Journal extends ActiveMQComponent {
       appendUpdateRecord(id, recordType, EncoderPersister.getInstance(), record, sync, completionCallback);
    }
 
-   void appendUpdateRecord(final long id,
-                           final byte recordType,
-                           final Persister persister,
-                           final Object record,
-                           final boolean sync,
-                           final IOCompletion callback) throws Exception;
+   void appendUpdateRecord(long id,
+                           byte recordType,
+                           Persister persister,
+                           Object record,
+                           boolean sync,
+                           IOCompletion callback) throws Exception;
 
    void appendDeleteRecord(long id, boolean sync) throws Exception;
 
@@ -117,11 +117,11 @@ public interface Journal extends ActiveMQComponent {
       appendAddRecordTransactional(txID, id, recordType, EncoderPersister.getInstance(), record);
    }
 
-   void appendAddRecordTransactional(final long txID,
-                                     final long id,
-                                     final byte recordType,
-                                     final Persister persister,
-                                     final Object record) throws Exception;
+   void appendAddRecordTransactional(long txID,
+                                     long id,
+                                     byte recordType,
+                                     Persister persister,
+                                     Object record) throws Exception;
 
    void appendUpdateRecordTransactional(long txID, long id, byte recordType, byte[] record) throws Exception;
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-journal/src/main/java/org/apache/activemq/artemis/journal/ActiveMQJournalLogger.java
----------------------------------------------------------------------
diff --git a/artemis-journal/src/main/java/org/apache/activemq/artemis/journal/ActiveMQJournalLogger.java b/artemis-journal/src/main/java/org/apache/activemq/artemis/journal/ActiveMQJournalLogger.java
index db131cf..5e5ad55 100644
--- a/artemis-journal/src/main/java/org/apache/activemq/artemis/journal/ActiveMQJournalLogger.java
+++ b/artemis-journal/src/main/java/org/apache/activemq/artemis/journal/ActiveMQJournalLogger.java
@@ -271,7 +271,7 @@ public interface ActiveMQJournalLogger extends BasicLogger {
 
    @LogMessage(level = Logger.Level.ERROR)
    @Message(id = 144006, value = "IOError code {0}, {1}", format = Message.Format.MESSAGE_FORMAT)
-   void ioError(final int errorCode, final String errorMessage);
+   void ioError(int errorCode, String errorMessage);
 
    @LogMessage(level = Logger.Level.WARN)
    @Message(id = 144007, value = "Ignoring journal file {0}: file is shorter then minimum header size. This file is being removed.", format = Message.Format.MESSAGE_FORMAT)

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompProtocolManager.java
----------------------------------------------------------------------
diff --git a/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompProtocolManager.java b/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompProtocolManager.java
index 365f373..181891a 100644
--- a/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompProtocolManager.java
+++ b/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompProtocolManager.java
@@ -163,7 +163,8 @@ public class StompProtocolManager extends AbstractProtocolManager<StompFrame, St
          } finally {
             server.getStorageManager().clearContext();
          }
-      } while (conn.hasBytes());
+      }
+      while (conn.hasBytes());
    }
 
    @Override

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/Configuration.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/Configuration.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/Configuration.java
index 7da5b02..aad3968 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/Configuration.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/Configuration.java
@@ -311,7 +311,7 @@ public interface Configuration {
     */
    Configuration setAcceptorConfigurations(Set<TransportConfiguration> infos);
 
-   Configuration addAcceptorConfiguration(final TransportConfiguration infos);
+   Configuration addAcceptorConfiguration(TransportConfiguration infos);
 
    /**
     * Add an acceptor to the config
@@ -335,9 +335,9 @@ public interface Configuration {
     */
    Configuration setConnectorConfigurations(Map<String, TransportConfiguration> infos);
 
-   Configuration addConnectorConfiguration(final String key, final TransportConfiguration info);
+   Configuration addConnectorConfiguration(String key, TransportConfiguration info);
 
-   Configuration addConnectorConfiguration(final String name, final String uri) throws Exception;
+   Configuration addConnectorConfiguration(String name, String uri) throws Exception;
 
    Configuration clearConnectorConfigurations();
 
@@ -351,7 +351,7 @@ public interface Configuration {
     */
    Configuration setBroadcastGroupConfigurations(List<BroadcastGroupConfiguration> configs);
 
-   Configuration addBroadcastGroupConfiguration(final BroadcastGroupConfiguration config);
+   Configuration addBroadcastGroupConfiguration(BroadcastGroupConfiguration config);
 
    /**
     * Returns the discovery groups configured for this server.
@@ -363,7 +363,7 @@ public interface Configuration {
     */
    Configuration setDiscoveryGroupConfigurations(Map<String, DiscoveryGroupConfiguration> configs);
 
-   Configuration addDiscoveryGroupConfiguration(final String key,
+   Configuration addDiscoveryGroupConfiguration(String key,
                                                 DiscoveryGroupConfiguration discoveryGroupConfiguration);
 
    /**
@@ -384,7 +384,7 @@ public interface Configuration {
    /**
     * Sets the bridges configured for this server.
     */
-   Configuration setBridgeConfigurations(final List<BridgeConfiguration> configs);
+   Configuration setBridgeConfigurations(List<BridgeConfiguration> configs);
 
    /**
     * Returns the diverts configured for this server.
@@ -394,9 +394,9 @@ public interface Configuration {
    /**
     * Sets the diverts configured for this server.
     */
-   Configuration setDivertConfigurations(final List<DivertConfiguration> configs);
+   Configuration setDivertConfigurations(List<DivertConfiguration> configs);
 
-   Configuration addDivertConfiguration(final DivertConfiguration config);
+   Configuration addDivertConfiguration(DivertConfiguration config);
 
    /**
     * Returns the cluster connections configured for this server.
@@ -409,9 +409,9 @@ public interface Configuration {
    /**
     * Sets the cluster connections configured for this server.
     */
-   Configuration setClusterConfigurations(final List<ClusterConnectionConfiguration> configs);
+   Configuration setClusterConfigurations(List<ClusterConnectionConfiguration> configs);
 
-   Configuration addClusterConfiguration(final ClusterConnectionConfiguration config);
+   Configuration addClusterConfiguration(ClusterConnectionConfiguration config);
 
    ClusterConnectionConfiguration addClusterConfiguration(String name, String uri) throws Exception;
 
@@ -425,9 +425,9 @@ public interface Configuration {
    /**
     * Sets the queues configured for this server.
     */
-   Configuration setQueueConfigurations(final List<CoreQueueConfiguration> configs);
+   Configuration setQueueConfigurations(List<CoreQueueConfiguration> configs);
 
-   Configuration addQueueConfiguration(final CoreQueueConfiguration config);
+   Configuration addQueueConfiguration(CoreQueueConfiguration config);
 
    /**
     * Returns the addresses configured for this server.
@@ -437,12 +437,12 @@ public interface Configuration {
    /**
     * Sets the addresses configured for this server.
     */
-   Configuration setAddressConfigurations(final List<CoreAddressConfiguration> configs);
+   Configuration setAddressConfigurations(List<CoreAddressConfiguration> configs);
 
    /**
     * Adds an addresses configuration
     */
-   Configuration addAddressConfiguration(final CoreAddressConfiguration config);
+   Configuration addAddressConfiguration(CoreAddressConfiguration config);
 
    /**
     * Returns the management address of this server. <br>
@@ -938,9 +938,9 @@ public interface Configuration {
 
    Configuration addConnectorServiceConfiguration(ConnectorServiceConfiguration config);
 
-   Configuration setSecuritySettingPlugins(final List<SecuritySettingPlugin> plugins);
+   Configuration setSecuritySettingPlugins(List<SecuritySettingPlugin> plugins);
 
-   Configuration addSecuritySettingPlugin(final SecuritySettingPlugin plugin);
+   Configuration addSecuritySettingPlugin(SecuritySettingPlugin plugin);
 
    /**
     * @return list of {@link ConnectorServiceConfiguration}

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/PageTransactionInfo.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/PageTransactionInfo.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/PageTransactionInfo.java
index ed42973..4fb49ea 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/PageTransactionInfo.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/PageTransactionInfo.java
@@ -45,10 +45,10 @@ public interface PageTransactionInfo extends EncodingSupport {
 
    void storeUpdate(StorageManager storageManager, PagingManager pagingManager, Transaction tx) throws Exception;
 
-   void reloadUpdate(final StorageManager storageManager,
-                     final PagingManager pagingManager,
-                     final Transaction tx,
-                     final int increment) throws Exception;
+   void reloadUpdate(StorageManager storageManager,
+                     PagingManager pagingManager,
+                     Transaction tx,
+                     int increment) throws Exception;
 
    // To be used after the update was stored or reload
    void onUpdate(int update, StorageManager storageManager, PagingManager pagingManager);

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/PagingStore.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/PagingStore.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/PagingStore.java
index 2d4c646..4dd8bf8 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/PagingStore.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/PagingStore.java
@@ -93,9 +93,9 @@ public interface PagingStore extends ActiveMQComponent, RefCountMessageListener
     */
    boolean page(Message message, Transaction tx, RouteContextList listCtx, ReadLock readLock) throws Exception;
 
-   Page createPage(final int page) throws Exception;
+   Page createPage(int page) throws Exception;
 
-   boolean checkPageFileExists(final int page) throws Exception;
+   boolean checkPageFileExists(int page) throws Exception;
 
    PagingManager getPagingManager();
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PageCursorProvider.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PageCursorProvider.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PageCursorProvider.java
index fd20952..29ce8a0 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PageCursorProvider.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PageCursorProvider.java
@@ -31,7 +31,7 @@ public interface PageCursorProvider {
 
    PageCache getPageCache(long pageNr);
 
-   PagedReference newReference(final PagePosition pos, final PagedMessage msg, PageSubscription sub);
+   PagedReference newReference(PagePosition pos, PagedMessage msg, PageSubscription sub);
 
    void addPageCache(PageCache cache);
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PageSubscription.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PageSubscription.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PageSubscription.java
index 93e2a84..ee05f61 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PageSubscription.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PageSubscription.java
@@ -64,7 +64,7 @@ public interface PageSubscription {
 
    void scheduleCleanupCheck();
 
-   void cleanupEntries(final boolean completeDelete) throws Exception;
+   void cleanupEntries(boolean completeDelete) throws Exception;
 
    void onPageModeCleared(Transaction tx) throws Exception;
 
@@ -118,7 +118,7 @@ public interface PageSubscription {
 
    void processReload() throws Exception;
 
-   void addPendingDelivery(final PagePosition position);
+   void addPendingDelivery(PagePosition position);
 
    /**
     * To be used on redeliveries

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PageSubscriptionCounter.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PageSubscriptionCounter.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PageSubscriptionCounter.java
index 2e1d7b6..37cdb3b 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PageSubscriptionCounter.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PageSubscriptionCounter.java
@@ -28,9 +28,9 @@ public interface PageSubscriptionCounter {
 
    void increment(Transaction tx, int add) throws Exception;
 
-   void loadValue(final long recordValueID, final long value);
+   void loadValue(long recordValueID, long value);
 
-   void loadInc(final long recordInd, final int add);
+   void loadInc(long recordInd, int add);
 
    void applyIncrementOnTX(Transaction tx, long recordID, int add);
 
@@ -54,6 +54,6 @@ public interface PageSubscriptionCounter {
    // for each queue on the address
    void delete(Transaction tx) throws Exception;
 
-   void cleanupNonTXCounters(final long pageID) throws Exception;
+   void cleanupNonTXCounters(long pageID) throws Exception;
 
 }
\ No newline at end of file

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java
index f346dc0..6ad4f48 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java
@@ -1257,7 +1257,8 @@ final class PageSubscriptionImpl implements PageSubscription {
                } else if (!browsing && ignored) {
                   positionIgnored(message.getPosition());
                }
-            } while (!match);
+            }
+            while (!match);
 
             if (message != null) {
                lastOperation = lastPosition;

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/StorageManager.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/StorageManager.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/StorageManager.java
index e27ed30..369dba6 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/StorageManager.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/StorageManager.java
@@ -246,7 +246,7 @@ public interface StorageManager extends IDGenerator, ActiveMQComponent {
     * @param extension the extension to add to the file
     * @return
     */
-   SequentialFile createFileForLargeMessage(final long messageID, LargeMessageExtension extension);
+   SequentialFile createFileForLargeMessage(long messageID, LargeMessageExtension extension);
 
    void prepare(long txID, Xid xid) throws Exception;
 
@@ -266,14 +266,14 @@ public interface StorageManager extends IDGenerator, ActiveMQComponent {
 
    void deletePageTransactional(long recordID) throws Exception;
 
-   JournalLoadInformation loadMessageJournal(final PostOffice postOffice,
-                                             final PagingManager pagingManager,
-                                             final ResourceManager resourceManager,
+   JournalLoadInformation loadMessageJournal(PostOffice postOffice,
+                                             PagingManager pagingManager,
+                                             ResourceManager resourceManager,
                                              Map<Long, QueueBindingInfo> queueInfos,
-                                             final Map<SimpleString, List<Pair<byte[], Long>>> duplicateIDMap,
-                                             final Set<Pair<Long, Long>> pendingLargeMessages,
+                                             Map<SimpleString, List<Pair<byte[], Long>>> duplicateIDMap,
+                                             Set<Pair<Long, Long>> pendingLargeMessages,
                                              List<PageCountPending> pendingNonTXPageCounter,
-                                             final JournalLoader journalLoader) throws Exception;
+                                             JournalLoader journalLoader) throws Exception;
 
    long storeHeuristicCompletion(Xid xid, boolean isCommit) throws Exception;
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/DuplicateIDCache.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/DuplicateIDCache.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/DuplicateIDCache.java
index 26920f8..b384896 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/DuplicateIDCache.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/DuplicateIDCache.java
@@ -25,7 +25,7 @@ public interface DuplicateIDCache {
 
    boolean contains(byte[] duplicateID);
 
-   boolean atomicVerify(final byte[] duplID, final Transaction tx) throws Exception;
+   boolean atomicVerify(byte[] duplID, Transaction tx) throws Exception;
 
    void addToCache(byte[] duplicateID) throws Exception;
 
@@ -42,7 +42,7 @@ public interface DuplicateIDCache {
 
    void load(List<Pair<byte[], Long>> theIds) throws Exception;
 
-   void load(final Transaction tx, final byte[] duplID);
+   void load(Transaction tx, byte[] duplID);
 
    void clear() throws Exception;
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/PostOffice.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/PostOffice.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/PostOffice.java
index f682777..a65e060 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/PostOffice.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/PostOffice.java
@@ -119,10 +119,10 @@ public interface PostOffice extends ActiveMQComponent {
    MessageReference reroute(Message message, Queue queue, Transaction tx) throws Exception;
 
    Pair<RoutingContext, Message> redistribute(Message message,
-                                                    final Queue originatingQueue,
+                                                    Queue originatingQueue,
                                                     Transaction tx) throws Exception;
 
-   void processRoute(final Message message, final RoutingContext context, final boolean direct) throws Exception;
+   void processRoute(Message message, RoutingContext context, boolean direct) throws Exception;
 
    DuplicateIDCache getDuplicateIDCache(SimpleString address);
 
@@ -133,7 +133,7 @@ public interface PostOffice extends ActiveMQComponent {
    // we can't start expiry scanner until the system is load otherwise we may get weird races - https://issues.jboss.org/browse/HORNETQ-1142
    void startExpiryScanner();
 
-   boolean isAddressBound(final SimpleString address) throws Exception;
+   boolean isAddressBound(SimpleString address) throws Exception;
 
    Set<SimpleString> getAddresses();
 }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/ConnectionCreator.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/ConnectionCreator.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/ConnectionCreator.java
index 6df028c..ab85d21 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/ConnectionCreator.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/ConnectionCreator.java
@@ -21,7 +21,7 @@ import io.netty.channel.ChannelHandlerContext;
 
 public interface ConnectionCreator extends ChannelHandler {
 
-   NettyServerConnection createConnection(final ChannelHandlerContext ctx,
+   NettyServerConnection createConnection(ChannelHandlerContext ctx,
                                           String protocol,
                                           boolean httpEnabled) throws Exception;
 }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/HttpAcceptorHandler.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/HttpAcceptorHandler.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/HttpAcceptorHandler.java
index a910941..22b162c 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/HttpAcceptorHandler.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/HttpAcceptorHandler.java
@@ -144,7 +144,8 @@ public class HttpAcceptorHandler extends ChannelDuplexHandler {
                   return;
                // otherwise ignore, we'll just try again
             }
-         } while (responseHolder == null);
+         }
+         while (responseHolder == null);
          if (!bogusResponse) {
             piggyBackResponses(responseHolder.response.content());
             responseHolder.response.headers().set(HttpHeaders.Names.CONTENT_LENGTH, String.valueOf(responseHolder.response.content().readableBytes()));
@@ -175,7 +176,8 @@ public class HttpAcceptorHandler extends ChannelDuplexHandler {
                } catch (InterruptedException e) {
                   break;
                }
-            } while (responses.isEmpty());
+            }
+            while (responses.isEmpty());
             return;
          }
          buf.writeBytes(buffer);

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-server/src/main/java/org/apache/activemq/artemis/core/replication/ReplicationManager.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/replication/ReplicationManager.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/replication/ReplicationManager.java
index 91dfa98..8a624ce 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/replication/ReplicationManager.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/replication/ReplicationManager.java
@@ -534,8 +534,8 @@ public final class ReplicationManager implements ActiveMQComponent {
       final ByteBuf buffer = PooledByteBufAllocator.DEFAULT.directBuffer(size, size);
 
       try {
-         try (final FileInputStream fis = new FileInputStream(file.getJavaFile());
-              final FileChannel channel = fis.getChannel()) {
+         try (FileInputStream fis = new FileInputStream(file.getJavaFile());
+              FileChannel channel = fis.getChannel()) {
             // We can afford having a single buffer here for this entire loop
             // because sendReplicatePacket will encode the packet as a NettyBuffer
             // through ActiveMQBuffer class leaving this buffer free to be reused on the next copy

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-server/src/main/java/org/apache/activemq/artemis/core/security/CheckType.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/security/CheckType.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/security/CheckType.java
index 92e92df..c4bd705 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/security/CheckType.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/security/CheckType.java
@@ -78,5 +78,5 @@ public enum CheckType {
       }
    };
 
-   public abstract boolean hasRole(final Role role);
+   public abstract boolean hasRole(Role role);
 }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServer.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServer.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServer.java
index e16557f..42ba7a2 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServer.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServer.java
@@ -296,14 +296,14 @@ public interface ActiveMQServer extends ServiceComponent {
     * @throws org.apache.activemq.artemis.api.core.ActiveMQInvalidTransientQueueUseException if the shared queue already exists with a different {@code address} or {@code filterString}
     * @throws NullPointerException                                                           if {@code address} is {@code null}
     */
-   void createSharedQueue(final SimpleString address, final RoutingType routingType, final SimpleString name, final SimpleString filterString,
-                          final SimpleString user, boolean durable) throws Exception;
+   void createSharedQueue(SimpleString address, RoutingType routingType, SimpleString name, SimpleString filterString,
+                          SimpleString user, boolean durable) throws Exception;
 
    Queue createQueue(SimpleString address, RoutingType routingType, SimpleString queueName, SimpleString filter,
                      boolean durable, boolean temporary) throws Exception;
 
-   Queue createQueue(final SimpleString address, final RoutingType routingType, final SimpleString queueName, final SimpleString user,
-                               final SimpleString filterString,  final boolean durable, final boolean temporary) throws Exception;
+   Queue createQueue(SimpleString address, RoutingType routingType, SimpleString queueName, SimpleString user,
+                               SimpleString filterString,  boolean durable, boolean temporary) throws Exception;
 
    Queue createQueue(SimpleString address, RoutingType routingType, SimpleString queueName, SimpleString filter,
                      boolean durable, boolean temporary, int maxConsumers, boolean purgeOnNoConsumers,

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/Queue.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/Queue.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/Queue.java
index 3404639..541b4d8 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/Queue.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/Queue.java
@@ -87,15 +87,15 @@ public interface Queue extends Bindable {
 
    void addHead(MessageReference ref, boolean scheduling);
 
-   void addHead(final List<MessageReference> refs, boolean scheduling);
+   void addHead(List<MessageReference> refs, boolean scheduling);
 
    void acknowledge(MessageReference ref) throws Exception;
 
-   void acknowledge(final MessageReference ref, AckReason reason) throws Exception;
+   void acknowledge(MessageReference ref, AckReason reason) throws Exception;
 
    void acknowledge(Transaction tx, MessageReference ref) throws Exception;
 
-   void acknowledge(final Transaction tx, final MessageReference ref, AckReason reason) throws Exception;
+   void acknowledge(Transaction tx, MessageReference ref, AckReason reason) throws Exception;
 
    void reacknowledge(Transaction tx, MessageReference ref) throws Exception;
 
@@ -152,7 +152,7 @@ public interface Queue extends Bindable {
 
    int deleteAllReferences() throws Exception;
 
-   int deleteAllReferences(final int flushLimit) throws Exception;
+   int deleteAllReferences(int flushLimit) throws Exception;
 
    boolean deleteReference(long messageID) throws Exception;
 
@@ -175,7 +175,7 @@ public interface Queue extends Bindable {
 
    int sendMessagesToDeadLetterAddress(Filter filter) throws Exception;
 
-   void sendToDeadLetterAddress(final Transaction tx, final MessageReference ref) throws Exception;
+   void sendToDeadLetterAddress(Transaction tx, MessageReference ref) throws Exception;
 
    boolean changeReferencePriority(long messageID, byte newPriority) throws Exception;
 
@@ -187,7 +187,7 @@ public interface Queue extends Bindable {
 
    int moveReferences(Filter filter, SimpleString toAddress) throws Exception;
 
-   int moveReferences(final int flushLimit,
+   int moveReferences(int flushLimit,
                       Filter filter,
                       SimpleString toAddress,
                       boolean rejectDuplicates) throws Exception;

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/QueueFactory.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/QueueFactory.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/QueueFactory.java
index 2557b73..c2aeba4 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/QueueFactory.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/QueueFactory.java
@@ -29,14 +29,14 @@ import org.apache.activemq.artemis.core.postoffice.PostOffice;
  */
 public interface QueueFactory {
 
-   Queue createQueueWith(final QueueConfig config) throws Exception;
+   Queue createQueueWith(QueueConfig config) throws Exception;
 
    /**
     * @deprecated Replaced by {@link #createQueueWith}
     */
    @Deprecated
    Queue createQueue(long persistenceID,
-                     final SimpleString address,
+                     SimpleString address,
                      SimpleString name,
                      Filter filter,
                      PageSubscription pageSubscription,

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ScheduledDeliveryHandler.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ScheduledDeliveryHandler.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ScheduledDeliveryHandler.java
index 460e135..62fad5e 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ScheduledDeliveryHandler.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ScheduledDeliveryHandler.java
@@ -23,7 +23,7 @@ import org.apache.activemq.artemis.core.filter.Filter;
 
 public interface ScheduledDeliveryHandler {
 
-   boolean checkAndSchedule(MessageReference ref, final boolean tail);
+   boolean checkAndSchedule(MessageReference ref, boolean tail);
 
    int getScheduledCount();
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ServerConsumer.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ServerConsumer.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ServerConsumer.java
index 37232bc..2fd5a1e 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ServerConsumer.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ServerConsumer.java
@@ -92,9 +92,9 @@ public interface ServerConsumer extends Consumer {
 
    void individualAcknowledge(Transaction tx, long messageID) throws Exception;
 
-   void reject(final long messageID) throws Exception;
+   void reject(long messageID) throws Exception;
 
-   void individualCancel(final long messageID, boolean failed) throws Exception;
+   void individualCancel(long messageID, boolean failed) throws Exception;
 
    void forceDelivery(long sequence);
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ServerSession.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ServerSession.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ServerSession.java
index 0ce0728..7980e6e 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ServerSession.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ServerSession.java
@@ -60,7 +60,7 @@ public interface ServerSession extends SecurityAuth {
 
    void individualAcknowledge(long consumerID, long messageID) throws Exception;
 
-   void individualCancel(final long consumerID, final long messageID, boolean failed) throws Exception;
+   void individualCancel(long consumerID, long messageID, boolean failed) throws Exception;
 
    void expire(long consumerID, long messageID) throws Exception;
 
@@ -149,13 +149,13 @@ public interface ServerSession extends SecurityAuth {
                      boolean durable,
                      boolean autoCreated) throws Exception;
 
-   AddressInfo createAddress(final SimpleString address,
+   AddressInfo createAddress(SimpleString address,
                              Set<RoutingType> routingTypes,
-                             final boolean autoCreated) throws Exception;
+                             boolean autoCreated) throws Exception;
 
-   AddressInfo createAddress(final SimpleString address,
+   AddressInfo createAddress(SimpleString address,
                              RoutingType routingType,
-                             final boolean autoCreated) throws Exception;
+                             boolean autoCreated) throws Exception;
 
    void deleteQueue(SimpleString name) throws Exception;
 
@@ -164,12 +164,12 @@ public interface ServerSession extends SecurityAuth {
                                  SimpleString filterString,
                                  boolean browseOnly) throws Exception;
 
-   ServerConsumer createConsumer(final long consumerID,
-                                 final SimpleString queueName,
-                                 final SimpleString filterString,
-                                 final boolean browseOnly,
-                                 final boolean supportLargeMessage,
-                                 final Integer credits) throws Exception;
+   ServerConsumer createConsumer(long consumerID,
+                                 SimpleString queueName,
+                                 SimpleString filterString,
+                                 boolean browseOnly,
+                                 boolean supportLargeMessage,
+                                 Integer credits) throws Exception;
 
    QueueQueryResult executeQueueQuery(SimpleString name) throws Exception;
 
@@ -186,11 +186,11 @@ public interface ServerSession extends SecurityAuth {
                       boolean direct,
                       boolean noAutoCreateQueue) throws Exception;
 
-   RoutingStatus doSend(final Transaction tx,
-                        final Message msg,
-                        final SimpleString originalAddress,
-                        final boolean direct,
-                        final boolean noAutoCreateQueue) throws Exception;
+   RoutingStatus doSend(Transaction tx,
+                        Message msg,
+                        SimpleString originalAddress,
+                        boolean direct,
+                        boolean noAutoCreateQueue) throws Exception;
 
    RoutingStatus send(Message message, boolean direct, boolean noAutoCreateQueue) throws Exception;
 
@@ -239,7 +239,7 @@ public interface ServerSession extends SecurityAuth {
 
    void createSharedQueue(SimpleString address,
                           SimpleString name,
-                          final RoutingType routingType,
+                          RoutingType routingType,
                           boolean durable,
                           SimpleString filterString) throws Exception;
 


Mime
View raw message