activemq-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuco...@apache.org
Subject [1/3] activemq-artemis git commit: ARTEMIS-1189 - Fix checkstyle violations post checkstyle upgrade
Date Tue, 30 May 2017 17:40:27 GMT
Repository: activemq-artemis
Updated Branches:
  refs/heads/master e8cd6b503 -> cd5f508d6


http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/qourum/Vote.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/qourum/Vote.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/qourum/Vote.java
index 916c63e..b41af2b 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/qourum/Vote.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/qourum/Vote.java
@@ -31,9 +31,9 @@ public abstract class Vote<T> {
       return map;
    }
 
-   public abstract void encode(final ActiveMQBuffer buff);
+   public abstract void encode(ActiveMQBuffer buff);
 
-   public abstract void decode(final ActiveMQBuffer buff);
+   public abstract void decode(ActiveMQBuffer buff);
 
    //whether or note we should ask the target server for an answer or decide ourselves, for instance if we couldn't
    //connect to the node in the first place.

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/group/impl/RemoteGroupingHandler.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/group/impl/RemoteGroupingHandler.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/group/impl/RemoteGroupingHandler.java
index bd1d931..c80f612 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/group/impl/RemoteGroupingHandler.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/group/impl/RemoteGroupingHandler.java
@@ -157,7 +157,8 @@ public final class RemoteGroupingHandler extends GroupHandlingAbstract {
             if (response != null) {
                break;
             }
-         } while (timeLimit > System.currentTimeMillis());
+         }
+         while (timeLimit > System.currentTimeMillis());
       } finally {
          if (notification != null) {
             pendingNotifications.remove(notification);

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/FileLockNodeManager.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/FileLockNodeManager.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/FileLockNodeManager.java
index 09f9fc3..2b4e2cb 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/FileLockNodeManager.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/FileLockNodeManager.java
@@ -139,7 +139,8 @@ public class FileLockNodeManager extends NodeManager {
             logger.debug("acquired live node lock state = " + (char) state);
             break;
          }
-      } while (true);
+      }
+      while (true);
    }
 
    @Override
@@ -317,7 +318,8 @@ public class FileLockNodeManager extends NodeManager {
             interrupted = false;
             throw new IOException("Lock was interrupted");
          }
-      } while (lock == null);
+      }
+      while (lock == null);
       return lock;
    }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/InVMNodeManager.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/InVMNodeManager.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/InVMNodeManager.java
index ade3480..63fac28 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/InVMNodeManager.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/InVMNodeManager.java
@@ -84,7 +84,8 @@ public final class InVMNodeManager extends NodeManager {
          } else if (state == LIVE) {
             break;
          }
-      } while (true);
+      }
+      while (true);
       if (failoverPause > 0L) {
          Thread.sleep(failoverPause);
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerConsumerImpl.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerConsumerImpl.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerConsumerImpl.java
index 4ace4d4..296088b 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerConsumerImpl.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerConsumerImpl.java
@@ -845,7 +845,8 @@ public class ServerConsumerImpl implements ServerConsumer, ReadyListener {
             ref.acknowledge(tx);
 
             acks++;
-         } while (ref.getMessage().getMessageID() != messageID);
+         }
+         while (ref.getMessage().getMessageID() != messageID);
 
          if (startedTransaction) {
             tx.commit();

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/SharedNothingBackupActivation.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/SharedNothingBackupActivation.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/SharedNothingBackupActivation.java
index 58fe738..d45abe3 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/SharedNothingBackupActivation.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/SharedNothingBackupActivation.java
@@ -293,7 +293,8 @@ public final class SharedNothingBackupActivation extends Activation {
                replicationEndpoint.getChannel().close();
                replicationEndpoint.setChannel(null);
             }
-         } while (signal == SharedNothingBackupQuorum.BACKUP_ACTIVATION.ALREADY_REPLICATING);
+         }
+         while (signal == SharedNothingBackupQuorum.BACKUP_ACTIVATION.ALREADY_REPLICATING);
 
          if (logger.isTraceEnabled()) {
             logger.trace("Activation loop finished, current signal = " + signal);

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/management/ManagementService.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/management/ManagementService.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/management/ManagementService.java
index 29a2e47..528920f 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/management/ManagementService.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/management/ManagementService.java
@@ -68,29 +68,29 @@ public interface ManagementService extends NotificationService, ActiveMQComponen
 
    void setStorageManager(StorageManager storageManager);
 
-   ActiveMQServerControlImpl registerServer(final PostOffice postOffice,
-                                            final SecurityStore securityStore,
-                                            final StorageManager storageManager,
-                                            final Configuration configuration,
-                                            final HierarchicalRepository<AddressSettings> addressSettingsRepository,
-                                            final HierarchicalRepository<Set<Role>> securityRepository,
-                                            final ResourceManager resourceManager,
-                                            final RemotingService remotingService,
-                                            final ActiveMQServer messagingServer,
-                                            final QueueFactory queueFactory,
-                                            final ScheduledExecutorService scheduledThreadPool,
-                                            final PagingManager pagingManager,
-                                            final boolean backup) throws Exception;
+   ActiveMQServerControlImpl registerServer(PostOffice postOffice,
+                                            SecurityStore securityStore,
+                                            StorageManager storageManager,
+                                            Configuration configuration,
+                                            HierarchicalRepository<AddressSettings> addressSettingsRepository,
+                                            HierarchicalRepository<Set<Role>> securityRepository,
+                                            ResourceManager resourceManager,
+                                            RemotingService remotingService,
+                                            ActiveMQServer messagingServer,
+                                            QueueFactory queueFactory,
+                                            ScheduledExecutorService scheduledThreadPool,
+                                            PagingManager pagingManager,
+                                            boolean backup) throws Exception;
 
    void unregisterServer() throws Exception;
 
    void registerInJMX(ObjectName objectName, Object managedResource) throws Exception;
 
-   void unregisterFromJMX(final ObjectName objectName) throws Exception;
+   void unregisterFromJMX(ObjectName objectName) throws Exception;
 
    void registerInRegistry(String resourceName, Object managedResource);
 
-   void unregisterFromRegistry(final String resourceName);
+   void unregisterFromRegistry(String resourceName);
 
    void registerAddress(AddressInfo addressInfo) throws Exception;
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/protocol/ProtocolManager.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/protocol/ProtocolManager.java b/artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/protocol/ProtocolManager.java
index e29d74d..1770a5c 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/protocol/ProtocolManager.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/protocol/ProtocolManager.java
@@ -44,7 +44,7 @@ public interface ProtocolManager<P extends BaseInterceptor> {
 
    ConnectionEntry createConnectionEntry(Acceptor acceptorUsed, Connection connection);
 
-   void removeHandler(final String name);
+   void removeHandler(String name);
 
    void handleBuffer(RemotingConnection connection, ActiveMQBuffer buffer);
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/security/jaas/CertificateLoginModule.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/security/jaas/CertificateLoginModule.java b/artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/security/jaas/CertificateLoginModule.java
index 0625ba5..dcbd964 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/security/jaas/CertificateLoginModule.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/security/jaas/CertificateLoginModule.java
@@ -154,7 +154,7 @@ public abstract class CertificateLoginModule extends PropertiesLoader implements
     * @param certs The distinguished name.
     * @return The unique name if the certificate is recognized, null otherwise.
     */
-   protected abstract String getUserNameForCertificates(final X509Certificate[] certs) throws LoginException;
+   protected abstract String getUserNameForCertificates(X509Certificate[] certs) throws LoginException;
 
    /**
     * Should return a set of the roles this user belongs to. The roles
@@ -164,7 +164,7 @@ public abstract class CertificateLoginModule extends PropertiesLoader implements
     *                 getUserNameForDn returned for the user's DN.
     * @return A Set of the names of the roles this user belongs to.
     */
-   protected abstract Set<String> getUserRoles(final String username) throws LoginException;
+   protected abstract Set<String> getUserRoles(String username) throws LoginException;
 
    protected String getDistinguishedName(final X509Certificate[] certs) {
       if (certs != null && certs.length > 0 && certs[0] != null) {

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java b/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java
index 774b5f5..17f2d88 100644
--- a/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java
+++ b/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java
@@ -606,7 +606,8 @@ public abstract class ActiveMQTestBase extends Assert {
                break;
             }
          }
-      } while (i++ <= 200 && hasValue);
+      }
+      while (i++ <= 200 && hasValue);
 
       for (WeakReference<?> ref : references) {
          Assert.assertNull(ref.get());
@@ -1144,7 +1145,8 @@ public abstract class ActiveMQTestBase extends Assert {
          }
 
          Thread.sleep(10);
-      } while (System.currentTimeMillis() - start < timeout);
+      }
+      while (System.currentTimeMillis() - start < timeout);
 
       String msg = "Timed out waiting for cluster topology of live=" + liveNodes + ",backup=" + backupNodes +
          " (received live=" + liveNodesCount + ", backup=" + backupNodesCount +
@@ -1175,7 +1177,8 @@ public abstract class ActiveMQTestBase extends Assert {
          }
 
          Thread.sleep(10);
-      } while (System.currentTimeMillis() - start < timeout);
+      }
+      while (System.currentTimeMillis() - start < timeout);
 
       String msg = "Timed out waiting for cluster topology of " + nodes +
          " (received " +
@@ -1878,7 +1881,8 @@ public abstract class ActiveMQTestBase extends Assert {
          }
 
          Thread.sleep(10);
-      } while (System.currentTimeMillis() - start < timeout);
+      }
+      while (System.currentTimeMillis() - start < timeout);
 
       String msg = "Timed out waiting for bindings (bindingCount = " + bindingCount +
          " (expecting " +

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/artemis-service-extensions/src/main/java/org/apache/activemq/artemis/service/extensions/xa/recovery/ActiveMQRegistry.java
----------------------------------------------------------------------
diff --git a/artemis-service-extensions/src/main/java/org/apache/activemq/artemis/service/extensions/xa/recovery/ActiveMQRegistry.java b/artemis-service-extensions/src/main/java/org/apache/activemq/artemis/service/extensions/xa/recovery/ActiveMQRegistry.java
index f64c68b..7a86ae0 100644
--- a/artemis-service-extensions/src/main/java/org/apache/activemq/artemis/service/extensions/xa/recovery/ActiveMQRegistry.java
+++ b/artemis-service-extensions/src/main/java/org/apache/activemq/artemis/service/extensions/xa/recovery/ActiveMQRegistry.java
@@ -19,9 +19,9 @@ package org.apache.activemq.artemis.service.extensions.xa.recovery;
 
 public interface ActiveMQRegistry {
 
-   void register(final XARecoveryConfig resourceConfig);
+   void register(XARecoveryConfig resourceConfig);
 
-   void unRegister(final XARecoveryConfig resourceConfig);
+   void unRegister(XARecoveryConfig resourceConfig);
 
    void stop();
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/etc/checkstyle.xml
----------------------------------------------------------------------
diff --git a/etc/checkstyle.xml b/etc/checkstyle.xml
index c08f585..f695bef 100644
--- a/etc/checkstyle.xml
+++ b/etc/checkstyle.xml
@@ -46,9 +46,7 @@ under the License.
 
       <!-- Modifier Checks -->
       <module name="ModifierOrder"/>
-      <module name="RedundantModifier">
-         <property name="tokens" value="ANNOTATION_FIELD_DEF, INTERFACE_DEF, CLASS_DEF, ENUM_DEF"/>
-      </module>
+      <module name="RedundantModifier"/>
 
       <!-- Checks for common coding problems -->
       <module name="EmptyStatement"/>
@@ -73,7 +71,7 @@ under the License.
       <module name="RightCurly"/>
       <module name="RightCurly">
          <property name="option" value="alone"/>
-         <property name="tokens" value="CLASS_DEF, METHOD_DEF, CTOR_DEF, LITERAL_FOR, LITERAL_WHILE, STATIC_INIT, INSTANCE_INIT"/>
+         <property name="tokens" value="CLASS_DEF, METHOD_DEF, CTOR_DEF, LITERAL_FOR, LITERAL_WHILE, LITERAL_DO, STATIC_INIT, INSTANCE_INIT"/>
       </module>
       <!-- Checks that there is no whitespace after certain tokens; e.g. "." and "!". -->
       <module name="NoWhitespaceAfter"/>

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/tests/artemis-test-support/src/main/java/org/apache/activemq/transport/amqp/client/AmqpConnection.java
----------------------------------------------------------------------
diff --git a/tests/artemis-test-support/src/main/java/org/apache/activemq/transport/amqp/client/AmqpConnection.java b/tests/artemis-test-support/src/main/java/org/apache/activemq/transport/amqp/client/AmqpConnection.java
index a6959ac..84e7ba1 100644
--- a/tests/artemis-test-support/src/main/java/org/apache/activemq/transport/amqp/client/AmqpConnection.java
+++ b/tests/artemis-test-support/src/main/java/org/apache/activemq/transport/amqp/client/AmqpConnection.java
@@ -571,7 +571,8 @@ public class AmqpConnection extends AmqpAbstractResource<Connection> implements
                buffer.put(duplicate);
                protonTransport.processInput();
                source.position(source.position() + limit);
-            } while (source.hasRemaining());
+            }
+            while (source.hasRemaining());
 
             ReferenceCountUtil.release(incoming);
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/tests/artemis-test-support/src/main/java/org/apache/activemq/transport/amqp/client/AmqpReceiver.java
----------------------------------------------------------------------
diff --git a/tests/artemis-test-support/src/main/java/org/apache/activemq/transport/amqp/client/AmqpReceiver.java b/tests/artemis-test-support/src/main/java/org/apache/activemq/transport/amqp/client/AmqpReceiver.java
index c2c7217..e9fc75b 100644
--- a/tests/artemis-test-support/src/main/java/org/apache/activemq/transport/amqp/client/AmqpReceiver.java
+++ b/tests/artemis-test-support/src/main/java/org/apache/activemq/transport/amqp/client/AmqpReceiver.java
@@ -894,7 +894,8 @@ public class AmqpReceiver extends AmqpAbstractResource<Receiver> {
                }
             }
          }
-      } while (incoming != null);
+      }
+      while (incoming != null);
 
       super.processDeliveryUpdates(connection, delivery);
    }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/tests/extra-tests/src/test/java/org/apache/activemq/artemis/tests/extras/jms/ra/MDBMultipleHandlersServerDisconnectTest.java
----------------------------------------------------------------------
diff --git a/tests/extra-tests/src/test/java/org/apache/activemq/artemis/tests/extras/jms/ra/MDBMultipleHandlersServerDisconnectTest.java b/tests/extra-tests/src/test/java/org/apache/activemq/artemis/tests/extras/jms/ra/MDBMultipleHandlersServerDisconnectTest.java
index 2b6868f..5129253 100644
--- a/tests/extra-tests/src/test/java/org/apache/activemq/artemis/tests/extras/jms/ra/MDBMultipleHandlersServerDisconnectTest.java
+++ b/tests/extra-tests/src/test/java/org/apache/activemq/artemis/tests/extras/jms/ra/MDBMultipleHandlersServerDisconnectTest.java
@@ -380,7 +380,8 @@ public class MDBMultipleHandlersServerDisconnectTest extends ActiveMQRATestBase
                serverSessions.add(session);
             }
          }
-      } while (running.get() && serverSessions.size() != numberOfSessions && timeout > System.currentTimeMillis());
+      }
+      while (running.get() && serverSessions.size() != numberOfSessions && timeout > System.currentTimeMillis());
 
       System.err.println("Returning " + serverSessions.size() + " sessions");
       return serverSessions;

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/ConsumerWindowSizeTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/ConsumerWindowSizeTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/ConsumerWindowSizeTest.java
index b5ce930..5bd3ea0 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/ConsumerWindowSizeTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/ConsumerWindowSizeTest.java
@@ -1354,7 +1354,8 @@ public class ConsumerWindowSizeTest extends ActiveMQTestBase {
             foundB = consB.getBufferSize() == numberOfMessages / 2;
 
             Thread.sleep(10);
-         } while ((!foundA || !foundB) && System.currentTimeMillis() < timeout);
+         }
+         while ((!foundA || !foundB) && System.currentTimeMillis() < timeout);
 
          Assert.assertTrue("ConsumerA didn't receive the expected number of messages on buffer (consA=" + consA.getBufferSize() +
                               ", consB=" +

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/SlowConsumerTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/SlowConsumerTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/SlowConsumerTest.java
index 7552caa..a147d39 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/SlowConsumerTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/SlowConsumerTest.java
@@ -306,7 +306,8 @@ public class SlowConsumerTest extends ActiveMQTestBase {
             m.acknowledge();
             messagesConsumed++;
          }
-      } while (m != null);
+      }
+      while (m != null);
 
       assertEquals(messagesProduced.longValue(), messagesConsumed);
    }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/bridge/BridgeReconnectTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/bridge/BridgeReconnectTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/bridge/BridgeReconnectTest.java
index 4c18488..4a6fcaa 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/bridge/BridgeReconnectTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/bridge/BridgeReconnectTest.java
@@ -710,7 +710,8 @@ public class BridgeReconnectTest extends BridgeTestBase {
          }
 
          Thread.sleep(10);
-      } while (System.currentTimeMillis() - start < 50000);
+      }
+      while (System.currentTimeMillis() - start < 50000);
 
       throw new IllegalStateException("Failed to get forwarding connection");
    }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/ClusterTestBase.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/ClusterTestBase.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/ClusterTestBase.java
index c31f96f..4075cb5 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/ClusterTestBase.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/ClusterTestBase.java
@@ -279,7 +279,8 @@ public abstract class ClusterTestBase extends ActiveMQTestBase {
                break;
             }
             Thread.sleep(10);
-         } while (System.currentTimeMillis() - start < WAIT_TIMEOUT);
+         }
+         while (System.currentTimeMillis() - start < WAIT_TIMEOUT);
          if (!exists) {
             String msg = "Timed out waiting for cluster topology of " + Arrays.toString(nodes) +
                " (received " +
@@ -367,7 +368,8 @@ public abstract class ClusterTestBase extends ActiveMQTestBase {
          }
 
          Thread.sleep(10);
-      } while (System.currentTimeMillis() - start < ActiveMQTestBase.WAIT_TIMEOUT);
+      }
+      while (System.currentTimeMillis() - start < ActiveMQTestBase.WAIT_TIMEOUT);
 
       throw new IllegalStateException("Timed out waiting for messages (messageCount = " + messageCount +
                                          ", expecting = " +
@@ -1042,7 +1044,8 @@ public abstract class ClusterTestBase extends ActiveMQTestBase {
             } else {
                log.info("check receive Consumer " + consumerID + " null message");
             }
-         } while (message != null);
+         }
+         while (message != null);
 
       }
    }
@@ -1221,7 +1224,8 @@ public abstract class ClusterTestBase extends ActiveMQTestBase {
                   message.acknowledge();
                }
             }
-         } while (message != null);
+         }
+         while (message != null);
       }
 
       for (int messageCount : messageCounts) {
@@ -1313,7 +1317,8 @@ public abstract class ClusterTestBase extends ActiveMQTestBase {
 
             ints.add(count);
          }
-      } while (message != null);
+      }
+      while (message != null);
 
       int[] res = new int[ints.size()];
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/AsynchronousFailoverTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/AsynchronousFailoverTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/AsynchronousFailoverTest.java
index a40e2c0..c74e2f4 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/AsynchronousFailoverTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/AsynchronousFailoverTest.java
@@ -253,7 +253,8 @@ public class AsynchronousFailoverTest extends FailoverTestBase {
                } catch (ActiveMQException e) {
                   fail("Invalid Exception type:" + e.getType());
                }
-            } while (retry);
+            }
+            while (retry);
          }
 
          // create the consumer with retry if failover occurs during createConsumer call
@@ -272,7 +273,8 @@ public class AsynchronousFailoverTest extends FailoverTestBase {
             } catch (ActiveMQException e) {
                fail("Invalid Exception type:" + e.getType());
             }
-         } while (retry);
+         }
+         while (retry);
 
          session.start();
 
@@ -381,7 +383,8 @@ public class AsynchronousFailoverTest extends FailoverTestBase {
                   log.info("#test Exception " + e, e);
                   throw e;
                }
-            } while (retry);
+            }
+            while (retry);
 
             logAndSystemOut("#test Finished sending, starting consumption now");
 
@@ -481,7 +484,8 @@ public class AsynchronousFailoverTest extends FailoverTestBase {
                   logAndSystemOut(e.getMessage(), e);
                   throw e;
                }
-            } while (retry);
+            }
+            while (retry);
          } finally {
             if (session != null) {
                session.close();

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/ClusterWithBackupFailoverTestBase.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/ClusterWithBackupFailoverTestBase.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/ClusterWithBackupFailoverTestBase.java
index 3f4f4e7..745b84c 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/ClusterWithBackupFailoverTestBase.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/ClusterWithBackupFailoverTestBase.java
@@ -34,7 +34,7 @@ public abstract class ClusterWithBackupFailoverTestBase extends ClusterTestBase
    protected static final String QUEUES_TESTADDRESS = "queues.testaddress";
    private static final IntegrationTestLogger log = IntegrationTestLogger.LOGGER;
 
-   protected abstract void setupCluster(final MessageLoadBalancingType messageLoadBalancingType) throws Exception;
+   protected abstract void setupCluster(MessageLoadBalancingType messageLoadBalancingType) throws Exception;
 
    protected abstract void setupServers() throws Exception;
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/FailoverTestBase.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/FailoverTestBase.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/FailoverTestBase.java
index b08ceb1..2a42938 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/FailoverTestBase.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/FailoverTestBase.java
@@ -271,7 +271,7 @@ public abstract class FailoverTestBase extends ActiveMQTestBase {
 
    protected abstract TransportConfiguration getAcceptorTransportConfiguration(boolean live);
 
-   protected abstract TransportConfiguration getConnectorTransportConfiguration(final boolean live);
+   protected abstract TransportConfiguration getConnectorTransportConfiguration(boolean live);
 
    protected ServerLocatorInternal getServerLocator() throws Exception {
       return (ServerLocatorInternal) addServerLocator(ActiveMQClient.createServerLocatorWithHA(getConnectorTransportConfiguration(true), getConnectorTransportConfiguration(false))).setRetryInterval(50);

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/GroupingFailoverTestBase.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/GroupingFailoverTestBase.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/GroupingFailoverTestBase.java
index 0826077..41f0e8f 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/GroupingFailoverTestBase.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/GroupingFailoverTestBase.java
@@ -121,7 +121,8 @@ public abstract class GroupingFailoverTestBase extends ClusterTestBase {
          }
 
          Thread.sleep(10);
-      } while (System.currentTimeMillis() - start < ActiveMQTestBase.WAIT_TIMEOUT);
+      }
+      while (System.currentTimeMillis() - start < ActiveMQTestBase.WAIT_TIMEOUT);
 
       throw new IllegalStateException("Timed out waiting for backup announce");
    }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/MultipleServerFailoverTestBase.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/MultipleServerFailoverTestBase.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/MultipleServerFailoverTestBase.java
index bfbe5d5..9a33c57 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/MultipleServerFailoverTestBase.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/MultipleServerFailoverTestBase.java
@@ -239,7 +239,8 @@ public abstract class MultipleServerFailoverTestBase extends ActiveMQTestBase {
          }
 
          Thread.sleep(10);
-      } while (System.currentTimeMillis() - start < timeout);
+      }
+      while (System.currentTimeMillis() - start < timeout);
 
       throw new Exception();
    }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/MultiThreadReattachSupportTestBase.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/MultiThreadReattachSupportTestBase.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/MultiThreadReattachSupportTestBase.java
index 027e2b4..095b943 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/MultiThreadReattachSupportTestBase.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/MultiThreadReattachSupportTestBase.java
@@ -136,7 +136,8 @@ public abstract class MultiThreadReattachSupportTestBase extends ActiveMQTestBas
 
             runnable.checkFail();
 
-         } while (!failer.isExecuted());
+         }
+         while (!failer.isExecuted());
 
          InVMConnector.resetFailures();
 
@@ -189,7 +190,7 @@ public abstract class MultiThreadReattachSupportTestBase extends ActiveMQTestBas
          }
       }
 
-      public abstract void run(final ClientSessionFactory sf, final int threadNum) throws Exception;
+      public abstract void run(ClientSessionFactory sf, int threadNum) throws Exception;
    }
 
    private class Failer extends TimerTask {

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/RandomReattachTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/RandomReattachTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/RandomReattachTest.java
index 4d44334..303cbac 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/RandomReattachTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/RandomReattachTest.java
@@ -215,7 +215,8 @@ public class RandomReattachTest extends ActiveMQTestBase {
 
          do {
             runnable.run(sf);
-         } while (!failer.isExecuted());
+         }
+         while (!failer.isExecuted());
       }
    }
 
@@ -1290,7 +1291,7 @@ public class RandomReattachTest extends ActiveMQTestBase {
 
    public abstract class RunnableT {
 
-      abstract void run(final ClientSessionFactory sf) throws Exception;
+      abstract void run(ClientSessionFactory sf) throws Exception;
    }
 
    abstract static class AssertionCheckMessageHandler implements MessageHandler {

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/topology/TopologyClusterTestBase.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/topology/TopologyClusterTestBase.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/topology/TopologyClusterTestBase.java
index 82bdf32..b2453d8 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/topology/TopologyClusterTestBase.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/topology/TopologyClusterTestBase.java
@@ -135,7 +135,8 @@ public abstract class TopologyClusterTestBase extends ClusterTestBase {
          if (ok) {
             return;
          }
-      } while (System.currentTimeMillis() - start < 5000);
+      }
+      while (System.currentTimeMillis() - start < 5000);
       Assert.fail("did not contain all expected node ID: " + actual);
    }
 
@@ -191,7 +192,8 @@ public abstract class TopologyClusterTestBase extends ClusterTestBase {
          }
 
          Thread.sleep(10);
-      } while (System.currentTimeMillis() - start < ActiveMQTestBase.WAIT_TIMEOUT);
+      }
+      while (System.currentTimeMillis() - start < ActiveMQTestBase.WAIT_TIMEOUT);
 
       log.error(clusterDescription(servers[node]));
       Assert.assertEquals("Timed out waiting for cluster connections for server " + node, expected, nodesCount);

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/cluster/BindingsClusterTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/cluster/BindingsClusterTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/cluster/BindingsClusterTest.java
index 982c7d3..ba3e507 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/cluster/BindingsClusterTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/cluster/BindingsClusterTest.java
@@ -449,7 +449,8 @@ public class BindingsClusterTest extends JMSClusteredTestBase {
          }
 
          Thread.sleep(10);
-      } while (System.currentTimeMillis() - start < 50000);
+      }
+      while (System.currentTimeMillis() - start < 50000);
 
       throw new IllegalStateException("Failed to get forwarding connection");
    }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/cluster/JMSFailoverTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/cluster/JMSFailoverTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/cluster/JMSFailoverTest.java
index 31ca772..4b4e89b 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/cluster/JMSFailoverTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/cluster/JMSFailoverTest.java
@@ -419,7 +419,8 @@ public class JMSFailoverTest extends ActiveMQTestBase {
             } catch (JMSException e) {
                new Exception("Exception on receive message", e).printStackTrace();
             }
-         } while (retryNrs < 10);
+         }
+         while (retryNrs < 10);
 
          assertNotNull(message);
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/management/JMSUtil.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/management/JMSUtil.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/management/JMSUtil.java
index a96d876..e8af049 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/management/JMSUtil.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/management/JMSUtil.java
@@ -331,7 +331,8 @@ public class JMSUtil {
                break;
             }
             Thread.sleep(10);
-         } while (System.currentTimeMillis() - start < timeToWait);
+         }
+         while (System.currentTimeMillis() - start < timeToWait);
          if (!exists) {
             String msg = "Timed out waiting for cluster topology of " + backupServer +
                " (received " +

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/NotificationTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/NotificationTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/NotificationTest.java
index 2e99da2..e0e6f4c 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/NotificationTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/NotificationTest.java
@@ -231,7 +231,8 @@ public class NotificationTest extends ActiveMQTestBase {
       ClientMessage message = null;
       do {
          message = notifConsumer.receive(500);
-      } while (message != null);
+      }
+      while (message != null);
    }
 
    protected static ClientMessage[] consumeMessages(final int expected,

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/SecurityNotificationTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/SecurityNotificationTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/SecurityNotificationTest.java
index a5f8ec5..13208fc 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/SecurityNotificationTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/SecurityNotificationTest.java
@@ -159,7 +159,8 @@ public class SecurityNotificationTest extends ActiveMQTestBase {
       ClientMessage message = null;
       do {
          message = notifConsumer.receive(500);
-      } while (message != null);
+      }
+      while (message != null);
    }
 
    protected static ClientMessage[] consumeMessages(final int expected,

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt/imported/MQTTTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt/imported/MQTTTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt/imported/MQTTTest.java
index 09477f3..3026f97 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt/imported/MQTTTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt/imported/MQTTTest.java
@@ -465,7 +465,8 @@ public class MQTTTest extends MQTTTestSupport {
             assertTrue("RETAINED matching " + wildcard + " " + msg.getTopic(), pattern.matcher(msg.getTopic()).matches());
             msg.ack();
             msg = connection.receive(5000, TimeUnit.MILLISECONDS);
-         } while (msg != null);
+         }
+         while (msg != null);
 
          // test non-retained message
          for (String topic : topics) {
@@ -477,7 +478,8 @@ public class MQTTTest extends MQTTTestSupport {
             assertTrue("Non-retained matching " + wildcard + " " + msg.getTopic(), pattern.matcher(msg.getTopic()).matches());
             msg.ack();
             msg = connection.receive(1000, TimeUnit.MILLISECONDS);
-         } while (msg != null);
+         }
+         while (msg != null);
 
          connection.unsubscribe(new String[]{wildcard});
          connection.disconnect();
@@ -769,7 +771,8 @@ public class MQTTTest extends MQTTTestSupport {
             waitCount++;
          }
          msg = connection.receive(5000, TimeUnit.MILLISECONDS);
-      } while (msg != null && received++ < subs.length * 2);
+      }
+      while (msg != null && received++ < subs.length * 2);
       assertEquals("Unexpected number of messages", subs.length * 2, received + 1);
 
       // make sure we received distinct ids for QoS != AT_MOST_ONCE, and 0 for
@@ -928,7 +931,8 @@ public class MQTTTest extends MQTTTestSupport {
             assertEquals(TOPIC, new String(msg.getPayload()));
             msg.ack();
          }
-      } while (msg != null);
+      }
+      while (msg != null);
 
       // make sure we received all message ids
       for (short id = 1; id <= TOTAL_MESSAGES; id++) {

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/ExpiryRunnerTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/ExpiryRunnerTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/ExpiryRunnerTest.java
index d4a4154..fa04395 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/ExpiryRunnerTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/ExpiryRunnerTest.java
@@ -183,7 +183,8 @@ public class ExpiryRunnerTest extends ActiveMQTestBase {
          m.setExpiration(expiration);
          producer.send(m);
          Thread.sleep(100);
-      } while (System.currentTimeMillis() < sendMessagesUntil);
+      }
+      while (System.currentTimeMillis() < sendMessagesUntil);
       Assert.assertTrue(latch.await(10000, TimeUnit.MILLISECONDS));
       consumer.close();
 
@@ -197,7 +198,8 @@ public class ExpiryRunnerTest extends ActiveMQTestBase {
          cm.acknowledge();
          Assert.assertFalse(dummyMessageHandler.payloads.contains(text));
          dummyMessageHandler.payloads.add(text);
-      } while (true);
+      }
+      while (true);
 
       for (int i = 0; i < numMessages; i++) {
          if (dummyMessageHandler.payloads.isEmpty()) {

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/tools/container/Server.java
----------------------------------------------------------------------
diff --git a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/tools/container/Server.java b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/tools/container/Server.java
index 7d21289..e94976a 100644
--- a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/tools/container/Server.java
+++ b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/tools/container/Server.java
@@ -144,27 +144,27 @@ public interface Server extends Remote {
                                 boolean supportsLoadBalancing,
                                 int dupsOkBatchSize,
                                 boolean blockOnAcknowledge,
-                                final String... jndiBindings) throws Exception;
+                                String... jndiBindings) throws Exception;
 
    void deployConnectionFactory(String objectName,
                                 int prefetchSize,
                                 int defaultTempQueueFullSize,
                                 int defaultTempQueuePageSize,
                                 int defaultTempQueueDownCacheSize,
-                                final String... jndiBindings) throws Exception;
+                                String... jndiBindings) throws Exception;
 
    void deployConnectionFactory(String objectName,
                                 boolean supportsFailover,
                                 boolean supportsLoadBalancing,
-                                final String... jndiBindings) throws Exception;
+                                String... jndiBindings) throws Exception;
 
-   void deployConnectionFactory(String clientID, String objectName, final String... jndiBindings) throws Exception;
+   void deployConnectionFactory(String clientID, String objectName, String... jndiBindings) throws Exception;
 
-   void deployConnectionFactory(String objectName, int prefetchSize, final String... jndiBindings) throws Exception;
+   void deployConnectionFactory(String objectName, int prefetchSize, String... jndiBindings) throws Exception;
 
-   void deployConnectionFactory(String objectName, final String... jndiBindings) throws Exception;
+   void deployConnectionFactory(String objectName, String... jndiBindings) throws Exception;
 
-   void deployConnectionFactory(String objectName, JMSFactoryType type, final String... jndiBindings) throws Exception;
+   void deployConnectionFactory(String objectName, JMSFactoryType type, String... jndiBindings) throws Exception;
 
    void undeployConnectionFactory(String objectName) throws Exception;
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/paging/PageStressTest.java
----------------------------------------------------------------------
diff --git a/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/paging/PageStressTest.java b/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/paging/PageStressTest.java
index a439587..0d07549 100644
--- a/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/paging/PageStressTest.java
+++ b/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/paging/PageStressTest.java
@@ -91,7 +91,8 @@ public class PageStressTest extends ActiveMQTestBase {
                System.out.println("Received " + msgs);
             }
          }
-      } while (msg != null);
+      }
+      while (msg != null);
 
       session.commit();
 
@@ -122,7 +123,8 @@ public class PageStressTest extends ActiveMQTestBase {
                System.out.println("Received " + msgs);
             }
          }
-      } while (msg != null);
+      }
+      while (msg != null);
 
       System.out.println("msgs second time: " + msgs);
 
@@ -208,7 +210,8 @@ public class PageStressTest extends ActiveMQTestBase {
 
             }
          }
-      } while (msg != null);
+      }
+      while (msg != null);
 
       session.commit();
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c65ea783/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/journal/impl/fakes/FakeSequentialFileFactory.java
----------------------------------------------------------------------
diff --git a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/journal/impl/fakes/FakeSequentialFileFactory.java b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/journal/impl/fakes/FakeSequentialFileFactory.java
index 1f933fb..192454e 100644
--- a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/journal/impl/fakes/FakeSequentialFileFactory.java
+++ b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/journal/impl/fakes/FakeSequentialFileFactory.java
@@ -221,7 +221,7 @@ public class FakeSequentialFileFactory implements SequentialFileFactory {
     */
    public interface ListenerHoldCallback {
 
-      void callbackAdded(final ByteBuffer bytes);
+      void callbackAdded(ByteBuffer bytes);
    }
 
    private class CallbackRunnable implements Runnable {


Mime
View raw message