activemq-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuco...@apache.org
Subject activemq-artemis git commit: ARTEMIS-1114 Improving some comment
Date Tue, 18 Apr 2017 01:28:44 GMT
Repository: activemq-artemis
Updated Branches:
  refs/heads/master 09958aa54 -> ee261e736


ARTEMIS-1114 Improving some comment


Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/ee261e73
Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/ee261e73
Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/ee261e73

Branch: refs/heads/master
Commit: ee261e736c04572efa464a19a6cb045a455c5710
Parents: 09958aa
Author: Clebert Suconic <clebertsuconic@apache.org>
Authored: Fri Apr 14 18:07:09 2017 -0400
Committer: Clebert Suconic <clebertsuconic@apache.org>
Committed: Fri Apr 14 18:08:37 2017 -0400

----------------------------------------------------------------------
 .../activemq/artemis/core/journal/impl/JournalTransaction.java  | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/ee261e73/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalTransaction.java
----------------------------------------------------------------------
diff --git a/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalTransaction.java
b/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalTransaction.java
index 36d585a..78887db 100644
--- a/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalTransaction.java
+++ b/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalTransaction.java
@@ -232,7 +232,10 @@ public class JournalTransaction {
    public void commit(final JournalFile file) {
       JournalCompactor compactor = journal.getCompactor();
 
-      // The race lies here....
+      // https://issues.apache.org/jira/browse/ARTEMIS-1114
+      //   There was a race once where compacting was not set
+      //   because the Journal was missing a readLock and compacting was starting
+      //   without setting this properly...
       if (compacting && compactor != null) {
          if (logger.isTraceEnabled()) {
             logger.trace("adding tx " + this.id + " into compacting");


Mime
View raw message