activemq-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From martyntay...@apache.org
Subject [4/4] activemq-artemis git commit: Remove unnecessary @SuppressWarnings("unchecked")
Date Tue, 09 Aug 2016 10:24:36 GMT
Remove unnecessary @SuppressWarnings("unchecked")


Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/330c65ba
Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/330c65ba
Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/330c65ba

Branch: refs/heads/master
Commit: 330c65ba356b328effaa777a01cccb767c0f4527
Parents: b863219
Author: Ville Skyttä <ville.skytta@iki.fi>
Authored: Tue Aug 9 11:37:43 2016 +0300
Committer: Martyn Taylor <mtaylor@redhat.com>
Committed: Tue Aug 9 11:24:22 2016 +0100

----------------------------------------------------------------------
 .../java/org/apache/activemq/artemis/utils/uri/URISupport.java   | 1 -
 .../protocol/proton/converter/message/InboundTransformer.java    | 1 -
 .../failover/FailoverConsumerOutstandingCommitTest.java          | 2 --
 .../transport/failover/FailoverConsumerUnconsumedTest.java       | 2 --
 .../activemq/transport/failover/FailoverDuplicateTest.java       | 1 -
 .../activemq/transport/failover/FailoverPrefetchZeroTest.java    | 1 -
 .../activemq/transport/failover/FailoverTransactionTest.java     | 4 ----
 .../activemq/usecases/BrokerQueueNetworkWithDisconnectTest.java  | 1 -
 .../activemq/usecases/TwoBrokerQueueClientsReconnectTest.java    | 2 --
 9 files changed, 15 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/330c65ba/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/uri/URISupport.java
----------------------------------------------------------------------
diff --git a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/uri/URISupport.java
b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/uri/URISupport.java
index b850de9..f3744f1 100644
--- a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/uri/URISupport.java
+++ b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/uri/URISupport.java
@@ -217,7 +217,6 @@ public class URISupport {
       return uri;
    }
 
-   @SuppressWarnings("unchecked")
    private static Map<String, String> emptyMap() {
       return Collections.EMPTY_MAP;
    }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/330c65ba/artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/proton/converter/message/InboundTransformer.java
----------------------------------------------------------------------
diff --git a/artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/proton/converter/message/InboundTransformer.java
b/artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/proton/converter/message/InboundTransformer.java
index 9560ac1..a437e68 100644
--- a/artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/proton/converter/message/InboundTransformer.java
+++ b/artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/proton/converter/message/InboundTransformer.java
@@ -108,7 +108,6 @@ public abstract class InboundTransformer {
       this.vendor = vendor;
    }
 
-   @SuppressWarnings("unchecked")
    protected void populateMessage(Message jms, org.apache.qpid.proton.message.Message amqp)
throws Exception {
       Header header = amqp.getHeader();
       if (header == null) {

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/330c65ba/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverConsumerOutstandingCommitTest.java
----------------------------------------------------------------------
diff --git a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverConsumerOutstandingCommitTest.java
b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverConsumerOutstandingCommitTest.java
index 449600a..c31aba2 100644
--- a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverConsumerOutstandingCommitTest.java
+++ b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverConsumerOutstandingCommitTest.java
@@ -91,7 +91,6 @@ public class FailoverConsumerOutstandingCommitTest extends OpenwireArtemisBaseTe
       doTestFailoverConsumerDups(true);
    }
 
-   @SuppressWarnings("unchecked")
    public void doTestFailoverConsumerDups(final boolean watchTopicAdvisories) throws Exception
{
 
       server = createBroker();
@@ -204,7 +203,6 @@ public class FailoverConsumerOutstandingCommitTest extends OpenwireArtemisBaseTe
       doTestFailoverConsumerOutstandingSendTx(true);
    }
 
-   @SuppressWarnings("unchecked")
    public void doTestFailoverConsumerOutstandingSendTx(final boolean doActualBrokerCommit)
throws Exception {
       final boolean watchTopicAdvisories = true;
       server = createBroker();

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/330c65ba/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverConsumerUnconsumedTest.java
----------------------------------------------------------------------
diff --git a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverConsumerUnconsumedTest.java
b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverConsumerUnconsumedTest.java
index 95e9021..05116a5 100644
--- a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverConsumerUnconsumedTest.java
+++ b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverConsumerUnconsumedTest.java
@@ -118,7 +118,6 @@ public class FailoverConsumerUnconsumedTest extends OpenwireArtemisBaseTest
{
       doTestFailoverConsumerDups(false);
    }
 
-   @SuppressWarnings("unchecked")
    @Test
    @BMRules(
            rules = {
@@ -231,7 +230,6 @@ public class FailoverConsumerUnconsumedTest extends OpenwireArtemisBaseTest
{
       connection.close();
    }
 
-   @SuppressWarnings("unchecked")
    public void doTestFailoverConsumerDups(final boolean watchTopicAdvisories) throws Exception
{
 
       maxConsumers = 4;

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/330c65ba/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverDuplicateTest.java
----------------------------------------------------------------------
diff --git a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverDuplicateTest.java
b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverDuplicateTest.java
index 89ba1d7..e2654e7 100644
--- a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverDuplicateTest.java
+++ b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverDuplicateTest.java
@@ -86,7 +86,6 @@ public class FailoverDuplicateTest extends OpenwireArtemisBaseTest {
       factory.setOptimizeAcknowledge(true);
    }
 
-   @SuppressWarnings("unchecked")
    @Test
    @BMRules(
            rules = {

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/330c65ba/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverPrefetchZeroTest.java
----------------------------------------------------------------------
diff --git a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverPrefetchZeroTest.java
b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverPrefetchZeroTest.java
index a262033..9596317 100644
--- a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverPrefetchZeroTest.java
+++ b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverPrefetchZeroTest.java
@@ -71,7 +71,6 @@ public class FailoverPrefetchZeroTest extends OpenwireArtemisBaseTest {
       broker.start();
    }
 
-   @SuppressWarnings("unchecked")
    @Test
    @BMRules(
       rules = {@BMRule(

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/330c65ba/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverTransactionTest.java
----------------------------------------------------------------------
diff --git a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverTransactionTest.java
b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverTransactionTest.java
index 00ff4b5..1557854 100644
--- a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverTransactionTest.java
+++ b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverTransactionTest.java
@@ -220,7 +220,6 @@ public class FailoverTransactionTest extends OpenwireArtemisBaseTest {
       connection.close();
    }
 
-   @SuppressWarnings("unchecked")
    @Test
    public void testFailoverCommitReplyLostWithDestinationPathSeparator() throws Exception
{
       //the original test validates destinations using forward slash (/) as
@@ -230,7 +229,6 @@ public class FailoverTransactionTest extends OpenwireArtemisBaseTest {
       //Artemis doesn't support "/" so far and this test doesn't make sense therefore.
    }
 
-   @SuppressWarnings("unchecked")
    @Test
    @BMRules(
            rules = {
@@ -316,7 +314,6 @@ public class FailoverTransactionTest extends OpenwireArtemisBaseTest {
       connection.close();
    }
 
-   @SuppressWarnings("unchecked")
    @Test
    @BMRules(
            rules = {
@@ -550,7 +547,6 @@ public class FailoverTransactionTest extends OpenwireArtemisBaseTest {
 //      }
 //   }
 //
-   @SuppressWarnings("unchecked")
    public void doTestFailoverConsumerAckLost(final int pauseSeconds) throws Exception {
       broker = createBroker();
       broker.start();

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/330c65ba/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/usecases/BrokerQueueNetworkWithDisconnectTest.java
----------------------------------------------------------------------
diff --git a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/usecases/BrokerQueueNetworkWithDisconnectTest.java
b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/usecases/BrokerQueueNetworkWithDisconnectTest.java
index 642379f..dd398aa 100644
--- a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/usecases/BrokerQueueNetworkWithDisconnectTest.java
+++ b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/usecases/BrokerQueueNetworkWithDisconnectTest.java
@@ -85,7 +85,6 @@ public class BrokerQueueNetworkWithDisconnectTest extends JmsMultipleBrokersTest
                     " must be received, duplicates are expected, count=" + msgs.getMessageCount(),
MESSAGE_COUNT <= msgs.getMessageCount());
    }
 
-   @SuppressWarnings("unchecked")
    public void testNoStuckConnectionsWithTransportDisconnect() throws Exception {
       inactiveDuration = 60000L;
       useDuplexNetworkBridge = true;

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/330c65ba/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/usecases/TwoBrokerQueueClientsReconnectTest.java
----------------------------------------------------------------------
diff --git a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/usecases/TwoBrokerQueueClientsReconnectTest.java
b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/usecases/TwoBrokerQueueClientsReconnectTest.java
index cafc701..0e9ff3e 100644
--- a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/usecases/TwoBrokerQueueClientsReconnectTest.java
+++ b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/usecases/TwoBrokerQueueClientsReconnectTest.java
@@ -366,7 +366,6 @@ public class TwoBrokerQueueClientsReconnectTest extends JmsMultipleBrokersTestSu
       assertEquals("Client for " + broker2 + " should have received 50% of the messages.",
(int) (MESSAGE_COUNT * 0.50), msgsClient2);
    }
 
-   @SuppressWarnings("unchecked")
    public void testDuplicateSend() throws Exception {
       broker1 = "BrokerA";
       broker2 = "BrokerB";
@@ -441,7 +440,6 @@ public class TwoBrokerQueueClientsReconnectTest extends JmsMultipleBrokersTestSu
       }));
    }
 
-   @SuppressWarnings("unchecked")
    public void testDuplicateSendWithNoAuditEnqueueCountStat() throws Exception {
       broker1 = "BrokerA";
       broker2 = "BrokerB";


Mime
View raw message