activemq-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbert...@apache.org
Subject [2/2] activemq-artemis git commit: ARTEMIS-632 JMSServerControlUsingJMSTest fails
Date Fri, 15 Jul 2016 14:31:10 GMT
ARTEMIS-632 JMSServerControlUsingJMSTest fails

The testRemoteClientIDConnection fails. The failure occurs when
connection objects are destroyed by garbage collector before time.


Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/aebf87ae
Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/aebf87ae
Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/aebf87ae

Branch: refs/heads/master
Commit: aebf87aeeeb6f03eb7c30c069d87f78e4a2eb8b6
Parents: 55fe2b3
Author: Erich Duda <eduda@redhat.com>
Authored: Fri Jul 15 09:01:36 2016 +0200
Committer: jbertram <jbertram@apache.org>
Committed: Fri Jul 15 09:30:53 2016 -0500

----------------------------------------------------------------------
 .../jms/server/management/JMSServerControlTest.java            | 6 ++++++
 1 file changed, 6 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/aebf87ae/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/management/JMSServerControlTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/management/JMSServerControlTest.java
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/management/JMSServerControlTest.java
index b42bba9..11546fc 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/management/JMSServerControlTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/management/JMSServerControlTest.java
@@ -947,6 +947,12 @@ public class JMSServerControlTest extends ManagementTestBase {
       }
 
       Assert.assertTrue(failed);
+
+      // If these objects are not referenced at the end of the test, they can be destroyed
by garbage collector
+      // during the test, what can lead to test failure.
+      connection.close();
+      connection2.close();
+      connection3.close();
    }
 
    // Package protected ---------------------------------------------


Mime
View raw message