activemq-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tab...@apache.org
Subject activemq git commit: Add some additional time to the wait for completion assert. On a sufficiently loaded system 30s is not quite enough. This is reproducable if run while a heavily I/O based application is also running in the background.
Date Fri, 13 May 2016 16:50:30 GMT
Repository: activemq
Updated Branches:
  refs/heads/master cc849e744 -> b9334960e


Add some additional time to the wait for completion assert.  On a
sufficiently loaded system 30s is not quite enough.  This is
reproducable if run while a heavily I/O based application is also
running in the background.  

Project: http://git-wip-us.apache.org/repos/asf/activemq/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq/commit/b9334960
Tree: http://git-wip-us.apache.org/repos/asf/activemq/tree/b9334960
Diff: http://git-wip-us.apache.org/repos/asf/activemq/diff/b9334960

Branch: refs/heads/master
Commit: b9334960e06f48454305fc60732b683347d4aaed
Parents: cc849e7
Author: Timothy Bish <tabish121@gmail.com>
Authored: Fri May 13 12:50:13 2016 -0400
Committer: Timothy Bish <tabish121@gmail.com>
Committed: Fri May 13 12:50:13 2016 -0400

----------------------------------------------------------------------
 .../test/java/org/apache/activemq/store/PListTestSupport.java    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/activemq/blob/b9334960/activemq-broker/src/test/java/org/apache/activemq/store/PListTestSupport.java
----------------------------------------------------------------------
diff --git a/activemq-broker/src/test/java/org/apache/activemq/store/PListTestSupport.java
b/activemq-broker/src/test/java/org/apache/activemq/store/PListTestSupport.java
index 8fc7027..152f96a 100644
--- a/activemq-broker/src/test/java/org/apache/activemq/store/PListTestSupport.java
+++ b/activemq-broker/src/test/java/org/apache/activemq/store/PListTestSupport.java
@@ -253,7 +253,7 @@ public abstract class PListTestSupport {
                          synchronized (plistLocks(candidate)) {
                              Object last = candidate.addLast(String.valueOf(i), payload);
                              getFirst(candidate);
-                            assertTrue(candidate.remove(last));
+                             assertTrue(candidate.remove(last));
                          }
                     }
                 } catch (Exception error) {
@@ -273,7 +273,7 @@ public abstract class PListTestSupport {
         executor.execute(new B());
 
         executor.shutdown();
-        boolean finishedInTime = executor.awaitTermination(30, TimeUnit.SECONDS);
+        boolean finishedInTime = executor.awaitTermination(60, TimeUnit.SECONDS);
 
         assertTrue("no exceptions", exceptions.isEmpty());
         assertTrue("finished ok", finishedInTime);


Mime
View raw message