Return-Path: X-Original-To: apmail-activemq-commits-archive@www.apache.org Delivered-To: apmail-activemq-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A79F5180E1 for ; Tue, 12 Jan 2016 00:45:54 +0000 (UTC) Received: (qmail 48554 invoked by uid 500); 12 Jan 2016 00:45:54 -0000 Delivered-To: apmail-activemq-commits-archive@activemq.apache.org Received: (qmail 48355 invoked by uid 500); 12 Jan 2016 00:45:54 -0000 Mailing-List: contact commits-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list commits@activemq.apache.org Received: (qmail 48337 invoked by uid 99); 12 Jan 2016 00:45:54 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Jan 2016 00:45:54 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id EE9E5E0B54; Tue, 12 Jan 2016 00:45:53 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: clebertsuconic@apache.org To: commits@activemq.apache.org Date: Tue, 12 Jan 2016 00:45:54 -0000 Message-Id: <0a7253a5f0e34c67a8831f7c699bbb43@git.apache.org> In-Reply-To: <2d26934e743e4f4ea6107821514d0854@git.apache.org> References: <2d26934e743e4f4ea6107821514d0854@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [2/3] activemq-artemis git commit: remove now invalid tests remove now invalid tests Since we are removing the finalize cleanup these tests are now invalid Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/d9ac06a9 Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/d9ac06a9 Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/d9ac06a9 Branch: refs/heads/master Commit: d9ac06a9074b218387f6c4de7fab4e1d0b81f600 Parents: 945963e Author: Clebert Suconic Authored: Mon Jan 11 19:41:21 2016 -0500 Committer: Clebert Suconic Committed: Mon Jan 11 19:43:31 2016 -0500 ---------------------------------------------------------------------- .../client/SessionCloseOnGCTest.java | 48 -------------------- 1 file changed, 48 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/d9ac06a9/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/SessionCloseOnGCTest.java ---------------------------------------------------------------------- diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/SessionCloseOnGCTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/SessionCloseOnGCTest.java index 3f25a47..2f97e32 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/SessionCloseOnGCTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/SessionCloseOnGCTest.java @@ -176,52 +176,4 @@ public class SessionCloseOnGCTest extends ActiveMQTestBase { locator = null; ActiveMQTestBase.checkWeakReferences(fref); } - - @Test - public void testCloseOneSessionOnGC() throws Exception { - ClientSessionFactoryImpl sf = (ClientSessionFactoryImpl) locator.createSessionFactory(); - - { - ClientSession session = sf.createSession(false, true, true); - - Assert.assertEquals(1, server.getRemotingService().getConnections().size()); - } - - for (int i = 0; i < 1000 && sf.numSessions() != 0; i++) { - forceGC(); - } - - Assert.assertEquals(0, sf.numSessions()); - Assert.assertEquals(1, sf.numConnections()); - Assert.assertEquals(1, server.getRemotingService().getConnections().size()); - } - - @Test - public void testCloseSeveralSessionOnGC() throws Exception { - ClientSessionFactoryImpl sf = (ClientSessionFactoryImpl) locator.createSessionFactory(); - - ClientSession session1 = sf.createSession(false, true, true); - ClientSession session2 = sf.createSession(false, true, true); - ClientSession session3 = sf.createSession(false, true, true); - - Assert.assertEquals(1, server.getRemotingService().getConnections().size()); - - WeakReference ref1 = new WeakReference<>(session1); - WeakReference ref2 = new WeakReference<>(session2); - WeakReference ref3 = new WeakReference<>(session3); - - session1 = null; - session2 = null; - session3 = null; - - ActiveMQTestBase.checkWeakReferences(ref1, ref2, ref3); - - for (int i = 0; i < 1000 && sf.numSessions() != 0; i++) { - forceGC(); - } - Assert.assertEquals("# sessions", 0, sf.numSessions()); - Assert.assertEquals("# connections", 1, sf.numConnections()); - Assert.assertEquals("# connections in remoting service", 1, server.getRemotingService().getConnections().size()); - } - }