activemq-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuco...@apache.org
Subject [1/4] activemq-artemis git commit: Add missing @Override annotations
Date Mon, 25 Jan 2016 18:48:40 GMT
Repository: activemq-artemis
Updated Branches:
  refs/heads/master 094222bc7 -> 27c59583f


Add missing @Override annotations


Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/13cb6ddf
Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/13cb6ddf
Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/13cb6ddf

Branch: refs/heads/master
Commit: 13cb6ddfd16c06b10ac09e39bf0a2725aea85de4
Parents: 3f20e0d
Author: Ville Skyttä <ville.skytta@iki.fi>
Authored: Sun Jan 24 13:14:33 2016 +0200
Committer: Clebert Suconic <clebertsuconic@apache.org>
Committed: Mon Jan 25 12:10:25 2016 -0500

----------------------------------------------------------------------
 .../impl/openmbean/JMSOpenTypeSupport.java      |  2 +
 .../core/config/impl/ConfigurationImpl.java     |  3 +
 .../journal/AbstractJournalStorageManager.java  | 77 ++++++++++++++++++++
 .../impl/journal/DummyOperationContext.java     | 10 +++
 .../journal/LargeMessageTXFailureCallback.java  |  1 +
 .../journal/codec/CursorAckRecordEncoding.java  |  3 +
 .../codec/DeliveryCountUpdateEncoding.java      |  3 +
 .../impl/journal/codec/DuplicateIDEncoding.java |  3 +
 .../impl/journal/codec/GroupingEncoding.java    |  6 ++
 .../codec/HeuristicCompletionEncoding.java      |  3 +
 .../journal/codec/LargeMessageEncoding.java     |  3 +
 .../journal/codec/PageCountPendingImpl.java     |  3 +
 .../impl/journal/codec/PageCountRecordInc.java  |  3 +
 .../journal/codec/PageUpdateTXEncoding.java     |  1 +
 .../codec/PendingLargeMessageEncoding.java      |  3 +
 .../codec/PersistentQueueBindingEncoding.java   | 10 +++
 .../impl/journal/codec/QueueEncoding.java       |  3 +
 .../impl/journal/codec/XidEncoding.java         |  3 +
 .../impl/LegacyLDAPSecuritySettingPlugin.java   |  1 +
 .../artemis/tests/util/ThreadLeakCheckRule.java |  2 +
 20 files changed, 143 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/13cb6ddf/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/management/impl/openmbean/JMSOpenTypeSupport.java
----------------------------------------------------------------------
diff --git a/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/management/impl/openmbean/JMSOpenTypeSupport.java
b/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/management/impl/openmbean/JMSOpenTypeSupport.java
index 5c1e556..513d1f2 100644
--- a/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/management/impl/openmbean/JMSOpenTypeSupport.java
+++ b/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/management/impl/openmbean/JMSOpenTypeSupport.java
@@ -56,6 +56,7 @@ public final class JMSOpenTypeSupport {
       private final List<String> itemDescriptionsList = new ArrayList<>();
       private final List<OpenType> itemTypesList = new ArrayList<>();
 
+      @Override
       public CompositeType getCompositeType() throws OpenDataException {
          if (compositeType == null) {
             init();
@@ -86,6 +87,7 @@ public final class JMSOpenTypeSupport {
          return getTypeName();
       }
 
+      @Override
       public Map<String, Object> getFields(CompositeDataSupport data) throws OpenDataException
{
          Map<String, Object> rc = new HashMap<>();
          return rc;

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/13cb6ddf/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/ConfigurationImpl.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/ConfigurationImpl.java
b/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/ConfigurationImpl.java
index a90374e..ca1127d 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/ConfigurationImpl.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/ConfigurationImpl.java
@@ -495,6 +495,7 @@ public class ConfigurationImpl implements Configuration, Serializable
{
       return this;
    }
 
+   @Override
    public ClusterConnectionConfiguration addClusterConfiguration(String name, String uri)
throws Exception {
       ClusterConnectionConfiguration newConfig = new ClusterConnectionConfiguration(new URI(uri)).setName(name);
       clusterConfigurations.add(newConfig);
@@ -1289,10 +1290,12 @@ public class ConfigurationImpl implements Configuration, Serializable
{
       return this;
    }
 
+   @Override
    public TransportConfiguration[] getTransportConfigurations(String... connectorNames) {
       return getTransportConfigurations(Arrays.asList(connectorNames));
    }
 
+   @Override
    public TransportConfiguration[] getTransportConfigurations(final List<String> connectorNames)
{
       TransportConfiguration[] tcConfigs = (TransportConfiguration[]) Array.newInstance(TransportConfiguration.class,
connectorNames.size());
       int count = 0;

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/13cb6ddf/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
index b5569bd..4471ff3 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
@@ -263,10 +263,12 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       return getContext().waitCompletion(timeout);
    }
 
+   @Override
    public OperationContext getContext() {
       return OperationContextImpl.getContext(executorFactory);
    }
 
+   @Override
    public void setContext(final OperationContext context) {
       OperationContextImpl.setContext(context);
    }
@@ -275,22 +277,27 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       return singleThreadExecutor;
    }
 
+   @Override
    public OperationContext newSingleThreadContext() {
       return newContext(singleThreadExecutor);
    }
 
+   @Override
    public OperationContext newContext(final Executor executor1) {
       return new OperationContextImpl(executor1);
    }
 
+   @Override
    public void afterCompleteOperations(final IOCallback run) {
       getContext().executeOnCompletion(run);
    }
 
+   @Override
    public long generateID() {
       return idGenerator.generateID();
    }
 
+   @Override
    public long getCurrentID() {
       return idGenerator.getCurrentID();
    }
@@ -298,6 +305,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
    // Non transactional operations
 
 
+   @Override
    public void confirmPendingLargeMessageTX(final Transaction tx, long messageID, long recordID)
throws Exception {
       readLock();
       try {
@@ -312,6 +320,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
    /**
     * We don't need messageID now but we are likely to need it we ever decide to support
a database
     */
+   @Override
    public void confirmPendingLargeMessage(long recordID) throws Exception {
       readLock();
       try {
@@ -322,6 +331,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void storeMessage(final ServerMessage message) throws Exception {
       if (message.getMessageID() <= 0) {
          // Sanity check only... this shouldn't happen unless there is a bug
@@ -345,6 +355,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void storeReference(final long queueID, final long messageID, final boolean last)
throws Exception {
       readLock();
       try {
@@ -365,6 +376,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       storageManagerLock.readLock().unlock();
    }
 
+   @Override
    public void storeAcknowledge(final long queueID, final long messageID) throws Exception
{
       readLock();
       try {
@@ -375,6 +387,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void storeCursorAcknowledge(long queueID, PagePosition position) throws Exception
{
       readLock();
       try {
@@ -387,6 +400,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void deleteMessage(final long messageID) throws Exception {
       readLock();
       try {
@@ -401,6 +415,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void updateScheduledDeliveryTime(final MessageReference ref) throws Exception {
       ScheduledDeliveryEncoding encoding = new ScheduledDeliveryEncoding(ref.getScheduledDeliveryTime(),
ref.getQueue().getID());
       readLock();
@@ -412,6 +427,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void storeDuplicateID(final SimpleString address, final byte[] duplID, final long
recordID) throws Exception {
       readLock();
       try {
@@ -424,6 +440,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void deleteDuplicateID(final long recordID) throws Exception {
       readLock();
       try {
@@ -436,6 +453,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
 
    // Transactional operations
 
+   @Override
    public void storeMessageTransactional(final long txID, final ServerMessage message) throws
Exception {
       if (message.getMessageID() <= 0) {
          throw ActiveMQMessageBundle.BUNDLE.messageIdNotAssigned();
@@ -456,6 +474,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void storePageTransaction(final long txID, final PageTransactionInfo pageTransaction)
throws Exception {
       readLock();
       try {
@@ -467,6 +486,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void updatePageTransaction(final long txID,
                                      final PageTransactionInfo pageTransaction,
                                      final int depages) throws Exception {
@@ -479,6 +499,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void updatePageTransaction(final PageTransactionInfo pageTransaction, final int
depages) throws Exception {
       readLock();
       try {
@@ -489,6 +510,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void storeReferenceTransactional(final long txID, final long queueID, final long
messageID) throws Exception {
       readLock();
       try {
@@ -499,6 +521,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void storeAcknowledgeTransactional(final long txID,
                                              final long queueID,
                                              final long messageID) throws Exception {
@@ -511,6 +534,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void storeCursorAcknowledgeTransactional(long txID, long queueID, PagePosition
position) throws Exception {
       readLock();
       try {
@@ -523,16 +547,19 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void storePageCompleteTransactional(long txID, long queueID, PagePosition position)
throws Exception {
       long recordID = idGenerator.generateID();
       position.setRecordID(recordID);
       messageJournal.appendAddRecordTransactional(txID, recordID, JournalRecordIds.PAGE_CURSOR_COMPLETE,
new CursorAckRecordEncoding(queueID, position));
    }
 
+   @Override
    public void deletePageComplete(long ackID) throws Exception {
       messageJournal.appendDeleteRecord(ackID, false);
    }
 
+   @Override
    public void deleteCursorAcknowledgeTransactional(long txID, long ackID) throws Exception
{
       readLock();
       try {
@@ -543,10 +570,12 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void deleteCursorAcknowledge(long ackID) throws Exception {
       messageJournal.appendDeleteRecord(ackID, false);
    }
 
+   @Override
    public long storeHeuristicCompletion(final Xid xid, final boolean isCommit) throws Exception
{
       readLock();
       try {
@@ -560,6 +589,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void deleteHeuristicCompletion(final long id) throws Exception {
       readLock();
       try {
@@ -571,6 +601,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void deletePageTransactional(final long recordID) throws Exception {
       readLock();
       try {
@@ -581,6 +612,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void updateScheduledDeliveryTimeTransactional(final long txID, final MessageReference
ref) throws Exception {
       ScheduledDeliveryEncoding encoding = new ScheduledDeliveryEncoding(ref.getScheduledDeliveryTime(),
ref.getQueue().getID());
       readLock();
@@ -593,6 +625,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void prepare(final long txID, final Xid xid) throws Exception {
       readLock();
       try {
@@ -603,19 +636,23 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void commit(final long txID) throws Exception {
       commit(txID, true);
    }
 
+   @Override
    public void commitBindings(final long txID) throws Exception {
       bindingsJournal.appendCommitRecord(txID, true);
    }
 
+   @Override
    public void rollbackBindings(final long txID) throws Exception {
       // no need to sync, it's going away anyways
       bindingsJournal.appendRollbackRecord(txID, false);
    }
 
+   @Override
    public void commit(final long txID, final boolean lineUpContext) throws Exception {
       readLock();
       try {
@@ -636,6 +673,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void rollback(final long txID) throws Exception {
       readLock();
       try {
@@ -646,6 +684,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void storeDuplicateIDTransactional(final long txID,
                                              final SimpleString address,
                                              final byte[] duplID,
@@ -661,6 +700,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void updateDuplicateIDTransactional(final long txID,
                                               final SimpleString address,
                                               final byte[] duplID,
@@ -676,6 +716,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void deleteDuplicateIDTransactional(final long txID, final long recordID) throws
Exception {
       readLock();
       try {
@@ -688,6 +729,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
 
    // Other operations
 
+   @Override
    public void updateDeliveryCount(final MessageReference ref) throws Exception {
       // no need to store if it's the same value
       // otherwise the journal will get OME in case of lots of redeliveries
@@ -707,6 +749,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void storeAddressSetting(PersistedAddressSetting addressSetting) throws Exception
{
       deleteAddressSetting(addressSetting.getAddressMatch());
       readLock();
@@ -721,14 +764,17 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public List<PersistedAddressSetting> recoverAddressSettings() throws Exception {
       return new ArrayList<>(mapPersistedAddressSettings.values());
    }
 
+   @Override
    public List<PersistedRoles> recoverPersistedRoles() throws Exception {
       return new ArrayList<>(mapPersistedRoles.values());
    }
 
+   @Override
    public void storeSecurityRoles(PersistedRoles persistedRoles) throws Exception {
 
       deleteSecurityRoles(persistedRoles.getAddressMatch());
@@ -766,6 +812,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void deleteAddressSetting(SimpleString addressMatch) throws Exception {
       PersistedAddressSetting oldSetting = mapPersistedAddressSettings.remove(addressMatch);
       if (oldSetting != null) {
@@ -779,6 +826,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void deleteSecurityRoles(SimpleString addressMatch) throws Exception {
       PersistedRoles oldRoles = mapPersistedRoles.remove(addressMatch);
       if (oldRoles != null) {
@@ -1174,6 +1222,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
    }
 
    // grouping handler operations
+   @Override
    public void addGrouping(final GroupBinding groupBinding) throws Exception {
       GroupingEncoding groupingEncoding = new GroupingEncoding(groupBinding.getId(), groupBinding.getGroupId(),
groupBinding.getClusterName());
       readLock();
@@ -1185,6 +1234,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void deleteGrouping(long tx, final GroupBinding groupBinding) throws Exception
{
       readLock();
       try {
@@ -1197,6 +1247,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
 
    // BindingsImpl operations
 
+   @Override
    public void addQueueBinding(final long tx, final Binding binding) throws Exception {
       Queue queue = (Queue) binding.getBindable();
 
@@ -1215,6 +1266,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void deleteQueueBinding(long tx, final long queueBindingID) throws Exception {
       readLock();
       try {
@@ -1225,6 +1277,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public long storePageCounterInc(long txID, long queueID, int value) throws Exception {
       readLock();
       try {
@@ -1237,6 +1290,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public long storePageCounterInc(long queueID, int value) throws Exception {
       readLock();
       try {
@@ -1278,6 +1332,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void deleteIncrementRecord(long txID, long recordID) throws Exception {
       readLock();
       try {
@@ -1288,6 +1343,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void deletePageCounter(long txID, long recordID) throws Exception {
       readLock();
       try {
@@ -1298,6 +1354,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void deletePendingPageCounter(long txID, long recordID) throws Exception {
       readLock();
       try {
@@ -1308,6 +1365,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public JournalLoadInformation loadBindingJournal(final List<QueueBindingInfo> queueBindingInfos,
                                                     final List<GroupingInfo> groupingInfos)
throws Exception {
       List<RecordInfo> records = new ArrayList<>();
@@ -1354,6 +1412,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       return bindingsInfo;
    }
 
+   @Override
    public void lineUpContext() {
       readLock();
       try {
@@ -1369,6 +1428,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
 
    protected abstract void beforeStart() throws Exception;
 
+   @Override
    public synchronized void start() throws Exception {
       if (started) {
          return;
@@ -1390,6 +1450,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       started = true;
    }
 
+   @Override
    public void stop() throws Exception {
       stop(false);
    }
@@ -1407,6 +1468,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
     */
    protected abstract void performCachedLargeMessageDeletes();
 
+   @Override
    public synchronized void stop(boolean ioCriticalError) throws Exception {
       if (!started) {
          return;
@@ -1444,6 +1506,7 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
 
    protected abstract void beforeStop() throws Exception;
 
+   @Override
    public synchronized boolean isStarted() {
       return started;
    }
@@ -1465,12 +1528,14 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
       }
    }
 
+   @Override
    public void beforePageRead() throws Exception {
       if (pageMaxConcurrentIO != null) {
          pageMaxConcurrentIO.acquire();
       }
    }
 
+   @Override
    public void afterPageRead() throws Exception {
       if (pageMaxConcurrentIO != null) {
          pageMaxConcurrentIO.release();
@@ -1479,10 +1544,12 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
 
    // Public -----------------------------------------------------------------------------------
 
+   @Override
    public Journal getMessageJournal() {
       return messageJournal;
    }
 
+   @Override
    public Journal getBindingsJournal() {
       return bindingsJournal;
    }
@@ -1714,37 +1781,47 @@ public abstract class AbstractJournalStorageManager implements StorageManager
{
          return DummyOperationContext.instance;
       }
 
+      @Override
       public void executeOnCompletion(final IOCallback runnable) {
          // There are no executeOnCompletion calls while using the DummyOperationContext
          // However we keep the code here for correctness
          runnable.done();
       }
 
+      @Override
       public void replicationDone() {
       }
 
+      @Override
       public void replicationLineUp() {
       }
 
+      @Override
       public void storeLineUp() {
       }
 
+      @Override
       public void done() {
       }
 
+      @Override
       public void onError(final int errorCode, final String errorMessage) {
       }
 
+      @Override
       public void waitCompletion() {
       }
 
+      @Override
       public boolean waitCompletion(final long timeout) {
          return true;
       }
 
+      @Override
       public void pageSyncLineUp() {
       }
 
+      @Override
       public void pageSyncDone() {
       }
    }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/13cb6ddf/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/DummyOperationContext.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/DummyOperationContext.java
b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/DummyOperationContext.java
index 194d2b1..1ae7524 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/DummyOperationContext.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/DummyOperationContext.java
@@ -27,37 +27,47 @@ final class DummyOperationContext implements OperationContext {
       return DummyOperationContext.instance;
    }
 
+   @Override
    public void executeOnCompletion(final IOCallback runnable) {
       // There are no executeOnCompletion calls while using the DummyOperationContext
       // However we keep the code here for correctness
       runnable.done();
    }
 
+   @Override
    public void replicationDone() {
    }
 
+   @Override
    public void replicationLineUp() {
    }
 
+   @Override
    public void storeLineUp() {
    }
 
+   @Override
    public void done() {
    }
 
+   @Override
    public void onError(final int errorCode, final String errorMessage) {
    }
 
+   @Override
    public void waitCompletion() {
    }
 
+   @Override
    public boolean waitCompletion(final long timeout) {
       return true;
    }
 
+   @Override
    public void pageSyncLineUp() {
    }
 
+   @Override
    public void pageSyncDone() {
    }
 }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/13cb6ddf/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/LargeMessageTXFailureCallback.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/LargeMessageTXFailureCallback.java
b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/LargeMessageTXFailureCallback.java
index c2133d9..045be46 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/LargeMessageTXFailureCallback.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/LargeMessageTXFailureCallback.java
@@ -41,6 +41,7 @@ public class LargeMessageTXFailureCallback implements TransactionFailureCallback
       this.messages = messages;
    }
 
+   @Override
    public void failedTransaction(final long transactionID,
                                  final List<RecordInfo> records,
                                  final List<RecordInfo> recordsToDelete) {

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/13cb6ddf/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/CursorAckRecordEncoding.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/CursorAckRecordEncoding.java
b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/CursorAckRecordEncoding.java
index 4e1fada..db62916 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/CursorAckRecordEncoding.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/CursorAckRecordEncoding.java
@@ -42,16 +42,19 @@ public class CursorAckRecordEncoding implements EncodingSupport {
 
    public PagePosition position;
 
+   @Override
    public int getEncodeSize() {
       return DataConstants.SIZE_LONG + DataConstants.SIZE_LONG + DataConstants.SIZE_INT;
    }
 
+   @Override
    public void encode(ActiveMQBuffer buffer) {
       buffer.writeLong(queueID);
       buffer.writeLong(position.getPageNr());
       buffer.writeInt(position.getMessageNr());
    }
 
+   @Override
    public void decode(ActiveMQBuffer buffer) {
       queueID = buffer.readLong();
       long pageNR = buffer.readLong();

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/13cb6ddf/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/DeliveryCountUpdateEncoding.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/DeliveryCountUpdateEncoding.java
b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/DeliveryCountUpdateEncoding.java
index 5c4541d..5025c77 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/DeliveryCountUpdateEncoding.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/DeliveryCountUpdateEncoding.java
@@ -35,16 +35,19 @@ public class DeliveryCountUpdateEncoding implements EncodingSupport {
       this.count = count;
    }
 
+   @Override
    public void decode(final ActiveMQBuffer buffer) {
       queueID = buffer.readLong();
       count = buffer.readInt();
    }
 
+   @Override
    public void encode(final ActiveMQBuffer buffer) {
       buffer.writeLong(queueID);
       buffer.writeInt(count);
    }
 
+   @Override
    public int getEncodeSize() {
       return 8 + 4;
    }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/13cb6ddf/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/DuplicateIDEncoding.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/DuplicateIDEncoding.java
b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/DuplicateIDEncoding.java
index 49d8dc8..fccc2e2 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/DuplicateIDEncoding.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/DuplicateIDEncoding.java
@@ -40,6 +40,7 @@ public class DuplicateIDEncoding implements EncodingSupport {
    public DuplicateIDEncoding() {
    }
 
+   @Override
    public void decode(final ActiveMQBuffer buffer) {
       address = buffer.readSimpleString();
 
@@ -50,6 +51,7 @@ public class DuplicateIDEncoding implements EncodingSupport {
       buffer.readBytes(duplID);
    }
 
+   @Override
    public void encode(final ActiveMQBuffer buffer) {
       buffer.writeSimpleString(address);
 
@@ -58,6 +60,7 @@ public class DuplicateIDEncoding implements EncodingSupport {
       buffer.writeBytes(duplID);
    }
 
+   @Override
    public int getEncodeSize() {
       return SimpleString.sizeofString(address) + DataConstants.SIZE_INT + duplID.length;
    }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/13cb6ddf/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/GroupingEncoding.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/GroupingEncoding.java
b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/GroupingEncoding.java
index 8db6037..aec0a36 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/GroupingEncoding.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/GroupingEncoding.java
@@ -38,20 +38,24 @@ public class GroupingEncoding implements EncodingSupport, GroupingInfo
{
    public GroupingEncoding() {
    }
 
+   @Override
    public int getEncodeSize() {
       return SimpleString.sizeofString(groupId) + SimpleString.sizeofString(clusterName);
    }
 
+   @Override
    public void encode(final ActiveMQBuffer buffer) {
       buffer.writeSimpleString(groupId);
       buffer.writeSimpleString(clusterName);
    }
 
+   @Override
    public void decode(final ActiveMQBuffer buffer) {
       groupId = buffer.readSimpleString();
       clusterName = buffer.readSimpleString();
    }
 
+   @Override
    public long getId() {
       return id;
    }
@@ -60,10 +64,12 @@ public class GroupingEncoding implements EncodingSupport, GroupingInfo
{
       this.id = id;
    }
 
+   @Override
    public SimpleString getGroupId() {
       return groupId;
    }
 
+   @Override
    public SimpleString getClusterName() {
       return clusterName;
    }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/13cb6ddf/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/HeuristicCompletionEncoding.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/HeuristicCompletionEncoding.java
b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/HeuristicCompletionEncoding.java
index 4ef9c85..20d3711 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/HeuristicCompletionEncoding.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/HeuristicCompletionEncoding.java
@@ -42,16 +42,19 @@ public class HeuristicCompletionEncoding implements EncodingSupport {
    public HeuristicCompletionEncoding() {
    }
 
+   @Override
    public void decode(final ActiveMQBuffer buffer) {
       xid = XidCodecSupport.decodeXid(buffer);
       isCommit = buffer.readBoolean();
    }
 
+   @Override
    public void encode(final ActiveMQBuffer buffer) {
       XidCodecSupport.encodeXid(xid, buffer);
       buffer.writeBoolean(isCommit);
    }
 
+   @Override
    public int getEncodeSize() {
       return XidCodecSupport.getXidEncodeLength(xid) + DataConstants.SIZE_BOOLEAN;
    }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/13cb6ddf/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/LargeMessageEncoding.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/LargeMessageEncoding.java
b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/LargeMessageEncoding.java
index 0e32895..cdb5702 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/LargeMessageEncoding.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/LargeMessageEncoding.java
@@ -31,6 +31,7 @@ public class LargeMessageEncoding implements EncodingSupport {
    /* (non-Javadoc)
     * @see org.apache.activemq.artemis.core.journal.EncodingSupport#decode(org.apache.activemq.artemis.spi.core.remoting.ActiveMQBuffer)
     */
+   @Override
    public void decode(final ActiveMQBuffer buffer) {
       message.decodeHeadersAndProperties(buffer);
    }
@@ -38,6 +39,7 @@ public class LargeMessageEncoding implements EncodingSupport {
    /* (non-Javadoc)
     * @see org.apache.activemq.artemis.core.journal.EncodingSupport#encode(org.apache.activemq.artemis.spi.core.remoting.ActiveMQBuffer)
     */
+   @Override
    public void encode(final ActiveMQBuffer buffer) {
       message.encode(buffer);
    }
@@ -45,6 +47,7 @@ public class LargeMessageEncoding implements EncodingSupport {
    /* (non-Javadoc)
     * @see org.apache.activemq.artemis.core.journal.EncodingSupport#getEncodeSize()
     */
+   @Override
    public int getEncodeSize() {
       return message.getEncodeSize();
    }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/13cb6ddf/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PageCountPendingImpl.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PageCountPendingImpl.java
b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PageCountPendingImpl.java
index 98371e7..56e8c87 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PageCountPendingImpl.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PageCountPendingImpl.java
@@ -47,14 +47,17 @@ public class PageCountPendingImpl implements EncodingSupport, PageCountPending
{
       this.id = id;
    }
 
+   @Override
    public long getID() {
       return id;
    }
 
+   @Override
    public long getQueueID() {
       return queueID;
    }
 
+   @Override
    public long getPageID() {
       return pageID;
    }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/13cb6ddf/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PageCountRecordInc.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PageCountRecordInc.java
b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PageCountRecordInc.java
index 6e0f717..e427d68 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PageCountRecordInc.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PageCountRecordInc.java
@@ -47,15 +47,18 @@ public class PageCountRecordInc implements EncodingSupport {
       return value;
    }
 
+   @Override
    public int getEncodeSize() {
       return DataConstants.SIZE_LONG + DataConstants.SIZE_INT;
    }
 
+   @Override
    public void encode(ActiveMQBuffer buffer) {
       buffer.writeLong(queueID);
       buffer.writeInt(value);
    }
 
+   @Override
    public void decode(ActiveMQBuffer buffer) {
       queueID = buffer.readLong();
       value = buffer.readInt();

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/13cb6ddf/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PageUpdateTXEncoding.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PageUpdateTXEncoding.java
b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PageUpdateTXEncoding.java
index feae37b..6db8270 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PageUpdateTXEncoding.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PageUpdateTXEncoding.java
@@ -42,6 +42,7 @@ public class PageUpdateTXEncoding implements EncodingSupport {
       this.recods = records;
    }
 
+   @Override
    public void decode(ActiveMQBuffer buffer) {
       this.pageTX = buffer.readLong();
       this.recods = buffer.readInt();

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/13cb6ddf/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PendingLargeMessageEncoding.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PendingLargeMessageEncoding.java
b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PendingLargeMessageEncoding.java
index 34fd9a4..b3be308 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PendingLargeMessageEncoding.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PendingLargeMessageEncoding.java
@@ -34,6 +34,7 @@ public class PendingLargeMessageEncoding implements EncodingSupport {
    /* (non-Javadoc)
     * @see org.apache.activemq.artemis.core.journal.EncodingSupport#decode(org.apache.activemq.artemis.spi.core.remoting.ActiveMQBuffer)
     */
+   @Override
    public void decode(final ActiveMQBuffer buffer) {
       largeMessageID = buffer.readLong();
    }
@@ -41,6 +42,7 @@ public class PendingLargeMessageEncoding implements EncodingSupport {
    /* (non-Javadoc)
     * @see org.apache.activemq.artemis.core.journal.EncodingSupport#encode(org.apache.activemq.artemis.spi.core.remoting.ActiveMQBuffer)
     */
+   @Override
    public void encode(final ActiveMQBuffer buffer) {
       buffer.writeLong(largeMessageID);
    }
@@ -48,6 +50,7 @@ public class PendingLargeMessageEncoding implements EncodingSupport {
    /* (non-Javadoc)
     * @see org.apache.activemq.artemis.core.journal.EncodingSupport#getEncodeSize()
     */
+   @Override
    public int getEncodeSize() {
       return DataConstants.SIZE_LONG;
    }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/13cb6ddf/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PersistentQueueBindingEncoding.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PersistentQueueBindingEncoding.java
b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PersistentQueueBindingEncoding.java
index bfbc7fd..4efe292 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PersistentQueueBindingEncoding.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PersistentQueueBindingEncoding.java
@@ -67,6 +67,7 @@ public class PersistentQueueBindingEncoding implements EncodingSupport,
QueueBin
       this.autoCreated = autoCreated;
    }
 
+   @Override
    public long getId() {
       return id;
    }
@@ -75,30 +76,37 @@ public class PersistentQueueBindingEncoding implements EncodingSupport,
QueueBin
       this.id = id;
    }
 
+   @Override
    public SimpleString getAddress() {
       return address;
    }
 
+   @Override
    public void replaceQueueName(SimpleString newName) {
       this.name = newName;
    }
 
+   @Override
    public SimpleString getFilterString() {
       return filterString;
    }
 
+   @Override
    public SimpleString getQueueName() {
       return name;
    }
 
+   @Override
    public SimpleString getUser() {
       return user;
    }
 
+   @Override
    public boolean isAutoCreated() {
       return autoCreated;
    }
 
+   @Override
    public void decode(final ActiveMQBuffer buffer) {
       name = buffer.readSimpleString();
       address = buffer.readSimpleString();
@@ -120,6 +128,7 @@ public class PersistentQueueBindingEncoding implements EncodingSupport,
QueueBin
       autoCreated = buffer.readBoolean();
    }
 
+   @Override
    public void encode(final ActiveMQBuffer buffer) {
       buffer.writeSimpleString(name);
       buffer.writeSimpleString(address);
@@ -128,6 +137,7 @@ public class PersistentQueueBindingEncoding implements EncodingSupport,
QueueBin
       buffer.writeBoolean(autoCreated);
    }
 
+   @Override
    public int getEncodeSize() {
       return SimpleString.sizeofString(name) + SimpleString.sizeofString(address) +
          SimpleString.sizeofNullableString(filterString) + DataConstants.SIZE_BOOLEAN +

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/13cb6ddf/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/QueueEncoding.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/QueueEncoding.java
b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/QueueEncoding.java
index 4b0dfb6..1e05195 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/QueueEncoding.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/QueueEncoding.java
@@ -32,14 +32,17 @@ public class QueueEncoding implements EncodingSupport {
       super();
    }
 
+   @Override
    public void decode(final ActiveMQBuffer buffer) {
       queueID = buffer.readLong();
    }
 
+   @Override
    public void encode(final ActiveMQBuffer buffer) {
       buffer.writeLong(queueID);
    }
 
+   @Override
    public int getEncodeSize() {
       return 8;
    }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/13cb6ddf/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/XidEncoding.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/XidEncoding.java
b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/XidEncoding.java
index 5969ca2..cf10cb6 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/XidEncoding.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/XidEncoding.java
@@ -38,14 +38,17 @@ public class XidEncoding implements EncodingSupport {
       xid = XidCodecSupport.decodeXid(ActiveMQBuffers.wrappedBuffer(data));
    }
 
+   @Override
    public void decode(final ActiveMQBuffer buffer) {
       throw new IllegalStateException("Non Supported Operation");
    }
 
+   @Override
    public void encode(final ActiveMQBuffer buffer) {
       XidCodecSupport.encodeXid(xid, buffer);
    }
 
+   @Override
    public int getEncodeSize() {
       return XidCodecSupport.getXidEncodeLength(xid);
    }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/13cb6ddf/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/LegacyLDAPSecuritySettingPlugin.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/LegacyLDAPSecuritySettingPlugin.java
b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/LegacyLDAPSecuritySettingPlugin.java
index 936ae9a..6adb2ab 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/LegacyLDAPSecuritySettingPlugin.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/LegacyLDAPSecuritySettingPlugin.java
@@ -384,6 +384,7 @@ public class LegacyLDAPSecuritySettingPlugin implements SecuritySettingPlugin
{
       }
    }
 
+   @Override
    public SecuritySettingPlugin stop() {
       try {
          eventContext.close();

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/13cb6ddf/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ThreadLeakCheckRule.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ThreadLeakCheckRule.java
b/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ThreadLeakCheckRule.java
index 8ee46c3..b87f5a7 100644
--- a/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ThreadLeakCheckRule.java
+++ b/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ThreadLeakCheckRule.java
@@ -40,6 +40,7 @@ public class ThreadLeakCheckRule extends ExternalResource {
     *
     * @throws if setup fails (which will disable {@code after}
     */
+   @Override
    protected void before() throws Throwable {
       // do nothing
 
@@ -50,6 +51,7 @@ public class ThreadLeakCheckRule extends ExternalResource {
    /**
     * Override to tear down your specific external resource.
     */
+   @Override
    protected void after() {
       try {
          if (enabled) {


Mime
View raw message