Return-Path: X-Original-To: apmail-activemq-commits-archive@www.apache.org Delivered-To: apmail-activemq-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DC10A18AB3 for ; Thu, 17 Dec 2015 02:33:17 +0000 (UTC) Received: (qmail 4898 invoked by uid 500); 17 Dec 2015 02:33:17 -0000 Delivered-To: apmail-activemq-commits-archive@activemq.apache.org Received: (qmail 4849 invoked by uid 500); 17 Dec 2015 02:33:17 -0000 Mailing-List: contact commits-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list commits@activemq.apache.org Received: (qmail 4840 invoked by uid 99); 17 Dec 2015 02:33:17 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Dec 2015 02:33:17 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 7F803E0B2D; Thu, 17 Dec 2015 02:33:17 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: clebertsuconic@apache.org To: commits@activemq.apache.org Date: Thu, 17 Dec 2015 02:33:17 -0000 Message-Id: <761a2279b6ca435986cfceab4ebd1de4@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [1/2] activemq-artemis git commit: ARTEMIS-302 - Cloning Connection Factory to avoid closing CFs from JNDI Repository: activemq-artemis Updated Branches: refs/heads/master f8741db4a -> 327299965 ARTEMIS-302 - Cloning Connection Factory to avoid closing CFs from JNDI Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/eddd3be4 Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/eddd3be4 Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/eddd3be4 Branch: refs/heads/master Commit: eddd3be46b295e825973664d6358b1d3aea83047 Parents: f8741db Author: Clebert Suconic Authored: Wed Dec 16 19:20:39 2015 -0500 Committer: Clebert Suconic Committed: Wed Dec 16 19:20:39 2015 -0500 ---------------------------------------------------------------------- .../apache/activemq/artemis/ra/inflow/ActiveMQActivation.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/eddd3be4/artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivation.java ---------------------------------------------------------------------- diff --git a/artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivation.java b/artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivation.java index d7a242d..f42db64 100644 --- a/artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivation.java +++ b/artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivation.java @@ -463,7 +463,9 @@ public class ActiveMQActivation { } Object fac = ctx.lookup(spec.getConnectionFactoryLookup()); if (fac instanceof ActiveMQConnectionFactory) { - factory = (ActiveMQConnectionFactory) fac; + // This will clone the connection factory + // to make sure we won't close anyone's connection factory when we stop the MDB + factory = ActiveMQJMSClient.createConnectionFactory(((ActiveMQConnectionFactory) fac).toURI().toString(), "internalConnection"); } else { factory = ra.newConnectionFactory(spec);