Return-Path: X-Original-To: apmail-activemq-commits-archive@www.apache.org Delivered-To: apmail-activemq-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5FFBE18DFF for ; Mon, 10 Aug 2015 15:13:26 +0000 (UTC) Received: (qmail 45910 invoked by uid 500); 10 Aug 2015 15:13:03 -0000 Delivered-To: apmail-activemq-commits-archive@activemq.apache.org Received: (qmail 45848 invoked by uid 500); 10 Aug 2015 15:13:03 -0000 Mailing-List: contact commits-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list commits@activemq.apache.org Received: (qmail 44915 invoked by uid 99); 10 Aug 2015 15:13:02 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Aug 2015 15:13:02 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 45A2BE053F; Mon, 10 Aug 2015 15:13:02 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: clebertsuconic@apache.org To: commits@activemq.apache.org Date: Mon, 10 Aug 2015 15:13:40 -0000 Message-Id: <94b0edf37a2644e5ae60ae66a2d4dacb@git.apache.org> In-Reply-To: <6d75255d38c94b2f8601b49eb76c9d59@git.apache.org> References: <6d75255d38c94b2f8601b49eb76c9d59@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [41/53] [abbrv] [partial] activemq-artemis git commit: automatic checkstyle change http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/bac96047/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/loadbalance/FirstElementConnectionLoadBalancingPolicy.java ---------------------------------------------------------------------- diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/loadbalance/FirstElementConnectionLoadBalancingPolicy.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/loadbalance/FirstElementConnectionLoadBalancingPolicy.java index 19947e6..2373879 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/loadbalance/FirstElementConnectionLoadBalancingPolicy.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/loadbalance/FirstElementConnectionLoadBalancingPolicy.java @@ -16,18 +16,16 @@ */ package org.apache.activemq.artemis.api.core.client.loadbalance; - /** * A {@link FirstElementConnectionLoadBalancingPolicy#select(int)} always returns 0. */ -public final class FirstElementConnectionLoadBalancingPolicy implements ConnectionLoadBalancingPolicy -{ +public final class FirstElementConnectionLoadBalancingPolicy implements ConnectionLoadBalancingPolicy { + /** * @param max param is ignored * @return 0 */ - public int select(final int max) - { + public int select(final int max) { return 0; } } http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/bac96047/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/loadbalance/RandomConnectionLoadBalancingPolicy.java ---------------------------------------------------------------------- diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/loadbalance/RandomConnectionLoadBalancingPolicy.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/loadbalance/RandomConnectionLoadBalancingPolicy.java index 1710186..e672b1b 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/loadbalance/RandomConnectionLoadBalancingPolicy.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/loadbalance/RandomConnectionLoadBalancingPolicy.java @@ -22,17 +22,17 @@ import org.apache.activemq.artemis.utils.Random; * {@link RandomConnectionLoadBalancingPolicy#select(int)} returns a (pseudo) random integer between * {@code 0} (inclusive) and {@code max} (exclusive). */ -public final class RandomConnectionLoadBalancingPolicy implements ConnectionLoadBalancingPolicy -{ +public final class RandomConnectionLoadBalancingPolicy implements ConnectionLoadBalancingPolicy { + private final Random random = new Random(); /** * Returns a pseudo random number between {@code 0} (inclusive) and {@code max} exclusive. + * * @param max the upper limit of the random number selection * @see java.util.Random#nextInt(int) */ - public int select(final int max) - { + public int select(final int max) { return random.getRandom().nextInt(max); } } http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/bac96047/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/loadbalance/RandomStickyConnectionLoadBalancingPolicy.java ---------------------------------------------------------------------- diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/loadbalance/RandomStickyConnectionLoadBalancingPolicy.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/loadbalance/RandomStickyConnectionLoadBalancingPolicy.java index 3ce479b..556d33f 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/loadbalance/RandomStickyConnectionLoadBalancingPolicy.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/loadbalance/RandomStickyConnectionLoadBalancingPolicy.java @@ -21,8 +21,8 @@ import org.apache.activemq.artemis.utils.Random; /** * {@link RandomConnectionLoadBalancingPolicy#select(int)} chooses a the initial node randomly then subsequent requests return the same node */ -public final class RandomStickyConnectionLoadBalancingPolicy implements ConnectionLoadBalancingPolicy -{ +public final class RandomStickyConnectionLoadBalancingPolicy implements ConnectionLoadBalancingPolicy { + private final Random random = new Random(); private int pos = -1; @@ -30,10 +30,8 @@ public final class RandomStickyConnectionLoadBalancingPolicy implements Connecti /** * @see java.util.Random#nextInt(int) */ - public int select(final int max) - { - if (pos == -1) - { + public int select(final int max) { + if (pos == -1) { pos = random.getRandom().nextInt(max); } http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/bac96047/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/loadbalance/RoundRobinConnectionLoadBalancingPolicy.java ---------------------------------------------------------------------- diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/loadbalance/RoundRobinConnectionLoadBalancingPolicy.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/loadbalance/RoundRobinConnectionLoadBalancingPolicy.java index 40e0242..1af74f4 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/loadbalance/RoundRobinConnectionLoadBalancingPolicy.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/loadbalance/RoundRobinConnectionLoadBalancingPolicy.java @@ -27,8 +27,8 @@ import org.apache.activemq.artemis.utils.Random; * The first call to {@link #select(int)} will return a random integer between {@code 0} (inclusive) and {@code max} (exclusive). * Subsequent calls will then return an integer in a round-robin fashion. */ -public final class RoundRobinConnectionLoadBalancingPolicy implements ConnectionLoadBalancingPolicy, Serializable -{ +public final class RoundRobinConnectionLoadBalancingPolicy implements ConnectionLoadBalancingPolicy, Serializable { + private static final long serialVersionUID = 7511196010141439559L; private final Random random = new Random(); @@ -37,21 +37,17 @@ public final class RoundRobinConnectionLoadBalancingPolicy implements Connection private int pos; - public int select(final int max) - { - if (first) - { + public int select(final int max) { + if (first) { // We start on a random one pos = random.getRandom().nextInt(max); first = false; } - else - { + else { pos++; - if (pos >= max) - { + if (pos >= max) { pos = 0; } } http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/bac96047/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/AcceptorControl.java ---------------------------------------------------------------------- diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/AcceptorControl.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/AcceptorControl.java index 2806182..590850d 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/AcceptorControl.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/AcceptorControl.java @@ -21,8 +21,8 @@ import java.util.Map; /** * An AcceptorControl is used to manage Acceptors. */ -public interface AcceptorControl extends ActiveMQComponentControl -{ +public interface AcceptorControl extends ActiveMQComponentControl { + /** * Returns the name of the acceptor */ http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/bac96047/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ActiveMQComponentControl.java ---------------------------------------------------------------------- diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ActiveMQComponentControl.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ActiveMQComponentControl.java index 0343439..3fe0660 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ActiveMQComponentControl.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ActiveMQComponentControl.java @@ -19,8 +19,8 @@ package org.apache.activemq.artemis.api.core.management; /** * An ActiveMQComponentControl is used to manage the life cycle of an ActiveMQ Artemis component. */ -public interface ActiveMQComponentControl -{ +public interface ActiveMQComponentControl { + /** * Returns {@code true} if this component is started, {@code false} else. */ http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/bac96047/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ActiveMQServerControl.java ---------------------------------------------------------------------- diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ActiveMQServerControl.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ActiveMQServerControl.java index 138bc46..c474d1d 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ActiveMQServerControl.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ActiveMQServerControl.java @@ -21,8 +21,8 @@ import javax.management.MBeanOperationInfo; /** * An ActiveMQServerControl is used to manage ActiveMQ Artemis servers. */ -public interface ActiveMQServerControl -{ +public interface ActiveMQServerControl { + /** * Returns this server's version. */ @@ -132,7 +132,6 @@ public interface ActiveMQServerControl */ void setFailoverOnServerShutdown(boolean failoverOnServerShutdown) throws Exception; - /** * returns if clients failover on a server shutdown */ @@ -513,15 +512,14 @@ public interface ActiveMQServerControl void sendQueueInfoToQueue(String queueName, String address) throws Exception; @Operation(desc = "Add security settings for addresses matching the addressMatch", impact = MBeanOperationInfo.ACTION) - void addSecuritySettings( - @Parameter(desc = "an address match", name = "addressMatch") String addressMatch, - @Parameter(desc = "a comma-separated list of roles allowed to send messages", name = "send") String sendRoles, - @Parameter(desc = "a comma-separated list of roles allowed to consume messages", name = "consume") String consumeRoles, - @Parameter(desc = "a comma-separated list of roles allowed to create durable queues", name = "createDurableQueueRoles") String createDurableQueueRoles, - @Parameter(desc = "a comma-separated list of roles allowed to delete durable queues", name = "deleteDurableQueueRoles") String deleteDurableQueueRoles, - @Parameter(desc = "a comma-separated list of roles allowed to create non durable queues", name = "createNonDurableQueueRoles") String createNonDurableQueueRoles, - @Parameter(desc = "a comma-separated list of roles allowed to delete non durable queues", name = "deleteNonDurableQueueRoles") String deleteNonDurableQueueRoles, - @Parameter(desc = "a comma-separated list of roles allowed to send management messages messages", name = "manage") String manageRoles) throws Exception; + void addSecuritySettings(@Parameter(desc = "an address match", name = "addressMatch") String addressMatch, + @Parameter(desc = "a comma-separated list of roles allowed to send messages", name = "send") String sendRoles, + @Parameter(desc = "a comma-separated list of roles allowed to consume messages", name = "consume") String consumeRoles, + @Parameter(desc = "a comma-separated list of roles allowed to create durable queues", name = "createDurableQueueRoles") String createDurableQueueRoles, + @Parameter(desc = "a comma-separated list of roles allowed to delete durable queues", name = "deleteDurableQueueRoles") String deleteDurableQueueRoles, + @Parameter(desc = "a comma-separated list of roles allowed to create non durable queues", name = "createNonDurableQueueRoles") String createNonDurableQueueRoles, + @Parameter(desc = "a comma-separated list of roles allowed to delete non durable queues", name = "deleteNonDurableQueueRoles") String deleteNonDurableQueueRoles, + @Parameter(desc = "a comma-separated list of roles allowed to send management messages messages", name = "manage") String manageRoles) throws Exception; @Operation(desc = "Remove security settings for an address", impact = MBeanOperationInfo.ACTION) void removeSecuritySettings(@Parameter(desc = "an address match", name = "addressMatch") String addressMatch) throws Exception; @@ -600,7 +598,6 @@ public interface ActiveMQServerControl @Parameter(name = "user", desc = "User name") String user, @Parameter(name = "password", desc = "User password") String password) throws Exception; - @Operation(desc = "Destroy a bridge", impact = MBeanOperationInfo.ACTION) void destroyBridge(@Parameter(name = "name", desc = "Name of the bridge") String name) throws Exception; @@ -610,6 +607,6 @@ public interface ActiveMQServerControl void updateDuplicateIdCache(String address, Object[] ids) throws Exception; @Operation(desc = "force the server to stop and to scale down to another server", impact = MBeanOperationInfo.UNKNOWN) - void scaleDown(@Parameter(name = "name", desc = "The connector to use to scale down, if not provided the first appropriate connector will be used")String connector) throws Exception; + void scaleDown(@Parameter(name = "name", desc = "The connector to use to scale down, if not provided the first appropriate connector will be used") String connector) throws Exception; } http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/bac96047/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/AddressControl.java ---------------------------------------------------------------------- diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/AddressControl.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/AddressControl.java index 83866db..7d066bd 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/AddressControl.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/AddressControl.java @@ -16,14 +16,13 @@ */ package org.apache.activemq.artemis.api.core.management; - import javax.management.MBeanOperationInfo; /** * An AddressControl is used to manage an address. */ -public interface AddressControl -{ +public interface AddressControl { + /** * Returns the managed address. */ @@ -42,13 +41,12 @@ public interface AddressControl */ String getRolesAsJSON() throws Exception; - @Operation(desc = "returns the number of estimated bytes being used by the queue, used to control paging and blocking", - impact = MBeanOperationInfo.INFO) + impact = MBeanOperationInfo.INFO) long getAddressSize() throws Exception; @Operation(desc = "Returns the sum of messages on queues, including messages in delivery", - impact = MBeanOperationInfo.INFO) + impact = MBeanOperationInfo.INFO) long getNumberOfMessages() throws Exception; /** @@ -63,6 +61,7 @@ public interface AddressControl /** * Returns whether this address is paging. + * * @throws Exception */ boolean isPaging() throws Exception; http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/bac96047/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/AddressSettingsInfo.java ---------------------------------------------------------------------- diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/AddressSettingsInfo.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/AddressSettingsInfo.java index f827628..63b80cb 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/AddressSettingsInfo.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/AddressSettingsInfo.java @@ -19,8 +19,8 @@ package org.apache.activemq.artemis.api.core.management; import org.apache.activemq.artemis.utils.json.JSONObject; // XXX no javadocs -public final class AddressSettingsInfo -{ +public final class AddressSettingsInfo { + private final String addressFullMessagePolicy; private final long maxSizeBytes; @@ -59,27 +59,9 @@ public final class AddressSettingsInfo // Static -------------------------------------------------------- - public static AddressSettingsInfo from(final String jsonString) throws Exception - { + public static AddressSettingsInfo from(final String jsonString) throws Exception { JSONObject object = new JSONObject(jsonString); - return new AddressSettingsInfo(object.getString("addressFullMessagePolicy"), - object.getLong("maxSizeBytes"), - object.getInt("pageSizeBytes"), - object.getInt("pageCacheMaxSize"), - object.getInt("maxDeliveryAttempts"), - object.getLong("redeliveryDelay"), - object.getDouble("redeliveryMultiplier"), - object.getLong("maxRedeliveryDelay"), - object.getString("DLA"), - object.getString("expiryAddress"), - object.getBoolean("lastValueQueue"), - object.getLong("redistributionDelay"), - object.getBoolean("sendToDLAOnNoRoute"), - object.getLong("slowConsumerThreshold"), - object.getLong("slowConsumerCheckPeriod"), - object.getString("slowConsumerPolicy"), - object.getBoolean("autoCreateJmsQueues"), - object.getBoolean("autoDeleteJmsQueues")); + return new AddressSettingsInfo(object.getString("addressFullMessagePolicy"), object.getLong("maxSizeBytes"), object.getInt("pageSizeBytes"), object.getInt("pageCacheMaxSize"), object.getInt("maxDeliveryAttempts"), object.getLong("redeliveryDelay"), object.getDouble("redeliveryMultiplier"), object.getLong("maxRedeliveryDelay"), object.getString("DLA"), object.getString("expiryAddress"), object.getBoolean("lastValueQueue"), object.getLong("redistributionDelay"), object.getBoolean("sendToDLAOnNoRoute"), object.getLong("slowConsumerThreshold"), object.getLong("slowConsumerCheckPeriod"), object.getString("slowConsumerPolicy"), object.getBoolean("autoCreateJmsQueues"), object.getBoolean("autoDeleteJmsQueues")); } // Constructors -------------------------------------------------- @@ -101,8 +83,7 @@ public final class AddressSettingsInfo long slowConsumerCheckPeriod, String slowConsumerPolicy, boolean autoCreateJmsQueues, - boolean autoDeleteJmsQueues) - { + boolean autoDeleteJmsQueues) { this.addressFullMessagePolicy = addressFullMessagePolicy; this.maxSizeBytes = maxSizeBytes; this.pageSizeBytes = pageSizeBytes; @@ -125,98 +106,79 @@ public final class AddressSettingsInfo // Public -------------------------------------------------------- - public int getPageCacheMaxSize() - { + public int getPageCacheMaxSize() { return pageCacheMaxSize; } - public void setPageCacheMaxSize(int pageCacheMaxSize) - { + public void setPageCacheMaxSize(int pageCacheMaxSize) { this.pageCacheMaxSize = pageCacheMaxSize; } - public String getAddressFullMessagePolicy() - { + public String getAddressFullMessagePolicy() { return addressFullMessagePolicy; } - public long getMaxSizeBytes() - { + public long getMaxSizeBytes() { return maxSizeBytes; } - public int getPageSizeBytes() - { + public int getPageSizeBytes() { return pageSizeBytes; } - public int getMaxDeliveryAttempts() - { + public int getMaxDeliveryAttempts() { return maxDeliveryAttempts; } - public long getRedeliveryDelay() - { + public long getRedeliveryDelay() { return redeliveryDelay; } - public String getDeadLetterAddress() - { + public String getDeadLetterAddress() { return deadLetterAddress; } - public String getExpiryAddress() - { + public String getExpiryAddress() { return expiryAddress; } - public boolean isLastValueQueue() - { + public boolean isLastValueQueue() { return lastValueQueue; } - public long getRedistributionDelay() - { + public long getRedistributionDelay() { return redistributionDelay; } - public boolean isSendToDLAOnNoRoute() - { + public boolean isSendToDLAOnNoRoute() { return sendToDLAOnNoRoute; } - public double getRedeliveryMultiplier() - { + public double getRedeliveryMultiplier() { return redeliveryMultiplier; } - public long getMaxRedeliveryDelay() - { + public long getMaxRedeliveryDelay() { return maxRedeliveryDelay; } - public long getSlowConsumerThreshold() - { + public long getSlowConsumerThreshold() { return slowConsumerThreshold; } - public long getSlowConsumerCheckPeriod() - { + public long getSlowConsumerCheckPeriod() { return slowConsumerCheckPeriod; } - public String getSlowConsumerPolicy() - { + public String getSlowConsumerPolicy() { return slowConsumerPolicy; } - public boolean isAutoCreateJmsQueues() - { + public boolean isAutoCreateJmsQueues() { return autoCreateJmsQueues; } - public boolean isAutoDeleteJmsQueues() - { + public boolean isAutoDeleteJmsQueues() { return autoDeleteJmsQueues; } } http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/bac96047/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/BridgeControl.java ---------------------------------------------------------------------- diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/BridgeControl.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/BridgeControl.java index 52b97ae..0b17cef 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/BridgeControl.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/BridgeControl.java @@ -16,12 +16,11 @@ */ package org.apache.activemq.artemis.api.core.management; - /** * A BridgeControl is used to manage a Bridge. */ -public interface BridgeControl extends ActiveMQComponentControl -{ +public interface BridgeControl extends ActiveMQComponentControl { + /** * Returns the name of this bridge */ http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/bac96047/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/BroadcastGroupControl.java ---------------------------------------------------------------------- diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/BroadcastGroupControl.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/BroadcastGroupControl.java index 9f83ac9..53d5e09 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/BroadcastGroupControl.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/BroadcastGroupControl.java @@ -19,8 +19,8 @@ package org.apache.activemq.artemis.api.core.management; /** * A BroadcastGroupControl is used to manage a broadcast group. */ -public interface BroadcastGroupControl extends ActiveMQComponentControl -{ +public interface BroadcastGroupControl extends ActiveMQComponentControl { + /** * Returns the configuration name of this broadcast group. */ http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/bac96047/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ClusterConnectionControl.java ---------------------------------------------------------------------- diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ClusterConnectionControl.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ClusterConnectionControl.java index 5767bf6..53d19d4 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ClusterConnectionControl.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ClusterConnectionControl.java @@ -21,8 +21,8 @@ import java.util.Map; /** * A ClusterConnectionControl is used to manage a cluster connection. */ -public interface ClusterConnectionControl extends ActiveMQComponentControl -{ +public interface ClusterConnectionControl extends ActiveMQComponentControl { + /** * Returns the configuration name of this cluster connection. */ @@ -52,6 +52,7 @@ public interface ClusterConnectionControl extends ActiveMQComponentControl * Return the Topology that this Cluster Connection knows about */ String getTopology(); + /** * Returns the maximum number of hops used by this cluster connection. */ http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/bac96047/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java ---------------------------------------------------------------------- diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java index 724b1f9..105471c 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java @@ -19,8 +19,7 @@ package org.apache.activemq.artemis.api.core.management; /** * This enum defines all core notification types */ -public enum CoreNotificationType implements NotificationType -{ +public enum CoreNotificationType implements NotificationType { BINDING_ADDED(0), BINDING_REMOVED(1), CONSUMER_CREATED(2), @@ -44,13 +43,11 @@ public enum CoreNotificationType implements NotificationType private final int value; - private CoreNotificationType(final int value) - { + private CoreNotificationType(final int value) { this.value = value; } - public int getType() - { + public int getType() { return value; } } http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/bac96047/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/DayCounterInfo.java ---------------------------------------------------------------------- diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/DayCounterInfo.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/DayCounterInfo.java index fe2c466..422772f 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/DayCounterInfo.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/DayCounterInfo.java @@ -26,8 +26,7 @@ import org.apache.activemq.artemis.utils.json.JSONObject; * Helper class to create Java Objects from the * JSON serialization returned by {@link QueueControl#listMessageCounterHistory()}. */ -public final class DayCounterInfo -{ +public final class DayCounterInfo { private final String date; @@ -35,12 +34,10 @@ public final class DayCounterInfo // Static -------------------------------------------------------- - public static String toJSON(final DayCounterInfo[] infos) throws JSONException - { + public static String toJSON(final DayCounterInfo[] infos) throws JSONException { JSONObject json = new JSONObject(); JSONArray counters = new JSONArray(); - for (DayCounterInfo info : infos) - { + for (DayCounterInfo info : infos) { JSONObject counter = new JSONObject(); counter.put("date", info.getDate()); counter.put("counters", Arrays.asList(info.getCounters())); @@ -54,19 +51,16 @@ public final class DayCounterInfo * Returns an array of RoleInfo corresponding to the JSON serialization returned * by {@link QueueControl#listMessageCounterHistory()}. */ - public static DayCounterInfo[] fromJSON(final String jsonString) throws JSONException - { + public static DayCounterInfo[] fromJSON(final String jsonString) throws JSONException { JSONObject json = new JSONObject(jsonString); JSONArray dayCounters = json.getJSONArray("dayCounters"); DayCounterInfo[] infos = new DayCounterInfo[dayCounters.length()]; - for (int i = 0; i < dayCounters.length(); i++) - { + for (int i = 0; i < dayCounters.length(); i++) { - JSONObject counter = (JSONObject)dayCounters.get(i); - JSONArray hour = (JSONArray)counter.getJSONArray("counters").get(0); + JSONObject counter = (JSONObject) dayCounters.get(i); + JSONArray hour = (JSONArray) counter.getJSONArray("counters").get(0); int[] hourCounters = new int[24]; - for (int j = 0; j < 24; j++) - { + for (int j = 0; j < 24; j++) { hourCounters[j] = hour.getInt(j); } DayCounterInfo info = new DayCounterInfo(counter.getString("date"), hourCounters); @@ -77,8 +71,7 @@ public final class DayCounterInfo // Constructors -------------------------------------------------- - public DayCounterInfo(final String date, final int[] counters) - { + public DayCounterInfo(final String date, final int[] counters) { this.date = date; this.counters = counters; } @@ -88,8 +81,7 @@ public final class DayCounterInfo /** * Returns the date of the counter. */ - public String getDate() - { + public String getDate() { return date; } @@ -97,8 +89,7 @@ public final class DayCounterInfo * Returns a 24-length array corresponding to the number of messages added to the queue * for the given hour of the day. */ - public int[] getCounters() - { + public int[] getCounters() { return counters; } } http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/bac96047/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/DivertControl.java ---------------------------------------------------------------------- diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/DivertControl.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/DivertControl.java index e59b19f..3e5bca6 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/DivertControl.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/DivertControl.java @@ -19,8 +19,8 @@ package org.apache.activemq.artemis.api.core.management; /** * A DivertControl is used to manage a divert. */ -public interface DivertControl -{ +public interface DivertControl { + /** * Returns the filter used by this divert. */ http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/bac96047/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ManagementHelper.java ---------------------------------------------------------------------- diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ManagementHelper.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ManagementHelper.java index 23afbd9..8cd7e2e 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ManagementHelper.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ManagementHelper.java @@ -30,8 +30,7 @@ import org.apache.activemq.artemis.utils.json.JSONObject; /** * Helper class to use ActiveMQ Artemis Core messages to manage server resources. */ -public final class ManagementHelper -{ +public final class ManagementHelper { // Constants ----------------------------------------------------- public static final SimpleString HDR_RESOURCE_NAME = new SimpleString("_AMQ_ResourceName"); @@ -92,8 +91,7 @@ public final class ManagementHelper * @param attribute the name of the attribute * @see ResourceNames */ - public static void putAttribute(final Message message, final String resourceName, final String attribute) - { + public static void putAttribute(final Message message, final String resourceName, final String attribute) { message.putStringProperty(ManagementHelper.HDR_RESOURCE_NAME, new SimpleString(resourceName)); message.putStringProperty(ManagementHelper.HDR_ATTRIBUTE, new SimpleString(attribute)); } @@ -108,8 +106,7 @@ public final class ManagementHelper */ public static void putOperationInvocation(final Message message, final String resourceName, - final String operationName) throws Exception - { + final String operationName) throws Exception { ManagementHelper.putOperationInvocation(message, resourceName, operationName, (Object[]) null); } @@ -125,8 +122,7 @@ public final class ManagementHelper public static void putOperationInvocation(final Message message, final String resourceName, final String operationName, - final Object... parameters) throws Exception - { + final Object... parameters) throws Exception { // store the name of the operation in the headers message.putStringProperty(ManagementHelper.HDR_RESOURCE_NAME, new SimpleString(resourceName)); message.putStringProperty(ManagementHelper.HDR_OPERATION_NAME, new SimpleString(operationName)); @@ -135,46 +131,37 @@ public final class ManagementHelper String paramString; - if (parameters != null) - { + if (parameters != null) { JSONArray jsonArray = ManagementHelper.toJSONArray(parameters); paramString = jsonArray.toString(); } - else - { + else { paramString = null; } message.getBodyBuffer().writeNullableSimpleString(SimpleString.toSimpleString(paramString)); } - private static JSONArray toJSONArray(final Object[] array) throws Exception - { + private static JSONArray toJSONArray(final Object[] array) throws Exception { JSONArray jsonArray = new JSONArray(); - for (Object parameter : array) - { - if (parameter instanceof Map) - { + for (Object parameter : array) { + if (parameter instanceof Map) { Map map = (Map) parameter; JSONObject jsonObject = new JSONObject(); - for (Map.Entry entry : map.entrySet()) - { + for (Map.Entry entry : map.entrySet()) { String key = entry.getKey(); Object val = entry.getValue(); - if (val != null) - { - if (val.getClass().isArray()) - { + if (val != null) { + if (val.getClass().isArray()) { val = ManagementHelper.toJSONArray((Object[]) val); } - else - { + else { ManagementHelper.checkType(val); } } @@ -184,27 +171,22 @@ public final class ManagementHelper jsonArray.put(jsonObject); } - else - { - if (parameter != null) - { + else { + if (parameter != null) { Class clz = parameter.getClass(); - if (clz.isArray()) - { + if (clz.isArray()) { Object[] innerArray = (Object[]) parameter; jsonArray.put(ManagementHelper.toJSONArray(innerArray)); } - else - { + else { ManagementHelper.checkType(parameter); jsonArray.put(parameter); } } - else - { + else { jsonArray.put((Object) null); } } @@ -213,52 +195,43 @@ public final class ManagementHelper return jsonArray; } - private static Object[] fromJSONArray(final JSONArray jsonArray) throws Exception - { + private static Object[] fromJSONArray(final JSONArray jsonArray) throws Exception { Object[] array = new Object[jsonArray.length()]; - for (int i = 0; i < jsonArray.length(); i++) - { + for (int i = 0; i < jsonArray.length(); i++) { Object val = jsonArray.get(i); - if (val instanceof JSONArray) - { + if (val instanceof JSONArray) { Object[] inner = ManagementHelper.fromJSONArray((JSONArray) val); array[i] = inner; } - else if (val instanceof JSONObject) - { + else if (val instanceof JSONObject) { JSONObject jsonObject = (JSONObject) val; Map map = new HashMap(); Iterator iter = jsonObject.keys(); - while (iter.hasNext()) - { + while (iter.hasNext()) { String key = iter.next(); Object innerVal = jsonObject.get(key); - if (innerVal instanceof JSONArray) - { + if (innerVal instanceof JSONArray) { innerVal = ManagementHelper.fromJSONArray(((JSONArray) innerVal)); } - else if (innerVal instanceof JSONObject) - { + else if (innerVal instanceof JSONObject) { Map innerMap = new HashMap(); JSONObject o = (JSONObject) innerVal; Iterator it = o.keys(); - while (it.hasNext()) - { + while (it.hasNext()) { String k = (String) it.next(); innerMap.put(k, o.get(k)); } innerVal = innerMap; } - else if (innerVal instanceof Integer) - { + else if (innerVal instanceof Integer) { innerVal = ((Integer) innerVal).longValue(); } @@ -267,14 +240,11 @@ public final class ManagementHelper array[i] = map; } - else - { - if (val == JSONObject.NULL) - { + else { + if (val == JSONObject.NULL) { array[i] = null; } - else - { + else { array[i] = val; } } @@ -283,16 +253,14 @@ public final class ManagementHelper return array; } - private static void checkType(final Object param) - { + private static void checkType(final Object param) { if (param instanceof Integer == false && param instanceof Long == false && param instanceof Double == false && param instanceof String == false && param instanceof Boolean == false && param instanceof Map == false && param instanceof Byte == false && - param instanceof Short == false) - { + param instanceof Short == false) { throw ActiveMQClientMessageBundle.BUNDLE.invalidManagementParam(param.getClass().getName()); } } @@ -300,19 +268,16 @@ public final class ManagementHelper /** * Used by ActiveMQ Artemis management service. */ - public static Object[] retrieveOperationParameters(final Message message) throws Exception - { + public static Object[] retrieveOperationParameters(final Message message) throws Exception { SimpleString sstring = message.getBodyBuffer().readNullableSimpleString(); String jsonString = (sstring == null) ? null : sstring.toString(); - if (jsonString != null) - { + if (jsonString != null) { JSONArray jsonArray = new JSONArray(jsonString); return ManagementHelper.fromJSONArray(jsonArray); } - else - { + else { return null; } } @@ -320,36 +285,31 @@ public final class ManagementHelper /** * Returns whether the JMS message corresponds to the result of a management operation invocation. */ - public static boolean isOperationResult(final Message message) - { + public static boolean isOperationResult(final Message message) { return message.containsProperty(ManagementHelper.HDR_OPERATION_SUCCEEDED); } /** * Returns whether the JMS message corresponds to the result of a management attribute value. */ - public static boolean isAttributesResult(final Message message) - { + public static boolean isAttributesResult(final Message message) { return !ManagementHelper.isOperationResult(message); } /** * Used by ActiveMQ Artemis management service. */ - public static void storeResult(final Message message, final Object result) throws Exception - { + public static void storeResult(final Message message, final Object result) throws Exception { String resultString; - if (result != null) - { + if (result != null) { // Result is stored in body, also encoded as JSON array of length 1 JSONArray jsonArray = ManagementHelper.toJSONArray(new Object[]{result}); resultString = jsonArray.toString(); } - else - { + else { resultString = null; } @@ -362,21 +322,18 @@ public final class ManagementHelper * If an error occurred on the server, {@link #hasOperationSucceeded(Message)} will return {@code false}. * and the result will be a String corresponding to the server exception. */ - public static Object[] getResults(final Message message) throws Exception - { + public static Object[] getResults(final Message message) throws Exception { SimpleString sstring = message.getBodyBuffer().readNullableSimpleString(); String jsonString = (sstring == null) ? null : sstring.toString(); - if (jsonString != null) - { + if (jsonString != null) { JSONArray jsonArray = new JSONArray(jsonString); Object[] res = ManagementHelper.fromJSONArray(jsonArray); return res; } - else - { + else { return null; } } @@ -387,16 +344,13 @@ public final class ManagementHelper * If an error occurred on the server, {@link #hasOperationSucceeded(Message)} will return {@code false}. * and the result will be a String corresponding to the server exception. */ - public static Object getResult(final Message message) throws Exception - { + public static Object getResult(final Message message) throws Exception { Object[] res = ManagementHelper.getResults(message); - if (res != null) - { + if (res != null) { return res[0]; } - else - { + else { return null; } } @@ -404,14 +358,11 @@ public final class ManagementHelper /** * Returns whether the invocation of the management operation on the server resource succeeded. */ - public static boolean hasOperationSucceeded(final Message message) - { - if (!ManagementHelper.isOperationResult(message)) - { + public static boolean hasOperationSucceeded(final Message message) { + if (!ManagementHelper.isOperationResult(message)) { return false; } - if (message.containsProperty(ManagementHelper.HDR_OPERATION_SUCCEEDED)) - { + if (message.containsProperty(ManagementHelper.HDR_OPERATION_SUCCEEDED)) { return message.getBooleanProperty(ManagementHelper.HDR_OPERATION_SUCCEEDED); } return false; @@ -420,10 +371,8 @@ public final class ManagementHelper /** * Used by ActiveMQ Artemis management service. */ - public static Map fromCommaSeparatedKeyValues(final String str) throws Exception - { - if (str == null || str.trim().length() == 0) - { + public static Map fromCommaSeparatedKeyValues(final String str) throws Exception { + if (str == null || str.trim().length() == 0) { return Collections.emptyMap(); } @@ -436,25 +385,21 @@ public final class ManagementHelper /** * Used by ActiveMQ Artemis management service. */ - public static Object[] fromCommaSeparatedArrayOfCommaSeparatedKeyValues(final String str) throws Exception - { - if (str == null || str.trim().length() == 0) - { + public static Object[] fromCommaSeparatedArrayOfCommaSeparatedKeyValues(final String str) throws Exception { + if (str == null || str.trim().length() == 0) { return new Object[0]; } String s = str; // if there is a single item, we wrap it in to make it a JSON object - if (!s.trim().startsWith("{")) - { + if (!s.trim().startsWith("{")) { s = "{" + s + "}"; } JSONArray array = new JSONArray("[" + s + "]"); return ManagementHelper.fromJSONArray(array); } - private ManagementHelper() - { + private ManagementHelper() { } } http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/bac96047/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/NotificationType.java ---------------------------------------------------------------------- diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/NotificationType.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/NotificationType.java index 07fa280..4952179 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/NotificationType.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/NotificationType.java @@ -27,7 +27,7 @@ package org.apache.activemq.artemis.api.core.management; * * see the ActiveMQ Artemis user manual section on "Management Notifications" */ -public interface NotificationType -{ +public interface NotificationType { + int getType(); } \ No newline at end of file http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/bac96047/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ObjectNameBuilder.java ---------------------------------------------------------------------- diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ObjectNameBuilder.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ObjectNameBuilder.java index 867d87e..d9ca3f9 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ObjectNameBuilder.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ObjectNameBuilder.java @@ -24,8 +24,7 @@ import org.apache.activemq.artemis.api.config.ActiveMQDefaultConfiguration; /** * Helper class to build ObjectNames for ActiveMQ Artemis resources. */ -public final class ObjectNameBuilder -{ +public final class ObjectNameBuilder { // Constants ----------------------------------------------------- @@ -44,22 +43,18 @@ public final class ObjectNameBuilder // Static -------------------------------------------------------- - public static ObjectNameBuilder create(final String domain) - { - if (domain == null) - { + public static ObjectNameBuilder create(final String domain) { + if (domain == null) { return new ObjectNameBuilder(ActiveMQDefaultConfiguration.getDefaultJmxDomain()); } - else - { + else { return new ObjectNameBuilder(domain); } } // Constructors -------------------------------------------------- - private ObjectNameBuilder(final String domain) - { + private ObjectNameBuilder(final String domain) { this.domain = domain; } @@ -68,8 +63,7 @@ public final class ObjectNameBuilder /** * Returns the ObjectName used by the single {@link ActiveMQServerControl}. */ - public ObjectName getActiveMQServerObjectName() throws Exception - { + public ObjectName getActiveMQServerObjectName() throws Exception { return ObjectName.getInstance(domain + ":module=Core,type=Server"); } @@ -78,8 +72,7 @@ public final class ObjectNameBuilder * * @see AddressControl */ - public ObjectName getAddressObjectName(final SimpleString address) throws Exception - { + public ObjectName getAddressObjectName(final SimpleString address) throws Exception { return createObjectName(ObjectNameBuilder.CORE_MODULE, "Address", address.toString()); } @@ -88,14 +81,8 @@ public final class ObjectNameBuilder * * @see QueueControl */ - public ObjectName getQueueObjectName(final SimpleString address, final SimpleString name) throws Exception - { - return ObjectName.getInstance(String.format("%s:module=%s,type=%s,address=%s,name=%s", - domain, - ObjectNameBuilder.CORE_MODULE, - "Queue", - ObjectName.quote(address.toString()), - ObjectName.quote(name.toString()))); + public ObjectName getQueueObjectName(final SimpleString address, final SimpleString name) throws Exception { + return ObjectName.getInstance(String.format("%s:module=%s,type=%s,address=%s,name=%s", domain, ObjectNameBuilder.CORE_MODULE, "Queue", ObjectName.quote(address.toString()), ObjectName.quote(name.toString()))); } /** @@ -103,8 +90,7 @@ public final class ObjectNameBuilder * * @see DivertControl */ - public ObjectName getDivertObjectName(final String name) throws Exception - { + public ObjectName getDivertObjectName(final String name) throws Exception { return createObjectName(ObjectNameBuilder.CORE_MODULE, "Divert", name.toString()); } @@ -113,8 +99,7 @@ public final class ObjectNameBuilder * * @see AcceptorControl */ - public ObjectName getAcceptorObjectName(final String name) throws Exception - { + public ObjectName getAcceptorObjectName(final String name) throws Exception { return createObjectName(ObjectNameBuilder.CORE_MODULE, "Acceptor", name); } @@ -123,8 +108,7 @@ public final class ObjectNameBuilder * * @see BroadcastGroupControl */ - public ObjectName getBroadcastGroupObjectName(final String name) throws Exception - { + public ObjectName getBroadcastGroupObjectName(final String name) throws Exception { return createObjectName(ObjectNameBuilder.CORE_MODULE, "BroadcastGroup", name); } @@ -133,8 +117,7 @@ public final class ObjectNameBuilder * * @see BridgeControl */ - public ObjectName getBridgeObjectName(final String name) throws Exception - { + public ObjectName getBridgeObjectName(final String name) throws Exception { return createObjectName(ObjectNameBuilder.CORE_MODULE, "Bridge", name); } @@ -143,57 +126,46 @@ public final class ObjectNameBuilder * * @see ClusterConnectionControl */ - public ObjectName getClusterConnectionObjectName(final String name) throws Exception - { + public ObjectName getClusterConnectionObjectName(final String name) throws Exception { return createObjectName(ObjectNameBuilder.CORE_MODULE, "ClusterConnection", name); } /** * Returns the ObjectName used by DiscoveryGroupControl. */ - public ObjectName getDiscoveryGroupObjectName(final String name) throws Exception - { + public ObjectName getDiscoveryGroupObjectName(final String name) throws Exception { return createObjectName(ObjectNameBuilder.CORE_MODULE, "DiscoveryGroup", name); } /** * Returns the ObjectName used by JMSServerControl. */ - public ObjectName getJMSServerObjectName() throws Exception - { + public ObjectName getJMSServerObjectName() throws Exception { return ObjectName.getInstance(domain + ":module=JMS,type=Server"); } /** * Returns the ObjectName used by JMSQueueControl. */ - public ObjectName getJMSQueueObjectName(final String name) throws Exception - { + public ObjectName getJMSQueueObjectName(final String name) throws Exception { return createObjectName(ObjectNameBuilder.JMS_MODULE, "Queue", name); } /** * Returns the ObjectName used by TopicControl. */ - public ObjectName getJMSTopicObjectName(final String name) throws Exception - { + public ObjectName getJMSTopicObjectName(final String name) throws Exception { return createObjectName(ObjectNameBuilder.JMS_MODULE, "Topic", name); } /** * Returns the ObjectName used by ConnectionFactoryControl. */ - public ObjectName getConnectionFactoryObjectName(final String name) throws Exception - { + public ObjectName getConnectionFactoryObjectName(final String name) throws Exception { return createObjectName(ObjectNameBuilder.JMS_MODULE, "ConnectionFactory", name); } - private ObjectName createObjectName(final String module, final String type, final String name) throws Exception - { - return ObjectName.getInstance(String.format("%s:module=%s,type=%s,name=%s", - domain, - module, - type, - ObjectName.quote(name))); + private ObjectName createObjectName(final String module, final String type, final String name) throws Exception { + return ObjectName.getInstance(String.format("%s:module=%s,type=%s,name=%s", domain, module, type, ObjectName.quote(name))); } } http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/bac96047/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/Operation.java ---------------------------------------------------------------------- diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/Operation.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/Operation.java index ee709bf..5495f5a 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/Operation.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/Operation.java @@ -33,8 +33,8 @@ import javax.management.MBeanOperationInfo; @Retention(RetentionPolicy.RUNTIME) @Target(ElementType.METHOD) @Inherited -public @interface Operation -{ +public @interface Operation { + String desc(); int impact() default MBeanOperationInfo.INFO; http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/bac96047/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/Parameter.java ---------------------------------------------------------------------- diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/Parameter.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/Parameter.java index a3d8c0e..24a7b1f 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/Parameter.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/Parameter.java @@ -29,8 +29,8 @@ import java.lang.annotation.Target; */ @Retention(RetentionPolicy.RUNTIME) @Target(ElementType.PARAMETER) -public @interface Parameter -{ +public @interface Parameter { + String name(); String desc() default "N/A"; http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/bac96047/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/QueueControl.java ---------------------------------------------------------------------- diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/QueueControl.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/QueueControl.java index 1813d84..8d211ca 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/QueueControl.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/QueueControl.java @@ -19,12 +19,10 @@ package org.apache.activemq.artemis.api.core.management; import javax.management.MBeanOperationInfo; import java.util.Map; - /** * A QueueControl is used to manage a queue. */ -public interface QueueControl -{ +public interface QueueControl { // Attributes ---------------------------------------------------- /** @@ -249,7 +247,6 @@ public interface QueueControl int moveMessages(@Parameter(name = "filter", desc = "A message filter (can be empty)") String filter, @Parameter(name = "otherQueueName", desc = "The name of the queue to move the messages to") String otherQueueName) throws Exception; - /** * Moves all the message corresponding to the specified filter to the specified other queue. *
http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/bac96047/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ResourceNames.java ---------------------------------------------------------------------- diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ResourceNames.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ResourceNames.java index 55957f8..37f74ed 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ResourceNames.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ResourceNames.java @@ -22,8 +22,7 @@ package org.apache.activemq.artemis.api.core.management; * Resource's name is build by appending its name to its corresponding type. * For example, the resource name of the "foo" queue is {@code CORE_QUEUE + "foo"}. */ -public final class ResourceNames -{ +public final class ResourceNames { public static final String CORE_SERVER = "core.server"; @@ -51,8 +50,7 @@ public final class ResourceNames public static final String JMS_CONNECTION_FACTORY = "jms.connectionfactory."; - private ResourceNames() - { + private ResourceNames() { } } http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/bac96047/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/RoleInfo.java ---------------------------------------------------------------------- diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/RoleInfo.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/RoleInfo.java index 42c5fe9..a1e82a4 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/RoleInfo.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/RoleInfo.java @@ -23,8 +23,8 @@ import org.apache.activemq.artemis.utils.json.JSONObject; * Helper class to create Java Objects from the * JSON serialization returned by {@link AddressControl#getRolesAsJSON()}. */ -public final class RoleInfo -{ +public final class RoleInfo { + private final String name; private final boolean send; @@ -45,21 +45,12 @@ public final class RoleInfo * Returns an array of RoleInfo corresponding to the JSON serialization returned * by {@link AddressControl#getRolesAsJSON()}. */ - public static RoleInfo[] from(final String jsonString) throws Exception - { + public static RoleInfo[] from(final String jsonString) throws Exception { JSONArray array = new JSONArray(jsonString); RoleInfo[] roles = new RoleInfo[array.length()]; - for (int i = 0; i < array.length(); i++) - { + for (int i = 0; i < array.length(); i++) { JSONObject r = array.getJSONObject(i); - RoleInfo role = new RoleInfo(r.getString("name"), - r.getBoolean("send"), - r.getBoolean("consume"), - r.getBoolean("createDurableQueue"), - r.getBoolean("deleteDurableQueue"), - r.getBoolean("createNonDurableQueue"), - r.getBoolean("deleteNonDurableQueue"), - r.getBoolean("manage")); + RoleInfo role = new RoleInfo(r.getString("name"), r.getBoolean("send"), r.getBoolean("consume"), r.getBoolean("createDurableQueue"), r.getBoolean("deleteDurableQueue"), r.getBoolean("createNonDurableQueue"), r.getBoolean("deleteNonDurableQueue"), r.getBoolean("manage")); roles[i] = role; } return roles; @@ -72,8 +63,7 @@ public final class RoleInfo final boolean deleteDurableQueue, final boolean createNonDurableQueue, final boolean deleteNonDurableQueue, - final boolean manage) - { + final boolean manage) { this.name = name; this.send = send; this.consume = consume; @@ -87,64 +77,56 @@ public final class RoleInfo /** * Returns the name of the role. */ - public String getName() - { + public String getName() { return name; } /** * Returns whether this role can send messages to the address. */ - public boolean isSend() - { + public boolean isSend() { return send; } /** * Returns whether this role can consume messages from queues bound to the address. */ - public boolean isConsume() - { + public boolean isConsume() { return consume; } /** * Returns whether this role can create durable queues bound to the address. */ - public boolean isCreateDurableQueue() - { + public boolean isCreateDurableQueue() { return createDurableQueue; } /** * Returns whether this role can delete durable queues bound to the address. */ - public boolean isDeleteDurableQueue() - { + public boolean isDeleteDurableQueue() { return deleteDurableQueue; } /** * Returns whether this role can create non-durable queues bound to the address. */ - public boolean isCreateNonDurableQueue() - { + public boolean isCreateNonDurableQueue() { return createNonDurableQueue; } /** * Returns whether this role can delete non-durable queues bound to the address. */ - public boolean isDeleteNonDurableQueue() - { + public boolean isDeleteNonDurableQueue() { return deleteNonDurableQueue; } /** * Returns whether this role can send management messages to the address. */ - public boolean isManage() - { + public boolean isManage() { return manage; } } http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/bac96047/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/buffers/impl/ResetLimitWrappedActiveMQBuffer.java ---------------------------------------------------------------------- diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/buffers/impl/ResetLimitWrappedActiveMQBuffer.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/buffers/impl/ResetLimitWrappedActiveMQBuffer.java index 9ab6b2f..b3cdfe1 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/buffers/impl/ResetLimitWrappedActiveMQBuffer.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/buffers/impl/ResetLimitWrappedActiveMQBuffer.java @@ -25,10 +25,9 @@ import org.apache.activemq.artemis.core.message.impl.MessageInternal; /** * A ResetLimitWrappedActiveMQBuffer * TODO: Move this to commons - * */ -public final class ResetLimitWrappedActiveMQBuffer extends ChannelBufferWrapper -{ +public final class ResetLimitWrappedActiveMQBuffer extends ChannelBufferWrapper { + private final int limit; private MessageInternal message; @@ -36,23 +35,21 @@ public final class ResetLimitWrappedActiveMQBuffer extends ChannelBufferWrapper /** * We need to turn of notifications of body changes on reset on the server side when dealing with AMQP conversions, * for that reason this method will set the message to null here + * * @param message */ - public void setMessage(MessageInternal message) - { + public void setMessage(MessageInternal message) { this.message = message; } - public ResetLimitWrappedActiveMQBuffer(final int limit, final ActiveMQBuffer buffer, final MessageInternal message) - { + public ResetLimitWrappedActiveMQBuffer(final int limit, final ActiveMQBuffer buffer, final MessageInternal message) { // a wrapped inside a wrapper will increase the stack size. // we fixed this here due to some profiling testing super(unwrap(buffer.byteBuf())); this.limit = limit; - if (writerIndex() < limit) - { + if (writerIndex() < limit) { writerIndex(limit); } @@ -61,26 +58,21 @@ public final class ResetLimitWrappedActiveMQBuffer extends ChannelBufferWrapper this.message = message; } - private void changed() - { - if (message != null) - { + private void changed() { + if (message != null) { message.bodyChanged(); } } - public void setBuffer(final ActiveMQBuffer buffer) - { - if (this.buffer != null) - { + public void setBuffer(final ActiveMQBuffer buffer) { + if (this.buffer != null) { this.buffer.release(); } this.buffer = buffer.byteBuf(); } @Override - public void clear() - { + public void clear() { changed(); buffer.clear(); @@ -90,12 +82,10 @@ public final class ResetLimitWrappedActiveMQBuffer extends ChannelBufferWrapper } @Override - public void readerIndex(int readerIndex) - { + public void readerIndex(int readerIndex) { changed(); - if (readerIndex < limit) - { + if (readerIndex < limit) { readerIndex = limit; } @@ -103,44 +93,37 @@ public final class ResetLimitWrappedActiveMQBuffer extends ChannelBufferWrapper } @Override - public void resetReaderIndex() - { + public void resetReaderIndex() { changed(); buffer.readerIndex(limit); } @Override - public void resetWriterIndex() - { + public void resetWriterIndex() { changed(); buffer.writerIndex(limit); } @Override - public void setIndex(int readerIndex, int writerIndex) - { + public void setIndex(int readerIndex, int writerIndex) { changed(); - if (readerIndex < limit) - { + if (readerIndex < limit) { readerIndex = limit; } - if (writerIndex < limit) - { + if (writerIndex < limit) { writerIndex = limit; } buffer.setIndex(readerIndex, writerIndex); } @Override - public void writerIndex(int writerIndex) - { + public void writerIndex(int writerIndex) { changed(); - if (writerIndex < limit) - { + if (writerIndex < limit) { writerIndex = limit; } @@ -148,248 +131,217 @@ public final class ResetLimitWrappedActiveMQBuffer extends ChannelBufferWrapper } @Override - public void setByte(final int index, final byte value) - { + public void setByte(final int index, final byte value) { changed(); super.setByte(index, value); } @Override - public void setBytes(final int index, final byte[] src, final int srcIndex, final int length) - { + public void setBytes(final int index, final byte[] src, final int srcIndex, final int length) { changed(); super.setBytes(index, src, srcIndex, length); } @Override - public void setBytes(final int index, final byte[] src) - { + public void setBytes(final int index, final byte[] src) { changed(); super.setBytes(index, src); } @Override - public void setBytes(final int index, final ByteBuffer src) - { + public void setBytes(final int index, final ByteBuffer src) { changed(); super.setBytes(index, src); } @Override - public void setBytes(final int index, final ActiveMQBuffer src, final int srcIndex, final int length) - { + public void setBytes(final int index, final ActiveMQBuffer src, final int srcIndex, final int length) { changed(); super.setBytes(index, src, srcIndex, length); } @Override - public void setBytes(final int index, final ActiveMQBuffer src, final int length) - { + public void setBytes(final int index, final ActiveMQBuffer src, final int length) { changed(); super.setBytes(index, src, length); } @Override - public void setBytes(final int index, final ActiveMQBuffer src) - { + public void setBytes(final int index, final ActiveMQBuffer src) { changed(); super.setBytes(index, src); } @Override - public void setChar(final int index, final char value) - { + public void setChar(final int index, final char value) { changed(); super.setChar(index, value); } @Override - public void setDouble(final int index, final double value) - { + public void setDouble(final int index, final double value) { changed(); super.setDouble(index, value); } @Override - public void setFloat(final int index, final float value) - { + public void setFloat(final int index, final float value) { changed(); super.setFloat(index, value); } @Override - public void setInt(final int index, final int value) - { + public void setInt(final int index, final int value) { changed(); super.setInt(index, value); } @Override - public void setLong(final int index, final long value) - { + public void setLong(final int index, final long value) { changed(); super.setLong(index, value); } @Override - public void setShort(final int index, final short value) - { + public void setShort(final int index, final short value) { changed(); super.setShort(index, value); } @Override - public void writeBoolean(final boolean val) - { + public void writeBoolean(final boolean val) { changed(); super.writeBoolean(val); } @Override - public void writeByte(final byte value) - { + public void writeByte(final byte value) { changed(); super.writeByte(value); } @Override - public void writeBytes(final byte[] src, final int srcIndex, final int length) - { + public void writeBytes(final byte[] src, final int srcIndex, final int length) { changed(); super.writeBytes(src, srcIndex, length); } @Override - public void writeBytes(final byte[] src) - { + public void writeBytes(final byte[] src) { changed(); super.writeBytes(src); } @Override - public void writeBytes(final ByteBuffer src) - { + public void writeBytes(final ByteBuffer src) { changed(); super.writeBytes(src); } @Override - public void writeBytes(final ActiveMQBuffer src, final int srcIndex, final int length) - { + public void writeBytes(final ActiveMQBuffer src, final int srcIndex, final int length) { changed(); super.writeBytes(src, srcIndex, length); } @Override - public void writeBytes(final ActiveMQBuffer src, final int length) - { + public void writeBytes(final ActiveMQBuffer src, final int length) { changed(); super.writeBytes(src, length); } @Override - public void writeChar(final char chr) - { + public void writeChar(final char chr) { changed(); super.writeChar(chr); } @Override - public void writeDouble(final double value) - { + public void writeDouble(final double value) { changed(); super.writeDouble(value); } @Override - public void writeFloat(final float value) - { + public void writeFloat(final float value) { changed(); super.writeFloat(value); } @Override - public void writeInt(final int value) - { + public void writeInt(final int value) { changed(); super.writeInt(value); } @Override - public void writeLong(final long value) - { + public void writeLong(final long value) { changed(); super.writeLong(value); } @Override - public void writeNullableSimpleString(final SimpleString val) - { + public void writeNullableSimpleString(final SimpleString val) { changed(); super.writeNullableSimpleString(val); } @Override - public void writeNullableString(final String val) - { + public void writeNullableString(final String val) { changed(); super.writeNullableString(val); } @Override - public void writeShort(final short value) - { + public void writeShort(final short value) { changed(); super.writeShort(value); } @Override - public void writeSimpleString(final SimpleString val) - { + public void writeSimpleString(final SimpleString val) { changed(); super.writeSimpleString(val); } @Override - public void writeString(final String val) - { + public void writeString(final String val) { changed(); super.writeString(val); } @Override - public void writeUTF(final String utf) - { + public void writeUTF(final String utf) { changed(); super.writeUTF(utf); http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/bac96047/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/ActiveMQClientLogger.java ---------------------------------------------------------------------- diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/ActiveMQClientLogger.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/ActiveMQClientLogger.java index 8b3d0da..901797c 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/ActiveMQClientLogger.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/ActiveMQClientLogger.java @@ -47,8 +47,8 @@ import org.w3c.dom.Node; * articles. Unused methods should be marked as deprecated. */ @MessageLogger(projectCode = "AMQ") -public interface ActiveMQClientLogger extends BasicLogger -{ +public interface ActiveMQClientLogger extends BasicLogger { + /** * The default logger. */ @@ -92,15 +92,14 @@ public interface ActiveMQClientLogger extends BasicLogger @LogMessage(level = Logger.Level.WARN) @Message(id = 212007, - value = "connector.create or connectorFactory.createConnector should never throw an exception, implementation is badly behaved, but we will deal with it anyway.", - format = Message.Format.MESSAGE_FORMAT) + value = "connector.create or connectorFactory.createConnector should never throw an exception, implementation is badly behaved, but we will deal with it anyway.", + format = Message.Format.MESSAGE_FORMAT) void createConnectorException(@Cause Exception e); @LogMessage(level = Logger.Level.WARN) @Message(id = 212008, - value = "I am closing a core ClientSessionFactory you left open. Please make sure you close all ClientSessionFactories explicitly " - + "before letting them go out of scope! {0}", - format = Message.Format.MESSAGE_FORMAT) + value = "I am closing a core ClientSessionFactory you left open. Please make sure you close all ClientSessionFactories explicitly " + "before letting them go out of scope! {0}", + format = Message.Format.MESSAGE_FORMAT) void factoryLeftOpen(@Cause Exception e, int i); @LogMessage(level = Logger.Level.WARN) @@ -129,8 +128,8 @@ public interface ActiveMQClientLogger extends BasicLogger @LogMessage(level = Logger.Level.WARN) @Message(id = 212016, - value = "I am closing a core ClientSession you left open. Please make sure you close all ClientSessions explicitly before letting them go out of scope! {0}", - format = Message.Format.MESSAGE_FORMAT) + value = "I am closing a core ClientSession you left open. Please make sure you close all ClientSessions explicitly before letting them go out of scope! {0}", + format = Message.Format.MESSAGE_FORMAT) void clientSessionNotClosed(@Cause Exception e, int identity); @LogMessage(level = Logger.Level.WARN) @@ -183,8 +182,8 @@ public interface ActiveMQClientLogger extends BasicLogger @LogMessage(level = Logger.Level.DEBUG) @Message(id = 212029, - value = "Closing a Server Locator left open. Please make sure you close all Server Locators explicitly before letting them go out of scope! {0}", - format = Message.Format.MESSAGE_FORMAT) + value = "Closing a Server Locator left open. Please make sure you close all Server Locators explicitly before letting them go out of scope! {0}", + format = Message.Format.MESSAGE_FORMAT) void serverLocatorNotClosed(@Cause Exception e, int identity); @LogMessage(level = Logger.Level.WARN) @@ -205,12 +204,8 @@ public interface ActiveMQClientLogger extends BasicLogger @LogMessage(level = Logger.Level.WARN) @Message(id = 212034, - value = "There are more than one servers on the network broadcasting the same node id. " - + "You will see this message exactly once (per node) if a node is restarted, in which case it can be safely " - + "ignored. But if it is logged continuously it means you really do have more than one node on the same network " - + "active concurrently with the same node id. This could occur if you have a backup node active at the same time as " - + "its live node. nodeID={0}", - format = Message.Format.MESSAGE_FORMAT) + value = "There are more than one servers on the network broadcasting the same node id. " + "You will see this message exactly once (per node) if a node is restarted, in which case it can be safely " + "ignored. But if it is logged continuously it means you really do have more than one node on the same network " + "active concurrently with the same node id. This could occur if you have a backup node active at the same time as " + "its live node. nodeID={0}", + format = Message.Format.MESSAGE_FORMAT) void multipleServersBroadcastingSameNode(String nodeId); @LogMessage(level = Logger.Level.WARN) @@ -219,8 +214,8 @@ public interface ActiveMQClientLogger extends BasicLogger @LogMessage(level = Logger.Level.WARN) @Message(id = 212036, - value = "Can not find packet to clear: {0} last received command id first stored command id {1}", - format = Message.Format.MESSAGE_FORMAT) + value = "Can not find packet to clear: {0} last received command id first stored command id {1}", + format = Message.Format.MESSAGE_FORMAT) void cannotFindPacketToClear(Integer lastReceivedCommandID, Integer firstStoredCommandID); @LogMessage(level = Logger.Level.WARN) @@ -257,7 +252,7 @@ public interface ActiveMQClientLogger extends BasicLogger @LogMessage(level = Logger.Level.WARN) @Message(id = 212046, value = "Cannot find activemq-version.properties on classpath: {0}", - format = Message.Format.MESSAGE_FORMAT) + format = Message.Format.MESSAGE_FORMAT) void noVersionOnClasspath(String classpath); @LogMessage(level = Logger.Level.WARN) @@ -266,32 +261,32 @@ public interface ActiveMQClientLogger extends BasicLogger @LogMessage(level = Logger.Level.WARN) @Message(id = 212048, value = "local-bind-address specified for broadcast group but no local-bind-port specified so socket will NOT be bound to a local address/port", - format = Message.Format.MESSAGE_FORMAT) + format = Message.Format.MESSAGE_FORMAT) void broadcastGroupBindError(); @LogMessage(level = Logger.Level.WARN) @Message(id = 212049, - value = "Could not bind to {0} ({1} address); " + - "make sure your discovery group-address is of the same type as the IP stack (IPv4 or IPv6)." + - "\nIgnoring discovery group-address, but this may lead to cross talking.", - format = Message.Format.MESSAGE_FORMAT) + value = "Could not bind to {0} ({1} address); " + + "make sure your discovery group-address is of the same type as the IP stack (IPv4 or IPv6)." + + "\nIgnoring discovery group-address, but this may lead to cross talking.", + format = Message.Format.MESSAGE_FORMAT) void ioDiscoveryError(String hostAddress, String s); @LogMessage(level = Logger.Level.WARN) @Message(id = 212050, value = "Compressed large message tried to read {0} bytes from stream {1}", - format = Message.Format.MESSAGE_FORMAT) + format = Message.Format.MESSAGE_FORMAT) void compressedLargeMessageError(int length, int nReadBytes); @LogMessage(level = Logger.Level.WARN) @Message(id = 212051, - value = "Invalid concurrent session usage. Sessions are not supposed to be used by more than one thread concurrently.", - format = Message.Format.MESSAGE_FORMAT) + value = "Invalid concurrent session usage. Sessions are not supposed to be used by more than one thread concurrently.", + format = Message.Format.MESSAGE_FORMAT) void invalidConcurrentSessionUsage(@Cause Throwable t); @LogMessage(level = Logger.Level.WARN) @Message(id = 212052, - value = "Packet {0} was answered out of sequence due to a previous server timeout and it''s being ignored", - format = Message.Format.MESSAGE_FORMAT) + value = "Packet {0} was answered out of sequence due to a previous server timeout and it''s being ignored", + format = Message.Format.MESSAGE_FORMAT) void packetOutOfOrder(Object obj, @Cause Throwable t); /** @@ -300,15 +295,14 @@ public interface ActiveMQClientLogger extends BasicLogger */ @LogMessage(level = Logger.Level.WARN) @Message(id = 212053, - value = "CompletionListener/SendAcknowledgementHandler used with confirmationWindowSize=-1. Enable confirmationWindowSize to receive acks from server!", - format = Message.Format.MESSAGE_FORMAT) + value = "CompletionListener/SendAcknowledgementHandler used with confirmationWindowSize=-1. Enable confirmationWindowSize to receive acks from server!", + format = Message.Format.MESSAGE_FORMAT) void confirmationWindowDisabledWarning(); - @LogMessage(level = Logger.Level.WARN) @Message(id = 212054, - value = "Destination address={0} is blocked. If the system is configured to block make sure you consume messages on this configuration.", - format = Message.Format.MESSAGE_FORMAT) + value = "Destination address={0} is blocked. If the system is configured to block make sure you consume messages on this configuration.", + format = Message.Format.MESSAGE_FORMAT) void outOfCreditOnFlowControl(String address); @LogMessage(level = Logger.Level.WARN)