Return-Path: 
 <commits-return-25040-apmail-activemq-commits-archive=activemq.apache.org@activemq.apache.org>
X-Original-To: apmail-activemq-commits-archive@www.apache.org
Delivered-To: apmail-activemq-commits-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 9CA721065A
	for <apmail-activemq-commits-archive@www.apache.org>;
 Thu, 20 Mar 2014 18:44:19 +0000 (UTC)
Received: (qmail 87139 invoked by uid 500); 20 Mar 2014 18:44:09 -0000
Delivered-To: apmail-activemq-commits-archive@activemq.apache.org
Received: (qmail 87019 invoked by uid 500); 20 Mar 2014 18:44:08 -0000
Mailing-List: contact commits-help@activemq.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@activemq.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@activemq.apache.org>
List-Post: <mailto:commits@activemq.apache.org>
List-Id: <commits.activemq.apache.org>
Reply-To: dev@activemq.apache.org
Delivered-To: mailing list commits@activemq.apache.org
Received: (qmail 86748 invoked by uid 99); 20 Mar 2014 18:43:57 -0000
Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org)
 (140.211.11.114)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Mar 2014 18:43:57 +0000
Received: by tyr.zones.apache.org (Postfix, from userid 65534)
	id 38FE4986991; Thu, 20 Mar 2014 18:43:57 +0000 (UTC)
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: hadrian@apache.org
To: commits@activemq.apache.org
Date: Thu, 20 Mar 2014 18:43:59 -0000
Message-Id: <c14808982aef406eabffb3ca90a1dc00@git.apache.org>
In-Reply-To: <293487e0a3324c1eaef1741323a4a3f3@git.apache.org>
References: <293487e0a3324c1eaef1741323a4a3f3@git.apache.org>
X-Mailer: ASF-Git Admin Mailer
Subject: [03/18] git commit: [AMQ-4813] correct the URL encoding of message
 IDs. Use <c:url> to format <a href> urls.

[AMQ-4813] correct the URL encoding of message IDs.  Use <c:url> to format <a href> urls.


Project: http://git-wip-us.apache.org/repos/asf/activemq/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq/commit/62f710f1
Tree: http://git-wip-us.apache.org/repos/asf/activemq/tree/62f710f1
Diff: http://git-wip-us.apache.org/repos/asf/activemq/diff/62f710f1

Branch: refs/heads/activemq-5.9
Commit: 62f710f11bbc76ef435f0d012bcb46af86e73612
Parents: 8b87a01
Author: artnaseef <art@artnaseef.com>
Authored: Thu Feb 6 11:54:40 2014 -0700
Committer: Hadrian Zbarcea <hadrian@apache.org>
Committed: Thu Mar 20 13:52:55 2014 -0400

----------------------------------------------------------------------
 activemq-web-console/src/main/webapp/browse.jsp | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/activemq/blob/62f710f1/activemq-web-console/src/main/webapp/browse.jsp
----------------------------------------------------------------------
diff --git a/activemq-web-console/src/main/webapp/browse.jsp b/activemq-web-console/src/main/webapp/browse.jsp
index 628b3b9..4eb19eb 100644
--- a/activemq-web-console/src/main/webapp/browse.jsp
+++ b/activemq-web-console/src/main/webapp/browse.jsp
@@ -45,7 +45,9 @@
 <tbody>
 <jms:forEachMessage queueBrowser="${requestContext.queueBrowser.browser}" var="row">
 <tr>
-<td><a href="message.jsp?id=${row.JMSMessageID}&JMSDestination=<c:out value="${requestContext.queueBrowser.JMSDestination}" />" 
+<td><a href="<c:url value="message.jsp">
+                 <c:param name="id" value="${row.JMSMessageID}" />
+                 <c:param name="JMSDestination" value="${requestContext.queueBrowser.JMSDestination}"/></c:url>"
     title="${row.properties}">${row.JMSMessageID}</a></td>
 <td><c:out value="${row.JMSCorrelationID}"/></td>
 <td><jms:persistent message="${row}"/></td>
@@ -55,7 +57,10 @@
 <td><jms:formatTimestamp timestamp="${row.JMSTimestamp}"/></td>
 <td><c:out value="${row.JMSType}"/></td>
 <td>
-    <a href="deleteMessage.action?JMSDestination=<c:out value="${requestContext.queueBrowser.JMSDestination}"/>&messageId=${row.JMSMessageID}&secret=<c:out value='${sessionScope["secret"]}'/>">Delete</a>
+    <a href="<c:url value="deleteMessage.action">
+                 <c:param name="JMSDestination" value="${requestContext.queueBrowser.JMSDestination}"/>
+                 <c:param name="messageId" value="${row.JMSMessageID}"/>
+                 <c:param name="secret" value='${sessionScope["secret"]}'/></c:url>">Delete</a>
 </td>
 </tr>
 </jms:forEachMessage>
@@ -70,4 +75,4 @@
 
 </body>
 </html>
-	
+