activemq-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gtu...@apache.org
Subject git commit: have kahadb journal transaction commands respect enableJournalDiskSyncs - so consistent with leveldbstore - syncs off breaks the jms durability guarantee across the board - no good reason to distinguish transactional from non transaction ops;
Date Wed, 26 Mar 2014 16:38:07 GMT
Repository: activemq
Updated Branches:
  refs/heads/trunk 7a0168a4f -> 79ba2a79c


have kahadb journal transaction commands respect enableJournalDiskSyncs - so consistent with
leveldbstore - syncs off breaks the jms durability guarantee across the board - no good reason
to distinguish transactional from non transaction ops; the server qos can override the client


Project: http://git-wip-us.apache.org/repos/asf/activemq/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq/commit/79ba2a79
Tree: http://git-wip-us.apache.org/repos/asf/activemq/tree/79ba2a79
Diff: http://git-wip-us.apache.org/repos/asf/activemq/diff/79ba2a79

Branch: refs/heads/trunk
Commit: 79ba2a79c18d80bb251b3110e6db39efd8427b6e
Parents: 7a0168a
Author: gtully <gary.tully@gmail.com>
Authored: Wed Mar 26 16:37:23 2014 +0000
Committer: gtully <gary.tully@gmail.com>
Committed: Wed Mar 26 16:37:23 2014 +0000

----------------------------------------------------------------------
 .../apache/activemq/store/kahadb/KahaDBTransactionStore.java   | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/activemq/blob/79ba2a79/activemq-kahadb-store/src/main/java/org/apache/activemq/store/kahadb/KahaDBTransactionStore.java
----------------------------------------------------------------------
diff --git a/activemq-kahadb-store/src/main/java/org/apache/activemq/store/kahadb/KahaDBTransactionStore.java
b/activemq-kahadb-store/src/main/java/org/apache/activemq/store/kahadb/KahaDBTransactionStore.java
index 1ca1def..12e5f00 100755
--- a/activemq-kahadb-store/src/main/java/org/apache/activemq/store/kahadb/KahaDBTransactionStore.java
+++ b/activemq-kahadb-store/src/main/java/org/apache/activemq/store/kahadb/KahaDBTransactionStore.java
@@ -283,7 +283,7 @@ public class KahaDBTransactionStore implements TransactionStore {
                     }
                     if (doneSomething) {
                         KahaTransactionInfo info = getTransactionInfo(txid);
-                        theStore.store(new KahaCommitCommand().setTransactionInfo(info),
true, null, null);
+                        theStore.store(new KahaCommitCommand().setTransactionInfo(info),
theStore.isEnableJournalDiskSyncs(), null, null);
                     }
                 }else {
                     //The Tx will be null for failed over clients - lets run their post commits
@@ -294,7 +294,7 @@ public class KahaDBTransactionStore implements TransactionStore {
 
             } else {
                 KahaTransactionInfo info = getTransactionInfo(txid);
-                theStore.store(new KahaCommitCommand().setTransactionInfo(info), true, preCommit,
postCommit);
+                theStore.store(new KahaCommitCommand().setTransactionInfo(info), theStore.isEnableJournalDiskSyncs(),
preCommit, postCommit);
                 forgetRecoveredAcks(txid, false);
             }
         }else {
@@ -309,7 +309,7 @@ public class KahaDBTransactionStore implements TransactionStore {
     public void rollback(TransactionId txid) throws IOException {
         if (txid.isXATransaction() || theStore.isConcurrentStoreAndDispatchTransactions()
== false) {
             KahaTransactionInfo info = getTransactionInfo(txid);
-            theStore.store(new KahaRollbackCommand().setTransactionInfo(info), false, null,
null);
+            theStore.store(new KahaRollbackCommand().setTransactionInfo(info), theStore.isEnableJournalDiskSyncs(),
null, null);
             forgetRecoveredAcks(txid, true);
         } else {
             inflightTransactions.remove(txid);


Mime
View raw message