activemq-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christian Posta (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APLO-325) Allow larger text messages on websocket connection
Date Thu, 18 Jul 2013 02:40:48 GMT

    [ https://issues.apache.org/jira/browse/APLO-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13711951#comment-13711951
] 

Christian Posta commented on APLO-325:
--------------------------------------

So I have a patch to fix this. It relies on setting the underlying websocket connection max
text message size:

WebSocket.Connection#setMaxTextMessageSize

There is also a method for #setMaxBinaryMessageSize

Think it's the same in ActiveMQ 5.x (see the WSTransportServer.java#doStart)

Just getting the last of the unit tests to pass (having some issues with the WSS test of course,
unrelated to this change... will hopefully have it ready by tomorrow and attach the patch
to this JIRA if you want to review).

This will all change when the Jetty 9 API is used, but will be similar (there is a websocket
client factory on which you can make the same text/binary message size settings).

Should we also make the change in the client JS libs?
                
> Allow larger text messages on websocket connection
> --------------------------------------------------
>
>                 Key: APLO-325
>                 URL: https://issues.apache.org/jira/browse/APLO-325
>             Project: ActiveMQ Apollo
>          Issue Type: Improvement
>          Components: apollo-stomp, apollo-web
>    Affects Versions: 1.6
>         Environment: Mac OS X 10.8.3, jdk 1.7.0_21
>            Reporter: Oliver Mross
>            Assignee: Christian Posta
>            Priority: Critical
>              Labels: features
>             Fix For: 1.7
>
>         Attachments: APLO-325-reproduce-test_patch.patch
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> I want to send 'not so large'  XML-content over a websocket connection to a server-side
middleware component, but the broker complains with the following message. If there is a way
to configure the text message size of the websocket connector within the broker config-file,
I've not found it. If not, please add an option to configure that within the config file or
in code in the case of an embedded broker.
>  org.eclipse.jetty.websocket.WebSocketConnectionRFC6455$WSFrameHandler textMessageTooLarge
> WARNING: Text message too large > 16384 chars for SCEP@2639a53a{l(/127.0.0.1:51180)<->r(/127.0.0.1:8082),d=true,open=true,ishut=false,oshut=false,rb=false,wb=false,w=true,i=1r}-{WebSocketServletConnectionRFC6455
p=WebSocketParserRFC6455@60c5b6 state=DATA buffer= g=WebSocketGeneratorRFC6455@51542feb closed=false
buffer=-1}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message