Return-Path: X-Original-To: apmail-activemq-commits-archive@www.apache.org Delivered-To: apmail-activemq-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2701A10124 for ; Wed, 5 Jun 2013 19:59:04 +0000 (UTC) Received: (qmail 31427 invoked by uid 500); 5 Jun 2013 19:59:04 -0000 Delivered-To: apmail-activemq-commits-archive@activemq.apache.org Received: (qmail 31400 invoked by uid 500); 5 Jun 2013 19:59:04 -0000 Mailing-List: contact commits-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list commits@activemq.apache.org Received: (qmail 31393 invoked by uid 99); 5 Jun 2013 19:59:04 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Jun 2013 19:59:04 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Jun 2013 19:59:01 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id D590323889EB; Wed, 5 Jun 2013 19:58:40 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1490015 - /activemq/trunk/activemq-unit-tests/src/test/java/org/apache/activemq/JmsQueueBrowserTest.java Date: Wed, 05 Jun 2013 19:58:40 -0000 To: commits@activemq.apache.org From: tabish@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20130605195840.D590323889EB@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: tabish Date: Wed Jun 5 19:58:40 2013 New Revision: 1490015 URL: http://svn.apache.org/r1490015 Log: Use the right Logger type. Modified: activemq/trunk/activemq-unit-tests/src/test/java/org/apache/activemq/JmsQueueBrowserTest.java Modified: activemq/trunk/activemq-unit-tests/src/test/java/org/apache/activemq/JmsQueueBrowserTest.java URL: http://svn.apache.org/viewvc/activemq/trunk/activemq-unit-tests/src/test/java/org/apache/activemq/JmsQueueBrowserTest.java?rev=1490015&r1=1490014&r2=1490015&view=diff ============================================================================== --- activemq/trunk/activemq-unit-tests/src/test/java/org/apache/activemq/JmsQueueBrowserTest.java (original) +++ activemq/trunk/activemq-unit-tests/src/test/java/org/apache/activemq/JmsQueueBrowserTest.java Wed Jun 5 19:58:40 2013 @@ -38,13 +38,12 @@ import org.apache.activemq.broker.region import org.apache.activemq.broker.region.policy.PolicyEntry; import org.apache.activemq.broker.region.policy.PolicyMap; import org.apache.activemq.command.ActiveMQQueue; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; -/** - * - */ public class JmsQueueBrowserTest extends JmsTestSupport { - private static final org.apache.commons.logging.Log LOG = org.apache.commons.logging.LogFactory - .getLog(JmsQueueBrowserTest.class); + + private static final Logger LOG = LoggerFactory.getLogger(ActiveMQXAConnectionFactoryTest.class); public boolean isUseCache = false; public static Test suite() throws Exception { @@ -79,7 +78,6 @@ public class JmsQueueBrowserTest extends // Get the first. assertEquals(outbound[0], consumer.receive(1000)); consumer.close(); - //Thread.sleep(200); QueueBrowser browser = session.createBrowser(destination); Enumeration enumeration = browser.getEnumeration(); @@ -108,7 +106,6 @@ public class JmsQueueBrowserTest extends // Receive the third. assertEquals(outbound[2], consumer.receive(1000)); consumer.close(); - } public void initCombosForTestBatchSendBrowseReceive() { @@ -167,7 +164,6 @@ public class JmsQueueBrowserTest extends consumer.close(); } - public void initCombosForTestBatchSendJmxBrowseReceive() { addCombinationValues("isUseCache", new Boolean[]{Boolean.TRUE, Boolean.FALSE}); } @@ -286,7 +282,6 @@ public class JmsQueueBrowserTest extends session.createTextMessage("Second Message"), session.createTextMessage("Third Message")}; - MessageProducer producer = session.createProducer(destination); producer.send(outbound[0]); @@ -303,7 +298,6 @@ public class JmsQueueBrowserTest extends consumer.close(); browser.close(); producer.close(); - } public void testLargeNumberOfMessages() throws Exception { @@ -325,7 +319,12 @@ public class JmsQueueBrowserTest extends int numberBrowsed = 0; while (enumeration.hasMoreElements()) { - enumeration.nextElement(); + Message browsed = (Message) enumeration.nextElement(); + + if (LOG.isDebugEnabled()) { + LOG.debug("Browsed Message [{}]", browsed.getJMSMessageID()); + } + numberBrowsed++; } @@ -333,7 +332,6 @@ public class JmsQueueBrowserTest extends assertEquals(1000, numberBrowsed); browser.close(); producer.close(); - } public void testQueueBrowserWith2Consumers() throws Exception { @@ -400,7 +398,6 @@ public class JmsQueueBrowserTest extends session.createTextMessage("Second Message"), session.createTextMessage("Third Message")}; - // create consumer MessageConsumer consumer = session.createConsumer(destination); // lets consume any outstanding messages from previous test runs @@ -412,7 +409,6 @@ public class JmsQueueBrowserTest extends producer.send(outbound[1]); producer.send(outbound[2]); - // create browser first QueueBrowser browser = session.createBrowser(destination); Enumeration enumeration = browser.getEnumeration();