activemq-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chir...@apache.org
Subject svn commit: r1480710 - /activemq/trunk/activemq-leveldb-store/src/main/scala/org/apache/activemq/leveldb/LevelDBClient.scala
Date Thu, 09 May 2013 16:11:36 GMT
Author: chirino
Date: Thu May  9 16:11:36 2013
New Revision: 1480710

URL: http://svn.apache.org/r1480710
Log:
Suspend/Resume index compactions instead of closing out the index.

Modified:
    activemq/trunk/activemq-leveldb-store/src/main/scala/org/apache/activemq/leveldb/LevelDBClient.scala

Modified: activemq/trunk/activemq-leveldb-store/src/main/scala/org/apache/activemq/leveldb/LevelDBClient.scala
URL: http://svn.apache.org/viewvc/activemq/trunk/activemq-leveldb-store/src/main/scala/org/apache/activemq/leveldb/LevelDBClient.scala?rev=1480710&r1=1480709&r2=1480710&view=diff
==============================================================================
--- activemq/trunk/activemq-leveldb-store/src/main/scala/org/apache/activemq/leveldb/LevelDBClient.scala
(original)
+++ activemq/trunk/activemq-leveldb-store/src/main/scala/org/apache/activemq/leveldb/LevelDBClient.scala
Thu May  9 16:11:36 2013
@@ -835,22 +835,28 @@ class LevelDBClient(store: LevelDBStore)
       writeExecutor = null
 
       // this blocks until all io completes..
-      // Suspend also deletes the index.
-      if( index!=null ) {
-        suspend()
-        index = null
-      }
-
-      if (log.isOpen) {
-        log.close
-        copyDirtyIndexToSnapshot
-        wal_append_position = log.appender_limit
-      }
-      if( plist!=null ) {
-        plist.close
-        plist=null
+      snapshotRwLock.writeLock().lock()
+      try {
+        // Suspend also deletes the index.
+        if( index!=null ) {
+          storeCounters
+          index.put(DIRTY_INDEX_KEY, FALSE, new WriteOptions().sync(true))
+          index.close
+          index = null
+        }
+        if (log.isOpen) {
+          log.close
+          copyDirtyIndexToSnapshot
+          wal_append_position = log.appender_limit
+          log = null
+        }
+        if( plist!=null ) {
+          plist.close
+          plist=null
+        }
+      } finally {
+        snapshotRwLock.writeLock().unlock()
       }
-      log = null
     }
   }
 
@@ -875,10 +881,10 @@ class LevelDBClient(store: LevelDBStore)
     // we will be closing it to create a consistent snapshot.
     snapshotRwLock.writeLock().lock()
 
-    // Close the index so that it's files are not changed async on us.
     storeCounters
     index.put(DIRTY_INDEX_KEY, FALSE, new WriteOptions().sync(true))
-    index.close
+    // Suspend the index so that it's files are not changed async on us.
+    index.db.suspendCompactions()
   }
 
   /**
@@ -887,10 +893,7 @@ class LevelDBClient(store: LevelDBStore)
    */
   def resume() = {
     // re=open it..
-    retry {
-      index = new RichDB(factory.open(dirtyIndexFile, indexOptions));
-      index.put(DIRTY_INDEX_KEY, TRUE)
-    }
+    index.db.resumeCompactions()
     snapshotRwLock.writeLock().unlock()
   }
 



Mime
View raw message