Return-Path: X-Original-To: apmail-activemq-commits-archive@www.apache.org Delivered-To: apmail-activemq-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EF5F09F00 for ; Mon, 9 Apr 2012 20:39:40 +0000 (UTC) Received: (qmail 74488 invoked by uid 500); 9 Apr 2012 20:39:40 -0000 Delivered-To: apmail-activemq-commits-archive@activemq.apache.org Received: (qmail 74417 invoked by uid 500); 9 Apr 2012 20:39:40 -0000 Mailing-List: contact commits-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list commits@activemq.apache.org Received: (qmail 74378 invoked by uid 99); 9 Apr 2012 20:39:40 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Apr 2012 20:39:40 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Apr 2012 20:39:39 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id B10BF3629D8 for ; Mon, 9 Apr 2012 20:39:19 +0000 (UTC) Date: Mon, 9 Apr 2012 20:39:19 +0000 (UTC) From: "Hiram Chirino (Commented) (JIRA)" To: commits@activemq.apache.org Message-ID: <2091426152.4584.1334003959726.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1687835457.16045.1333608249424.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (APLO-185) Apollo can send STOMP messages without a destination header (advisories) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/APLO-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250158#comment-13250158 ] Hiram Chirino commented on APLO-185: ------------------------------------ I've also now changed this so that the Advisory topic is not created until the topic is subscribed to. Helps keep the Openwire support hidden until it's fully supported and documented. > Apollo can send STOMP messages without a destination header (advisories) > ------------------------------------------------------------------------ > > Key: APLO-185 > URL: https://issues.apache.org/jira/browse/APLO-185 > Project: ActiveMQ Apollo > Issue Type: Bug > Environment: apollo-99-trunk-20120404.190241-13 > Reporter: Lionel Cons > Assignee: Hiram Chirino > Fix For: 1.2 > > > As discovered by accident in the console, recent Apollo snapshots use the following topics: ActiveMQ.Advisory.Topic and ActiveMQ.Advisory.Queue. > When trying to consume messages from these, the messages do not contain a "destination" header, this way violating the STOMP 1.1 spec. > Here is an example (the body contains binary characters): > 'body' => t{)ID:xxx-21826-1333604711518-0:0eActiveMQ.Advisory.Queuen{)ID:xxx-21826-1333604711518-0:0AdvisoryoriginBrokerId NOT_SETd?monitor.test.yyy.apollo.xxx.stomp', > 'header' => { > 'content-length' => '378', > 'content-type' => 'protocol/openwire', > 'message-id' => 'apollo-5418', > 'subscription' => '8988460-4f7d3c07-589d-fa9a-6' > }, > Could the "destination" header be added please? > This also brings other questions: > (1) why does Apollo generate protocol/openwire messages although I did not enable OpenWire? > (2) if these advisories are useful without OpenWire, the body should be easier to parse (e.g. JSON) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira