activemq-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rajdav...@apache.org
Subject svn commit: r1325621 - /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/store/jdbc/DefaultDatabaseLocker.java
Date Fri, 13 Apr 2012 05:55:50 GMT
Author: rajdavies
Date: Fri Apr 13 05:55:50 2012
New Revision: 1325621

URL: http://svn.apache.org/viewvc?rev=1325621&view=rev
Log:
Applied patch for https://issues.apache.org/jira/browse/AMQ-3681

Modified:
    activemq/trunk/activemq-core/src/main/java/org/apache/activemq/store/jdbc/DefaultDatabaseLocker.java

Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/store/jdbc/DefaultDatabaseLocker.java
URL: http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/store/jdbc/DefaultDatabaseLocker.java?rev=1325621&r1=1325620&r2=1325621&view=diff
==============================================================================
--- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/store/jdbc/DefaultDatabaseLocker.java
(original)
+++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/store/jdbc/DefaultDatabaseLocker.java
Fri Apr 13 05:55:50 2012
@@ -20,6 +20,7 @@ import java.io.IOException;
 import java.sql.Connection;
 import java.sql.PreparedStatement;
 import java.sql.SQLException;
+import java.sql.SQLFeatureNotSupportedException;
 
 import javax.sql.DataSource;
 
@@ -41,6 +42,8 @@ public class DefaultDatabaseLocker imple
     protected Statements statements;
     protected long lockAcquireSleepInterval = DEFAULT_LOCK_ACQUIRE_SLEEP_INTERVAL;
 
+    protected PreparedStatement lockCreateStatement;
+    protected PreparedStatement lockUpdateStatement;
     protected Connection connection;
     protected boolean stopping;
     protected Handler<Exception> exceptionHandler;
@@ -64,13 +67,12 @@ public class DefaultDatabaseLocker imple
         String sql = statements.getLockCreateStatement();
         LOG.debug("Locking Query is "+sql);
         
-        PreparedStatement statement = null;
         while (true) {
             try {
                 connection = dataSource.getConnection();
                 connection.setAutoCommit(false);
-                statement = connection.prepareStatement(sql);
-                statement.execute();
+                lockCreateStatement = connection.prepareStatement(sql);
+                lockCreateStatement.execute();
                 break;
             } catch (Exception e) {
                 try {
@@ -110,13 +112,13 @@ public class DefaultDatabaseLocker imple
                     }
                 }
             } finally {
-                if (null != statement) {
+                if (null != lockCreateStatement) {
                     try {
-                        statement.close();
+                        lockCreateStatement.close();
                     } catch (SQLException e1) {
                         LOG.debug("Caught while closing statement: " + e1, e1);
                     }
-                    statement = null;
+                    lockCreateStatement = null;
                 }
             }
 
@@ -134,6 +136,20 @@ public class DefaultDatabaseLocker imple
     public void stop() throws Exception {
         stopping = true;
         try {
+            if (lockCreateStatement != null) {
+                lockCreateStatement.cancel();    			
+            }
+        } catch (SQLFeatureNotSupportedException e) {
+            LOG.warn("Failed to cancel locking query on dataSource" + dataSource, e);   
		
+        }
+        try {
+    	    if (lockUpdateStatement != null) {
+        	    lockUpdateStatement.cancel();    			
+    	    }
+        } catch (SQLFeatureNotSupportedException e) {
+            LOG.warn("Failed to cancel locking query on dataSource" + dataSource, e);   
		
+        }
+        try {
             if (connection != null && !connection.isClosed()) {
                 try {
                     connection.rollback();
@@ -145,6 +161,7 @@ public class DefaultDatabaseLocker imple
                     } catch (SQLException ignored) {
                         LOG.debug("Exception while closing connection on shutdown", ignored);
                     }
+                    lockCreateStatement = null;
                 }
             }
         } catch (SQLException sqle) {
@@ -153,24 +170,25 @@ public class DefaultDatabaseLocker imple
     }
 
     public boolean keepAlive() {
-        PreparedStatement statement = null;
         boolean result = false;
         try {
-            statement = connection.prepareStatement(statements.getLockUpdateStatement());
-            statement.setLong(1, System.currentTimeMillis());
-            int rows = statement.executeUpdate();
+            lockUpdateStatement = connection.prepareStatement(statements.getLockUpdateStatement());
+            lockUpdateStatement.setLong(1, System.currentTimeMillis());
+            lockUpdateStatement.setQueryTimeout(10);
+            int rows = lockUpdateStatement.executeUpdate();
             if (rows == 1) {
                 result=true;
             }
         } catch (Exception e) {
             LOG.error("Failed to update database lock: " + e, e);
         } finally {
-            if (statement != null) {
+            if (lockUpdateStatement != null) {
                 try {
-                    statement.close();
+                    lockUpdateStatement.close();
                 } catch (SQLException e) {
                     LOG.error("Failed to close statement",e);
                 }
+                lockUpdateStatement = null;
             }
         }
         return result;



Mime
View raw message