Return-Path: X-Original-To: apmail-activemq-commits-archive@www.apache.org Delivered-To: apmail-activemq-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6439265AB for ; Wed, 25 May 2011 01:51:28 +0000 (UTC) Received: (qmail 69070 invoked by uid 500); 25 May 2011 01:51:28 -0000 Delivered-To: apmail-activemq-commits-archive@activemq.apache.org Received: (qmail 69048 invoked by uid 500); 25 May 2011 01:51:28 -0000 Mailing-List: contact commits-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list commits@activemq.apache.org Received: (qmail 69041 invoked by uid 99); 25 May 2011 01:51:28 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 May 2011 01:51:28 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 May 2011 01:51:27 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 57A76DD83F for ; Wed, 25 May 2011 01:50:47 +0000 (UTC) Date: Wed, 25 May 2011 01:50:47 +0000 (UTC) From: "Hiram Chirino (JIRA)" To: commits@activemq.apache.org Message-ID: <1070760182.41180.1306288247339.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (APLO-6) Alternative topic separators should be supported in Apollo, as in ActiveMQ MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/APLO-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038916#comment-13038916 ] Hiram Chirino commented on APLO-6: ---------------------------------- Hi Sam, I've worked on it some more and I figured out how to get it work as I originally proposed. The latest snapshot should have the enhancement. The full list of XML attributes supported is listed at: http://activemq.apache.org/apollo/versions/1.0-SNAPSHOT/website/documentation/user-manual.html#Stomp_Protocol_Options > Alternative topic separators should be supported in Apollo, as in ActiveMQ > -------------------------------------------------------------------------- > > Key: APLO-6 > URL: https://issues.apache.org/jira/browse/APLO-6 > Project: ActiveMQ Apollo > Issue Type: New Feature > Components: apollo-broker > Affects Versions: 1.0-beta2 > Environment: All environments. > Reporter: Sam Starling > Assignee: Hiram Chirino > Priority: Minor > Labels: apollo, topic > Fix For: 1.0-beta3 > > > When using a character other than a period as a topic separator (.), Apollo throws the following exception: > {code} > org.apache.activemq.apollo.util.path.PathParser$PathException: Invalid destination path part: 'event/abc', it does not match regex: [a-zA-Z0-9\_\-\%\~]+ > {code} > In the example, we're using {{/topic/event/abc}} as a topic. In {{[PathParser.java|http://svn.apache.org/viewvc/activemq/activemq-apollo/trunk/apollo-util/src/main/scala/org/apache/activemq/apollo/util/path/PathParser.java?view=markup]}}, line 47 determines that {{path_seperator = new AsciiBuffer(".")}}. Thus, Apollo incorrectly tokenizes the topic and so {{event/abc}} fails the regular expression on line 48 of the same file. > In short, it should be possible to specify what the topic separator is, or (even better) detect when a different character is being used as a delimiter. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira