activemq-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gtu...@apache.org
Subject svn commit: r1083753 - in /activemq/trunk/activemq-core/src: main/java/org/apache/activemq/transport/stomp/StompFrame.java test/java/org/apache/activemq/transport/stomp/StompFrameTest.java
Date Mon, 21 Mar 2011 12:21:37 GMT
Author: gtully
Date: Mon Mar 21 12:21:37 2011
New Revision: 1083753

URL: http://svn.apache.org/viewvc?rev=1083753&view=rev
Log:
https://issues.apache.org/jira/browse/AMQ-3231 - Stomp Frame should mask passcode header in
toString output, so it does not pollute the log

Added:
    activemq/trunk/activemq-core/src/test/java/org/apache/activemq/transport/stomp/StompFrameTest.java
  (with props)
Modified:
    activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/stomp/StompFrame.java

Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/stomp/StompFrame.java
URL: http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/stomp/StompFrame.java?rev=1083753&r1=1083752&r2=1083753&view=diff
==============================================================================
--- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/stomp/StompFrame.java
(original)
+++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/stomp/StompFrame.java
Mon Mar 21 12:21:37 2011
@@ -180,7 +180,11 @@ public class StompFrame implements Comma
             Map.Entry entry = (Map.Entry)iter.next();
             buffer.append(entry.getKey());
             buffer.append(":");
-            buffer.append(entry.getValue());
+            if (entry.getKey().toString().toLowerCase().contains(Stomp.Headers.Connect.PASSCODE))
{
+                buffer.append("*****");
+            } else {
+                buffer.append(entry.getValue());
+            }
             buffer.append("\n");
         }
         buffer.append("\n");

Added: activemq/trunk/activemq-core/src/test/java/org/apache/activemq/transport/stomp/StompFrameTest.java
URL: http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/test/java/org/apache/activemq/transport/stomp/StompFrameTest.java?rev=1083753&view=auto
==============================================================================
--- activemq/trunk/activemq-core/src/test/java/org/apache/activemq/transport/stomp/StompFrameTest.java
(added)
+++ activemq/trunk/activemq-core/src/test/java/org/apache/activemq/transport/stomp/StompFrameTest.java
Mon Mar 21 12:21:37 2011
@@ -0,0 +1,40 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.transport.stomp;
+
+import java.util.HashMap;
+import org.junit.Test;
+
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
+
+public class StompFrameTest {
+    StompFrame underTest = new StompFrame();
+
+    @Test
+    public void testNoPasscodeInToString() throws Exception {
+        HashMap headers = new HashMap<String, String>();
+        headers.put("userName", "bob");
+        headers.put("passcode", "please");
+        underTest.setHeaders(headers);
+
+        assertEquals("no password present", -1, underTest.toString().indexOf("please"));
+        assertTrue("*** present", underTest.toString().indexOf("***") > 0);
+    }
+}

Propchange: activemq/trunk/activemq-core/src/test/java/org/apache/activemq/transport/stomp/StompFrameTest.java
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: activemq/trunk/activemq-core/src/test/java/org/apache/activemq/transport/stomp/StompFrameTest.java
------------------------------------------------------------------------------
    svn:keywords = Rev Date



Mime
View raw message